From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ACF3F941AB6 for ; Tue, 27 Feb 2024 15:26:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DM+WV4CaChKTIME7Jnu9Tq9h/FgI4j2JZ0i8kwuuLJo=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709047603; v=1; b=u0ScT2NghHUQO1g04tw9dNfSzAvz+EW6Qr2evnhAFcrMHVWuIsD1cgZVuLFFaoWUS4aE97rj cgrCwSTvN63uXqDHUAK8lqqikA4yJfFXPPBxLRn2rFjq4ejgUlgm5WGfq7EV1K1uQMfFbRQAY27 n96pPNGhKneL7HWkgdTi33go= X-Received: by 127.0.0.2 with SMTP id p2CnYY7687511xtmL8w9R1pq; Tue, 27 Feb 2024 07:26:43 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.14871.1709047602458405502 for ; Tue, 27 Feb 2024 07:26:42 -0800 X-Received: from [10.0.0.154] (unknown [20.39.63.5]) by linux.microsoft.com (Postfix) with ESMTPSA id AD68720B74C0; Tue, 27 Feb 2024 07:26:41 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AD68720B74C0 Message-ID: Date: Tue, 27 Feb 2024 10:26:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions being deprecated To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Joey Vagedes References: <20240227043847.125-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BwPCOxrZritqs0fCGTWjwB2qx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=u0ScT2Ng; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/27/2024 1:33 AM, Michael D Kinney wrote: >> -----Original Message----- >> From: mikuback@linux.microsoft.com >> Sent: Monday, February 26, 2024 8:39 PM >> To: devel@edk2.groups.io >> Cc: Sean Brogan ; Joey Vagedes >> ; Kinney, Michael D >> >> Subject: [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions >> being deprecated >> >> From: Michael Kubacki >> >> Currently CodeQL runs have the following warnings: >> >> Node.js 16 actions are deprecated. Please update the following >> actions to use Node.js 20: actions/setup-python@v4, >> actions/upload-artifact@v3, actions/cache@v3. For more information >> see: >> https://github.blog/changelog/2023-09-22-github-actions- >> transitioning-from-node-16-to-node-20/. >> >> And: >> >> CodeQL Action v2 will be deprecated on December 5th, 2024. Please >> update all occurrences of the CodeQL Action in your workflow files >> to v3. For more information, see: >> https://github.blog/changelog/2024-01-12-code-scanning-deprecation- >> of-codeql-action-v2/ >> >> The first is resolved by updating the actions to the latest versions >> that were released to use Node.js 20. The second is specifically >> referring to the codeql-action/upload-sarif action which is at v2. >> >> This change updates all of the actions to the latest releases to >> prevent deprecated versions from continuing to be used. >> >> Cc: Sean Brogan >> Cc: Joey Vagedes >> Cc: Michael D Kinney >> Signed-off-by: Michael Kubacki >> --- >> .github/workflows/codeql.yml | 37 +++++++++++++------- >> 1 file changed, 24 insertions(+), 13 deletions(-) >> >> diff --git a/.github/workflows/codeql.yml >> b/.github/workflows/codeql.yml >> index c91e9d4dbeb3..e0c5f69f6cdf 100644 >> --- a/.github/workflows/codeql.yml >> +++ b/.github/workflows/codeql.yml >> @@ -79,7 +79,7 @@ jobs: >> uses: actions/checkout@v4 >> >> - name: Install Python >> - uses: actions/setup-python@v4 >> + uses: actions/setup-python@v5 >> with: >> python-version: '3.11' >> cache: 'pip' >> @@ -136,15 +136,26 @@ jobs: >> >> print(f'ci_setup_supported=3D{str(ci_setup_supported).lower()}', file=3D= fh) >> print(f'setup_supported=3D{str(setup_supported).lower()}', >> file=3Dfh) >> >> + - name: Convert Arch to Log Format >> + id: convert_arch_hyphen >> + env: >> + ARCH_LIST: ${{ matrix.ArchList }} >> + shell: python >> + run: | >> + import os >> + >> + with open(os.environ['GITHUB_OUTPUT'], 'a') as fh: >> + print(f'arch_list=3D{os.environ["ARCH_LIST"].replace(",", "= - >> ")}', file=3Dfh) >=20 > I do not see this change described in the commit message. Is it related? >=20 Yes. A breaking change=20 (https://github.com/actions/upload-artifact?tab=3Dreadme-ov-file#breaking-c= hanges)=20 in the actions/upload-artifact action is: "Due to how Artifacts are created in this new version, it is no longer=20 possible to upload to the same named Artifact multiple times. You must=20 either split the uploads into multiple Artifacts with different names,=20 or only upload once. Otherwise you will encounter an error." We depended on that behavior previously to append multiple logs (e.g.=20 setup log, update log, build log) to the same named artifact (named per=20 package). These were appended after each operation so they are readily=20 available if the operation failed and no further actions are run. Now the artifacts must be unique in name. The hyphenation comes in=20 because edk2 further builds some packages with both architectures in=20 single build vs separate builds (e.g. IA32 and X64 vs IA32,X64). To=20 uniquely name artifacts resulting from those builds, the architecture is=20 also placed in the artifact name. For builds with multiple architectures=20 the artifact name captures each architecture separated by a hyphen. The final result is shown here:=20 https://github.com/tianocore/edk2/actions/runs/8059750360 I will update the commit message to mention a behavior change in the=20 underlying action caused a change in artifact naming convention. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116048): https://edk2.groups.io/g/devel/message/116048 Mute This Topic: https://groups.io/mt/104597854/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-