From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68817941922 for ; Fri, 26 Jan 2024 17:38:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bpUrQKOPwhXI8mhtSPk6h6a1L0Ep2PJteyEJsBfoaZo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:From:To:CC:References:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706290687; v=1; b=CL3qHXyv2BNg5MAwUFUsQi9nseAfKCJK4o2zqQXfgDZVfFlX+1E7AuxM/artUHpNUxsLTd6R nvyRcVmjsWyJSdMW5bK5+ZqoBr1HBWltl34Knc5+tmwXgh6TAZNKRDlbktVK5DcrBNQkLdTi4cU 84r7YW3m9A7SQFtmHQ3tNE7s= X-Received: by 127.0.0.2 with SMTP id uAg8YY7687511xfgMLQFhS8X; Fri, 26 Jan 2024 09:38:07 -0800 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.48]) by mx.groups.io with SMTP id smtpd.web10.278.1706290686650653898 for ; Fri, 26 Jan 2024 09:38:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qo7klaCbr0cf2krhha3Fvp2MCh/dNF37rFt/JLu8bUhR41lQ7wutYuk5BSeRY9E3WQC/Xgj9YHda7u9heSIw+bAu+F3tcbx9+h84DZGUX92Uq5v2xmgTvvM2UBfzXw3RAqsJsOzkOVDB2PSzxqANY5FthKUi6oYwxEl4Fk/husyrvPQrtfCGP0hNxrWAGiBEnSwUWwZow8HryXmTzO+GokH9ksbhrRwk9QP9TcSmL6b+R19s0LvmjJ9m0VhMAif/jl/zK62KD3cM5y4QJubp+ImJqGjoimEtqCDLJHuLM3iHnphVoQSu28VygVOZtnkaGwpqlVPz2f3g2ASGzpU/lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6OZB+OiBftYW6CRMQ1Z2rn946lI14ROO9h9hr0AKjag=; b=P7kAXcjVHoxW40qyGDw+y8DG4s9zd9vobJHqqJi7DQ/CcGjERFNxdCIzxti+G782UitDDH06GSyoIUUhmbfNcrhOag30UxCfeIsB//SSpFn+ziqvVN/7dpDDZq7+rVzoR3HO5W5tVyTIwcQOlkSt0atMfmsPkXyYufDUIQorkD19u2qeTiEN1mN6XZhftsyiIl0WdDPmQKdosMd7zP8nEES60/kxakQYIeNu+LEvwP2i+N4ddNfW1F6bufs/WxN4FLJ+EeFBFi8pPDJFczV4AlDtm6vyw1o/CgjHxY7+mIsyQDtZ+ucEIK+tQtMhXDNBSrfE3sZ3DNe6AuZwKNnQuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by MW3PR12MB4347.namprd12.prod.outlook.com (2603:10b6:303:2e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27; Fri, 26 Jan 2024 17:38:03 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c%4]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024 17:38:03 +0000 Message-ID: Date: Fri, 26 Jan 2024 11:38:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Add feedback status for PciIoMap From: "Lendacky, Thomas via groups.io" To: devel@edk2.groups.io, w.sheng@intel.com, "Xu, Min M" CC: Ray Ni , Huang Jenny , Chiang Chris References: <20240122064706.2059-1-w.sheng@intel.com> In-Reply-To: X-ClientProxiedBy: SA0PR13CA0010.namprd13.prod.outlook.com (2603:10b6:806:130::15) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|MW3PR12MB4347:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ad10175-8ed7-4f10-4665-08dc1e958c6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: DQq6GD4mB/c9zcLjACAFtDD++Eklc0dBpnhhHjfCiaiqzekTY8BdxbTU4gTibngLXtAYerJThYWuTqi2aVc+ucJTKYdQLvH+Bcgps2DyOSOKo4RyB+vBxqt3CDZ3KTvtBjpIBejv/qMbSAOnAefYrBkkGT6MBEm4YXSyY5s1NQgiO6LSy2oZESuPkZsTnBylkpE5JAH/6OB2P0RXxsvakQs8BgPe7WARnXnwnm3rrabGa7EGOd4WpF3KWZ+hlccMSt64AMLUwVFbnqvUL7Zuztl5Mn6NjR3w/g5R8/R8xEJJoUU1ai9UC6+3lYbCbqVE2J/Jt1/tlKeRg2FTGZi+2GyYxiMhhcdB8FZlrMGOLSoESC7yIZoJ1CuwIrt/ZKHsr8c6l5YSZsHhHFXt/lxffTGymuHINocWRTDM7cf8Yst1Kj6w0QNznAnqfNCD4injc+T4S2H7VoCYMxtdC2NMTVJZ17um2puoiJKvRjk7UpfJI+2/sRRSlVC+QlXx0ueSsIyn14iU6wLC4jsya+lJMbTvsnPHsLlzLK2K7icoMjnwafb3r2jDZ2U5mzxd6SVdfiwBAmx08ox6T86Lvg/q4hxctqbfVta8424DvIN4siqtuEo6VqZGWd6eCcjKJstAcv1P1C7Vuz0S5E4zwQwTLw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OC8jMownDcrIssw6134MzJZtNZGkLmSYYN/rOnjshqg/ki+UAsVcYRkObBEF?= =?us-ascii?Q?eo7t7aic76B2fR3hpzW4v3/fsfNqfuwl29kcxndm0WyhCj1q4U3fCCC8bONZ?= =?us-ascii?Q?OqH2gzwfFVljqXJVrguyIPYXc+QoJb+sBDW+KmzstnnCmdzdPyaITCxMKdId?= =?us-ascii?Q?adnhKrf8tLOiROnxcRGiRUG95r2Nvwlavd0BLxZMdW7kmRkbxFnAaTu4FRhY?= =?us-ascii?Q?fo6rVlSAw4QMMQ7+Ru/VOVD6aZajmP6FjqMCJ8Iq8d99OuUJQJ/FG2mpU29M?= =?us-ascii?Q?4KyKH8sts6NDNybaZ0DGi/D8BMq0faVFC2EOPvBNIETymQez99mLD3jDmnCd?= =?us-ascii?Q?EdIOD4Arv+kdJg/74MgcQUDXz4Hd/PXhydsgQgo4TS3RgAdNS1/H1JQpQH2L?= =?us-ascii?Q?LqEly0nFL2TXHsWR58wsAyRK5ezyOD2Yip/NrXT6shJVvjCiaIXEh4LxnlAW?= =?us-ascii?Q?wFICuCVt84RuWGWx87RDi7MnXGxaZdwPxxNOmzuKZU+k2X5//rGY0Y+dSacG?= =?us-ascii?Q?bg5DDUCIP5gGCPUYme/k9Ke2pNE8TSouDJvT3SXCo+HH/UU7apY4UwDuvLkc?= =?us-ascii?Q?0EkASdBgVbGPYCmXRsX7G8r+GJV847l5JUKUhaEpp9uoBE2EGtkBw8AhgF9T?= =?us-ascii?Q?E1mCXLI+H4GJX3iyV9B6xFDArmicTGtslS2v3Rt4DTxr1mJdOesvn/hugo6u?= =?us-ascii?Q?dMqEG9h95ODI0uzUqARyl+c7yJVEMvq2CZg19AAwEff2b10pi6M9H7gXIt4P?= =?us-ascii?Q?uK0ITVx3q9aoOuMUkLditl/aNbXsZDTvwfnO/FbICCA+KAMbv1klA8jFJnLI?= =?us-ascii?Q?1jIBoLXzLCVRVj/fVGllA4w+ZxiqrPwzMXBZW6PeMxtyAMMhRk6eTtzePpOJ?= =?us-ascii?Q?cKStVfffwzIMe9gGj6M9xLcajjZc99tWho/7tfv8xaMrv/heqaPILta/m+K5?= =?us-ascii?Q?LJVLburUiLehSmTb2oXOLm2fuE6UJWFEmoEfdnWqSIFiL4Adrz7D4063CZ+5?= =?us-ascii?Q?20iKKjbXVQuECMvO9gGY42O1OHmfMDvSXtClAKxlyIAX9XPrzLuk4B6y+8vw?= =?us-ascii?Q?GB0nSlWeXnnQVML+I5Ad/gbs9L1XOFbEyYi5+/osQ+itBhi2bfpygVfOx9Kh?= =?us-ascii?Q?A2pyWGIFiv/NCm1g9V9G4Tv40onY7MwJBuEYg5i851fIqgla2PI5sq9/ex8d?= =?us-ascii?Q?iuuhIoVu+7XdSK6CyK13g86iPabvs7QAUKNNOkvk+Pb+KgYDFNaV5udbgLre?= =?us-ascii?Q?u6VQmly2jlOcyrv0UFTzbpSlOMqwUF2R969pRdqmKjoITjS/wv67uzprhC50?= =?us-ascii?Q?eHAz9gpU9q5t5Lqk/WFvUEaJe2jPJpfXtvWtv7l++mJQdzpjghLUI9ErPJR5?= =?us-ascii?Q?PnT0ZzNt2UqO0fegVFDLtJLkwvYpj8kzTc0iZ8Qb9vuG5f6dSRA8xZN4e1K0?= =?us-ascii?Q?JWgNzdQNHK4uor2euYu/4x7f44NDBsSojPC1GtYOtpIfL1gGyyflaRppOcML?= =?us-ascii?Q?0uZx15LEgiSvExT1nUGJ5zC5ZQk8VZCNf4lW+OB+nqxwzeM3Beb8/Engv06W?= =?us-ascii?Q?Gw+/JTwS6A45PaBsKHIk7qJgkLxVuJ8n5O/v2sZY?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ad10175-8ed7-4f10-4665-08dc1e958c6c X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 17:38:03.5883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nXBN5RcpW7VF6CFxn3X2NLLAJfxKKJLX4pYwnGTdjO6jg/FGdGZtupTi1LuN1yTUVLP814VlB14xmiyLbMYzEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4347 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dup4WwVUs9wpWQhptndet0ucx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CL3qHXyv; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io +Min Adding Min to see if TDX is also experiencing issues around this recent=20 change. Thanks, Tom On 1/26/24 11:21, Tom Lendacky wrote: > On 1/22/24 00:47, Sheng Wei via groups.io wrote: >> PciIoMap () need to feedback the status of >> mIoMmuProtocol->SetAttribute () return value. >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4652 >=20 > I'm still investigating, but this commit breaks booting all types of SEV= =20 > guests. Without this patch, there is a boot device mapping and the Grub= =20 > menu is displayed. But with this patch, I receive: >=20 > map: No mapping found. > Press ESC in 1 seconds to skip startup.nsh or any other key to continue. >=20 > and then drop to the shell prompt. >=20 > Thanks, > Tom >=20 >> >> Cc: Ray Ni >> Cc: Huang Jenny >> Cc: Chiang Chris >> Signed-off-by: Sheng Wei >> --- >> =C2=A0 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 ++++++------ >> =C2=A0 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c=20 >> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c >> index 14bed54729..e85544d08d 100644 >> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c >> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c >> @@ -1024,12 +1024,12 @@ PciIoMap ( >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 retur= n EFI_INVALID_PARAMETER; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mIoMmuProtocol->SetAttribute ( >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mIoMm= uProtocol, >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PciIo= Device->Handle, >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *Mapp= ing, >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 IoMmu= Attribute >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ); >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Status =3D mIoMmuProtocol->SetAttribute = ( >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mIoMmuProtocol, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PciIoDevice->Handle, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *Mapping, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 IoMmuAttribute >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0 } -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114622): https://edk2.groups.io/g/devel/message/114622 Mute This Topic: https://groups.io/mt/103881889/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-