From: "David Woodhouse" <dwmw2@infradead.org>
To: "Laszlo Ersek" <lersek@redhat.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Ruiyu Ni" <ruiyu.ni@intel.com>,
"Jordan Justen" <jordan.l.justen@intel.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Subject: Re: [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM
Date: Wed, 19 Jun 2019 22:19:06 -0000 [thread overview]
Message-ID: <b18378418bdb73205b3c404447d71a44.squirrel@twosheds.infradead.org> (raw)
In-Reply-To: <01a87fee-5a17-d027-39fd-2a2e0a36787b@redhat.com>
> the driver is thoroughly commented. See especially the
> DriverInitialize() function. Can you determine which one(s) of those
> statements doesn't / don't hold any longer?
>
> Or maybe IncompatiblePciDeviceSupportDxe works as before, but commit
> 065ae7d717f9 ("MdeModulePkg/PciBusDxe: make OPROM BAR degradation
> configurable", 2016-09-26) made a difference? (Adding Ard.)
>
> I'm just guessing of course; a bisection could prove more effective.
I think I worked it out. The problem is that the nvme controller doesn't
have a ROM so it wasn't triggering the downgrade to 32-bit in the first
place.
By hacking IncompatiblePciDeviceSupportDxe to always return configuration
with 32+bit "granularity" I can boot. That does it for *all* devices, of
course... but I don't get the PCI class; only device/vendor IDs.
--
dwmw2
next prev parent reply other threads:[~2019-06-19 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1463609573-16626-1-git-send-email-lersek@redhat.com>
2019-06-19 12:50 ` [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM David Woodhouse
2019-06-19 22:10 ` Laszlo Ersek
2019-06-19 22:19 ` David Woodhouse [this message]
2019-06-20 12:57 ` Laszlo Ersek
2019-06-20 13:58 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b18378418bdb73205b3c404447d71a44.squirrel@twosheds.infradead.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox