From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@infradead.org header.s=twosheds.20170209 header.b=dwPilaTm; spf=none, err=permanent DNS error (domain: twosheds.srs.infradead.org, ip: 90.155.92.209, mailfrom: batv+c25c0a80c81e6cf45d6f+5778+infradead.org+dwmw2@twosheds.srs.infradead.org) Received: from twosheds.infradead.org (twosheds.infradead.org [90.155.92.209]) by groups.io with SMTP; Wed, 19 Jun 2019 15:19:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=twosheds.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To: Message-ID:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ec319rd3fZcXIxsu2otUhGhTLtIOlQmwWuoxSUps3TE=; b=dwPilaTm++BmBLGId2FumMULt 24VusX5Y++jG1egFwy8FNC8eJEPwjd/zSnsyc3eWxVez9AOblzeLHv9qxzUwRYYY7Iepk5NCxFttM zUTJpm+koTUACVahwT4/cg9MLLYQtRONXE6dsx5HzzQinDAAWyfqMFMrF8qI2D3grqGxsE5lxMk2I MWdqjYS7PaylfpUGlw3crLb3cyYwPFiiykIm5mrXcyss4ErQMfrfkng93vEtVsrPX/jaz/bRbmAbA hElRsEctlN+7/GcSqUhvEyNiS5Cy1SWfpqhOUx7sIBP6dLofNpl00E+EEOqU7R3ATDpr10I+KjO/M UkKADgYqg==; Received: from localhost ([127.0.0.1] helo=twosheds.infradead.org) by twosheds.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdiv4-005jIF-Fn; Wed, 19 Jun 2019 22:19:06 +0000 Received: from 2001:8b0:10b:1:e9ff:fc44:67ab:fc98 (SquirrelMail authenticated user dwmw2) by twosheds.infradead.org with HTTP; Wed, 19 Jun 2019 22:19:06 -0000 Message-ID: In-Reply-To: <01a87fee-5a17-d027-39fd-2a2e0a36787b@redhat.com> References: <1463609573-16626-1-git-send-email-lersek@redhat.com> <9c690717587ff1ccd9a8ec8bd3d741e6c86f8bb3.camel@infradead.org> <01a87fee-5a17-d027-39fd-2a2e0a36787b@redhat.com> Date: Wed, 19 Jun 2019 22:19:06 -0000 Subject: Re: [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM From: "David Woodhouse" To: "Laszlo Ersek" Cc: "David Woodhouse" , "devel@edk2.groups.io" , "Ruiyu Ni" , "Jordan Justen" , "Ard Biesheuvel" User-Agent: SquirrelMail/1.4.23 [SVN]-1.fc30.20180816 MIME-Version: 1.0 X-Priority: 3 (Normal) Importance: Normal X-SRS-Rewrite: SMTP reverse-path rewritten from by twosheds.infradead.org. See http://www.infradead.org/rpr.html Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit > the driver is thoroughly commented. See especially the > DriverInitialize() function. Can you determine which one(s) of those > statements doesn't / don't hold any longer? > > Or maybe IncompatiblePciDeviceSupportDxe works as before, but commit > 065ae7d717f9 ("MdeModulePkg/PciBusDxe: make OPROM BAR degradation > configurable", 2016-09-26) made a difference? (Adding Ard.) > > I'm just guessing of course; a bisection could prove more effective. I think I worked it out. The problem is that the nvme controller doesn't have a ROM so it wasn't triggering the downgrade to 32-bit in the first place. By hacking IncompatiblePciDeviceSupportDxe to always return configuration with 32+bit "granularity" I can boot. That does it for *all* devices, of course... but I don't get the PCI class; only device/vendor IDs. -- dwmw2