From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8B60B1A1E73 for ; Thu, 1 Sep 2016 10:46:56 -0700 (PDT) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BEBE761E76; Thu, 1 Sep 2016 17:46:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-28.phx2.redhat.com [10.3.116.28]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u81Hkrvl004503; Thu, 1 Sep 2016 13:46:54 -0400 To: "Fan, Jeff" , "Zeng, Star" , "edk2-devel@ml01.01.org" References: <1470128388-17960-1-git-send-email-jeff.fan@intel.com> <1470128388-17960-49-git-send-email-jeff.fan@intel.com> <4f61b2b4-eeb4-8435-412f-20848347c88e@redhat.com> <542CF652F8836A4AB8DBFAAD40ED192A143D9CFD@shsmsx102.ccr.corp.intel.com> <795dd4fe-cd16-c0f1-7f04-f78601e2c7a8@redhat.com> <82c6b5c9-dcab-f3c1-5ffe-20fb27ddb1af@intel.com> <6cd44902-8c07-8f76-1204-d79c85559ae5@intel.com> <7d39ce29-88ce-c5f2-af61-7fd964acb5c0@intel.com> <801f810c-4cd7-d657-f536-a8471a37802c@redhat.com> <8c9e77d3-14d2-4a92-2407-eb80cd255bb4@intel.com> <542CF652F8836A4AB8DBFAAD40ED192A143DEF4E@shsmsx102.ccr.corp.intel.com> <8373cabb-8bf5-bb9e-2377-e7b045b54c59@redhat.com> <542CF652F8836A4AB8DBFAAD40ED192A4A1D8F62@shsmsx102.ccr.corp.intel.com> Cc: "Kinney, Michael D" , "Justen, Jordan L" , "Tian, Feng" From: Laszlo Ersek Message-ID: Date: Thu, 1 Sep 2016 19:46:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <542CF652F8836A4AB8DBFAAD40ED192A4A1D8F62@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 01 Sep 2016 17:46:56 +0000 (UTC) Subject: Re: [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 17:46:56 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/01/16 03:11, Fan, Jeff wrote: > Laszlo, > > UefiCpuPkg/PiSmmCpuDxeSmm driver and > UefiCpuPkg/Library/SmmCpuFeatuersLib have no such requirement on > gEfiVariableArchProtocolGuid to access HII type PCD. In fact, our > platform SmmCpuFeaturesLib instance (linked by PiSmmCpuDxeSmm) is > trying to read HII type PCD. > > The correct solution is to add gEfiVariableArchProtocolGuid > dependency in platform SmmCpuFeaturesLib instance and this dependency > will be inherited by PiSmmCpuDxeSmm driver. OVMF also has its own SmmCpuFeaturesLib instance, under "OvmfPkg/Library/SmmCpuFeaturesLib". That library instance has no particular depex, similarly to UefiCpuPkg's instance. If you add the depex to your platform's SmmCpuFeaturesLib instance, that should keep both UefiCpuPkg's and OvmfPkg's instance unchanged. That sounds great to me, thank you! Laszlo