From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 03738210D97B8 for ; Mon, 6 Aug 2018 12:11:09 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E769C40216E3; Mon, 6 Aug 2018 19:11:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-82.rdu2.redhat.com [10.10.121.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B1141C5A3; Mon, 6 Aug 2018 19:11:08 +0000 (UTC) To: Jordan Justen , edk2-devel-01 Cc: Brijesh Singh References: <20180803003045.31740-1-lersek@redhat.com> <153327854869.17436.13213153845980323214@jljusten-skl> <153357998401.20541.14387171373485362984@jljusten-skl> From: Laszlo Ersek Message-ID: Date: Mon, 6 Aug 2018 21:11:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <153357998401.20541.14387171373485362984@jljusten-skl> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 06 Aug 2018 19:11:08 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 06 Aug 2018 19:11:08 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] OvmfPkg/PlatformDebugLibIoPort: fix port detection for use in the DXE Core X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 19:11:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/06/18 20:26, Jordan Justen wrote: > On 2018-08-03 08:08:13, Laszlo Ersek wrote: >> >> Should I resubmit the patch for function-scoping (and renaming) the >> global variables, or for inserting the blank linke? > > No need to resubmit. Furthermore, you can consider my suggestions as > optional. I don't feel too strongly about these ones. I've traded the blank line which I superfluously added above "mDebugIoPortChecked", initially, for the one you pointed out as missing: > diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > index 74aef2e37b42..e24cc834c2a3 100644 > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > @@ -16,11 +16,11 @@ > #include > #include "DebugLibDetect.h" > > - > // > // Set to TRUE if the debug I/O port has been checked > // > STATIC BOOLEAN mDebugIoPortChecked = FALSE; > + > // > // Set to TRUE if the debug I/O port is enabled > // I noted this on the commit message too. Pushed as commit 91a5b1365075. Thank you both! Laszlo