From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 32CF89418DA for ; Mon, 11 Dec 2023 13:50:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oA0haJSmuanO3+K1mg8zV+9Dg89AnsElLxpT/K5Vdwc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702302605; v=1; b=mfFJrsKjANRDszTLb00dW6PZFs+haswsSZkoIRrOdCRn/u3In6d/Uaf/UGiS8fCCWrxlINyR Bg8aG/a6LNpU5f+qpLZCpsIQRWgiPghbz+Bsc4hdxCMYmCSGroAPujHffXpP5WJT7fYyaxaRi2K qSqGaKA4aZ2VfS0OMtfbVBcE= X-Received: by 127.0.0.2 with SMTP id zIRjYY7687511x7QPAEtEn0o; Mon, 11 Dec 2023 05:50:05 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.8629.1702302604997802312 for ; Mon, 11 Dec 2023 05:50:05 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-_lmUX7_mPyCLNiuM-MA6xw-1; Mon, 11 Dec 2023 08:50:00 -0500 X-MC-Unique: _lmUX7_mPyCLNiuM-MA6xw-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 79D6084A297; Mon, 11 Dec 2023 13:50:00 +0000 (UTC) X-Received: from [10.39.194.43] (unknown [10.39.194.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 277BF1C060AF; Mon, 11 Dec 2023 13:49:59 +0000 (UTC) Message-ID: Date: Mon, 11 Dec 2023 14:49:57 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg. To: "Tan, Dun" , "devel@edk2.groups.io" Cc: "Ni, Ray" , Ard Biesheuvel , Michael Kinney , Gerd Hoffmann References: <179ED2A497A4E732.16398@groups.io> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QwayabPbKpAdx5fHJUeIBkSyx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mfFJrsKj; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Dun, On 12/11/23 04:16, Tan, Dun wrote: > Hi Laszlo, >=20 > Previously I sent a patch set " Move gMpInformationHobGuid from Standalon= eMmPkg to UefiCpuPkg. " and thanks for your review. To solve the issue that= the maximum length of one HOB might not be enough when CPU count is 1-2000= or bigger and extend the HOB, we decide to create a new MpInfo2Hob in Uefi= CpuPkg in this patch set. Do you have any comments about the patch set? >=20 > Thanks,=20 > Dun A few days ago I made an effort to at least identify the newest patch sets I should "sometime" review on edk2, including those that apparently superseded older versions. Thus, although not with 100% certainty, I did deduce the above "change of plan", i.e., that the movement of the existent info HOB between packages would be superseded by a brand new HOB. However, all I could do at the time was simply tagging the new version for review -- and that's where I stand now. For reference, I have approx. 14+ patch sets tagged for review on edk2-devel -- these have accumulated due to my 2 weeks long sick leave. I'm back to work for 4 days this week, but then I'll disappear again until the end of the year. So, I think I had best declare "email bankruptcy". Apologies for blocking you -- I had made some efforts to inform my co-maintainers of my status meanwhile. So, please don't wait for my feedback at this time; I might catch up, if I'm lucky, but I probably won't be able to. So if Ray is pleased with your patches, please go ahead and merge them. I might make comments on smaller patches this week; rest assured that that kind of "preference" is just practicality, not laziness. It feels hopeless for me to make a serious "dent" in reviewing any larger patch set this week, so I'll try to spend review effort where it has a fleeting chance at enabling actual progress. Best regards, Laszlo >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, December 8, 2023 5:55 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformat= ionHobGuid2 in UefiCpuPkg. >=20 > In the V3 patch set, > In patch "UefiCpuPkg: Build MpInfo2HOB in CpuMpPei", the DEBUG message fo= rmat is modified In patch "UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe", = remove unneccesary assert check. > In patch "UefiCpuPkg: Avoid assuming only one smmbasehob", free allocated= buffer when error returning case happen. >=20 > Dun Tan (6): > UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg > UefiCpuPkg: Build MpInfo2HOB in CpuMpPei > UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe > UefiCpuPkg: Add a new field in MpInfo2 HOB > UefiCpuPkg: Cache core type in MpInfo2 HOB > UefiCpuPkg: Avoid assuming only one smmbasehob >=20 > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 146 +++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++++ > UefiCpuPkg/CpuMpPei/CpuMpPei.h | 6 +++++- > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++- > UefiCpuPkg/Include/Guid/MpInformation2.h | 58 +++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 354 +++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++---------------------------= --------------------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 8 ++++---- > UefiCpuPkg/UefiCpuPkg.dec | 3 +++ > 8 files changed, 513 insertions(+), 67 deletions(-) create mode 100644 = UefiCpuPkg/Include/Guid/MpInformation2.h >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112298): https://edk2.groups.io/g/devel/message/112298 Mute This Topic: https://groups.io/mt/103052268/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-