From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.53]) by mx.groups.io with SMTP id smtpd.web12.7486.1657120527718614040 for ; Wed, 06 Jul 2022 08:15:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=jwVANqwz; spf=pass (domain: arm.com, ip: 40.107.14.53, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nF+kn8cuZtO93PRlxEy0i9TkYIB3PTs3aLvKSanBBplQR/93tklPGVq4adGFzZjTPlq819yZfjrq2Hf8TwEei9g0Y5I6IEiXCRZ7E6cUKxz4stImzXnu6w8lIIOyg6oz8VEVZOBSRCXLgHsDbYEEnPTiorSyHQgYSSSEuArEVU7Hcy12Q0P5e/lmNc7golg44y3GXOeLGb5rN8hE0O9OWn42THdUMHQOYsm8NNPffIrnUI22D76Sx3qIANrZ9GeqJTGDB9R+9W4UGVqYPTOgOVnxxZq5Nnp7zp8X3qeJG+F5TU7Gxye6U16XwjCVfR5Isyx0QEn02XIsrCxzD+BUVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1pKi3v/TgIHfG719xLe6+nL3S7GE5kB6OzWIXzl4xE=; b=jcutI4jUkzpRW800amsUPb1ZK6lBZ63D9biYlpwoA+0on2g8p1s5c6eEQzHVJ9RkQXTG86Pg9CaC0InRRAfkh/SYFIBQZii3PoPdgpe7ubOH3DCnEkOZbKUPuhtTytlEBkTWi2TAuAK7bmyPppQ3zYEXeC1UNl9SP8IFMccshHCq/zNn1sAJQWVGzKJgGh/u119F6GMLw7ZF/fVl+bo+d1f6vxwt9KXcjMH+P295gNTlranklJGGYDACRv4z6pmeQlwq2lziaxYNBRKix5eXLhq5lQnAtuhHYJwd+9DXFSpZvRxp50bqjRpqFQn4+AVbQ+i+jGjd9pDda3G6jXk1GA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1pKi3v/TgIHfG719xLe6+nL3S7GE5kB6OzWIXzl4xE=; b=jwVANqwz9XaSwY1y4BDrc+v7Cg+u5yxqnqeJPLhh/UwFbwj+YfFkANpF95j95ucEpMLqdhqOkGEAiaMaZTx+xep637nWlHmkYpD12uKg4eBjv+EFtfssQfmsUo9rZ2G8TfP605d3BIit5WVhmfDjDE5zkCg+fsYXI3pJWl71dA8= Received: from DB8PR06CA0065.eurprd06.prod.outlook.com (2603:10a6:10:120::39) by DU2PR08MB7344.eurprd08.prod.outlook.com (2603:10a6:10:2f3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 15:15:24 +0000 Received: from DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::e3) by DB8PR06CA0065.outlook.office365.com (2603:10a6:10:120::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Wed, 6 Jul 2022 15:15:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT029.mail.protection.outlook.com (100.127.142.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 15:15:24 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Wed, 06 Jul 2022 15:15:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4705d4c0d105699b X-CR-MTA-TID: 64aa7808 Received: from 32da031c699a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BE6FAD5E-6E7F-44DB-8F60-6E15DCE549CF.1; Wed, 06 Jul 2022 15:15:18 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32da031c699a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 15:15:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SWhvPpQBP5/HGDeINHLYSX9IVUmIEbPSsphGLPuSGcEJaAc4+9QGpicMqL7Ygb+QviEZlQ9pvbifkzc7N6asD9glROhfKs/v+p6BSNjjefk2OGQdyROMz0oqzik3ot/AygAttSPVCLjuI0qY8MSoynentcmNA3CiOPH7Js658r41V3PRBNd2+ipV5U/GwIj2/+VcVm6snlv6fzywAVwJVwctIbJR+s2M/TTWCAuSrO89e/cfcPFodl2rBB+wb62XNR/WcDGXlM9pF2CWVs3gZlMWT9Eb6zBwuoHderJ9e8K0H7A1lxtwo/hAK9QmMlQ9uEmGoY/yxccEYfa5zA3lwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1pKi3v/TgIHfG719xLe6+nL3S7GE5kB6OzWIXzl4xE=; b=KNxV19QrcGbwbQJ4/OYegQZxQrYVI0ZqQIM13SEAmy6yXRdJGRBmYNipL+OlqZxGdjan4sD6UTAGQcx2Ddqr+3VAWAH329SoPg6lLYcra9ZWgI8jdt4p/0kZ9wMHTI9XGjmozMpTmWWLEYrCl80JOYr1Eq6C8hQcrTld7XeFizpe7scM3JUYQKyn5N+dkg2bzpkyfwmtPgtjq/XOkxr91LIjpIAZohlR0cCsZXhdOThivsoJDxQnIErluBrcZkjva5rN1nudCD3p64mugp/1SAsSWll5AXiPcN6Dw/pwlcabnYKCuEnF4O2ivjxyVu1IgU6t6wZKbNrz9Y5uiM8fAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1pKi3v/TgIHfG719xLe6+nL3S7GE5kB6OzWIXzl4xE=; b=jwVANqwz9XaSwY1y4BDrc+v7Cg+u5yxqnqeJPLhh/UwFbwj+YfFkANpF95j95ucEpMLqdhqOkGEAiaMaZTx+xep637nWlHmkYpD12uKg4eBjv+EFtfssQfmsUo9rZ2G8TfP605d3BIit5WVhmfDjDE5zkCg+fsYXI3pJWl71dA8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM0PR08MB3681.eurprd08.prod.outlook.com (2603:10a6:208:fd::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 15:15:16 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 15:15:16 +0000 Message-ID: Date: Wed, 6 Jul 2022 16:15:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH edk2-platforms v2 03/11] Platform/ARM: SGI: Update for IORT revision macro renaming To: Thomas Abraham , devel@edk2.groups.io CC: ardb+tianocore@kernel.org, pierre.gondois@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220706103952.36268-1-sami.mujawar@arm.com> <20220706103952.36268-4-sami.mujawar@arm.com> <534e7163-f063-2ba4-f155-8bf69c5c1068@arm.com> From: "Sami Mujawar" In-Reply-To: <534e7163-f063-2ba4-f155-8bf69c5c1068@arm.com> X-ClientProxiedBy: LO2P265CA0456.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::36) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 815fa0fd-8ead-4559-bba6-08da5f6259f6 X-MS-TrafficTypeDiagnostic: AM0PR08MB3681:EE_|DBAEUR03FT029:EE_|DU2PR08MB7344:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ajP1JD+7dVGtyP+BkdoplbyXdAYzHvDxKAGVHRKBhUnOY/aYq3SY4CoiYS6S/deo9BIzd/sfggF8A8BNwTrpkG7ynyz/WF4BidNgweJNBscmebW1WVSEKsNuQT79jnFDYgCIBeP0tmLpx+pxumMH6oBua0UBxQN+hK4UK3qXmDYnVNPMzQGOFy9v+5BBURRF/ioyi+V9C5RRKOuuR8NXtiuxDhqO00AG9bZ2FC6Sn8qmMEGWV86RtneFAEzS1eMtoeB0oBihA7HzTstMDVfMMPdlKmWwMKX1uEV2pG90Y/5QBcttaTYVkF724cXG0YaEpqS9ECMeRYpAIrzNXnIWYKkfNlBuDTXciX2C5Mk+L37A00Ua0+CPn+Ax9BAKHlJeJv5doPACukHFXS5bMPvcIGapZzE/60lDj4R1Rd9mBMprjRbA71wMg/pZ9U0P7JrcTGufJXZhfegEHn6QRDdnuFu7E2opFPgMpWGERoGdQ2ooLOfcx+T6G8SfEuN/ROtqxacyVoBm762Z8u0Y2ptTZwVvDwVUngbarrQuZMPT16OQYxqw+FB7WwGqEBi/AptiVuCOhrU9D2NMRUJYR3hQnR2dTEdphNZ23G6fd6APh0jnvaLW20BIyQXwKyCJYXW9LMj/6/YVUs1Xjla+iknbtcftlPXrZLyBEheRrkh5s1oR3j+gHQYl4AyspJO4Wpnz+ph0DbelUQtoUhTHxwebAIdZ0qEb3nN2Qu1kHCbVhDjnBNU1yLi+N+CK2To9qiN7eL2TxpBp815QKWYEA5QGHZqnPWkVUwB3xR1G086jyDBWUeXAcO+I/l7MoJtldi1qAqubq8SrTqYmsZ1hP5YURG423EMl+pmbX3l27IyI6+8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(376002)(366004)(346002)(4326008)(66476007)(6506007)(316002)(66556008)(66946007)(41300700001)(8676002)(6486002)(478600001)(8936002)(15650500001)(2906002)(5660300002)(44832011)(31686004)(38100700002)(86362001)(36756003)(31696002)(186003)(2616005)(83380400001)(6512007)(26005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3681 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a0d64fb9-a1bf-4457-4fef-08da5f6254b4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S4O39J9p7LvXbHdTB8YvmzLDC9qVjUVBB3jxhzp+mzgatEKU/8gQcHzq4ChfUsY2UiptB11Q/mZYUvyP2AZtF5rnlTgnJntKTeaxas+Ty6ZnvSsZXpGcOfNzc6r/kxzinTbcAao/h9EwkXjpaEQuLSa5uYa57ZEuANCmaOp7wXcH8XMzGBQ6rY+j/ZI4ch7H99jBkL0RtCNJFgFHaopOCTcDvFOQObv4et1N3Eq/DZ1c2hyhtX5MoPZEbnC9JhSibP4DacNpVRn0XKY21E2hJFwW2WdUZEN+vQ/A0nAuBkT4PTY8YXNPT+21Bx+PG7hylApnBrrhwsW6p2xycAIM3pKtiAe+fJwOgEO2VUQ0TitoMcy66MhDociYEkzMzfnviBOQOHojQQF4k6tixvWxmjtN3Kti4MyVfMkRgvBzOb8/DYKqKYii3SkdwOCVoy4bn21hxMijnTYTfKXJFrm6bMyLn/EOKL8vKXerarLXozsFLEvNSk+TIIcua3iTLu/7IsZ9HTHPYwdzq4CacAYLCQpEHRR6PtFdSmvP8LJkxdCUZ/z3z7nQV29N6WcztPyQq8pPJA/gLJBIDTI5olqCdpgd0e/Mu25vdnG/Zod5qTJg+IHJlrc7hZ1c9DXvHteZguNM0/mPT04xhHIBt334K7QCiLko5awLyGbo5UWyGNbKe88F5NxgHjkRFVHuf37ZLHfNrYKU4NT/YftoNGziR0UyJXZtZtG6wSp6abT6ZTNvg4/fJ5w56+Zn6R8K9woXk05q16XPbX045lE7Bo2lrZAEjDh5a5eYaio09zcTa2KpehT/CXP7WGSpHiFrm7fds/34oT+N/Yi7HujiDiakg0mbtBovYBEn7b137JFD8j8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(376002)(396003)(40470700004)(46966006)(36840700001)(4326008)(356005)(8676002)(70586007)(53546011)(26005)(70206006)(40460700003)(2616005)(81166007)(44832011)(2906002)(6506007)(40480700001)(82740400003)(86362001)(5660300002)(8936002)(31696002)(6486002)(6512007)(15650500001)(36860700001)(82310400005)(478600001)(336012)(31686004)(47076005)(316002)(186003)(41300700001)(83380400001)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 15:15:24.7122 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 815fa0fd-8ead-4559-bba6-08da5f6259f6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7344 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Thomas, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 06/07/2022 03:18 pm, Thomas Abraham wrote: > > > On 06/07/2022 11:39, Sami Mujawar wrote: >> The IORT Specification E.d updates the IORT table revision to 5. To >> reflect this change the IORT header file has been updated to rename >> the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to >> EFI_ACPI_IO_REMAPPING_TABLE_REV0. >> >> Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION >> macro in the IORT table for SGI platforms to >> EFI_ACPI_IO_REMAPPING_TABLE_REV0. >> >> Signed-off-by: Sami Mujawar >> --- >> =C2=A0 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +- >> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc=20 >> b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc >> index=20 >> fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..415403e8e8e5946d3a2319d83b76d6= 182a8a1e74=20 >> 100644 >> --- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc >> +++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc >> @@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort =3D >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ( >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EFI_ACPI_6_2_IO_REMAPPI= NG_TABLE_SIGNATURE, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ARM_EFI_ACPI_6_0_IO_REM= APPING_TABLE, >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EFI_ACPI_IO_REMAPPING_TABLE_REVISI= ON >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EFI_ACPI_IO_REMAPPING_TABLE_REV0 > > nit: Should this have been EFI_ACPI_IO_REMAPPING_TABLE_REVISION_0 to=20 > better align with all the other table revision macros? [SAMI] I checked the edk2 code base and apparenlty the protocol=20 versioning follows the scheme you mention above. As for ACPI tables the=20 revision is derived from the _ACPI_x_y_ prefix in the macro name. e.g.=20 EFI_ACPI_6_4_GENERIC_TIMER_DESCRIPTION_TABLE_REVISION. However, I have no objection to your suggestion with the only change=20 that I would then prefer to make it=20 EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Kindly let me know if this is acceptable and I will respin this patch=20 series along with the edk2 series. [/SAMI] > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ), >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 3,=C2=A0 // NumNodes >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sizeof (EFI_ACPI_6_0_IO_REMAPPING_T= ABLE),=C2=A0 // NodeOffset > > > Reviewed-by: Thomas Abraham > > Thanks.