Re: [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

["Rebecca Cran" <rebecca@nuviainc.com>]

Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>


Thanks, I'm now seeing:

ERROR: On Arm based systems, all cache properties must be provided in 
the cache
type structure. Missing 'Write Policy Valid' flag.


-- 

Rebecca Cran


On 12/14/21 5:37 AM, Chris Jones wrote:
> Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770)
>
> The PPTT parser in AcpiView incorrectly dereferences a pointer to
> FlagName when trying to log an error with the PPTT cache flags, which
> can lead to random crashes and other errors.
>
> Also fix some spacing in the error message to ensure the message is
> printed cleanly.
>
> Signed-off-by: Chris Jones <christopher.jones@arm.com>
> ---
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> index 8d52bb5e4811298ddc45cdaef41150f6ee7819af..53777644580e779adab4e8047ea279e1c0de14a3 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> @@ -40,9 +40,9 @@ LogCacheFlagError (
>     IncrementErrorCount ();
>     Print (
>       L"\nERROR: On Arm based systems, all cache properties must be"
> -    L"provided in the cache type structure."
> -    L"Missing '%s' flag.",
> -    *FlagName
> +    L" provided in the cache type structure."
> +    L" Missing '%s' flag.",
> +    FlagName
>       );
>   }
>