From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mx.groups.io with SMTP id smtpd.web08.26735.1639493872537444557 for ; Tue, 14 Dec 2021 06:57:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=QR3n8KgK; spf=pass (domain: nuviainc.com, ip: 209.85.215.171, mailfrom: rebecca@nuviainc.com) Received: by mail-pg1-f171.google.com with SMTP id q16so17498981pgq.10 for ; Tue, 14 Dec 2021 06:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=PGtWqJ7QhSoj6LJgN335rgr+IvYYWjaqigEy7EHIUJ4=; b=QR3n8KgK5HhAHbvTj4AqqIEQZzB0uilvLWp2whJEq9Y1zej8MiIBjTIebx/fn/vdwI iXz5zcgMpjMGQQ2vxvXqGByiTLp1SyD3P0HjjIQi0rynm+ePgGL4Rbz36QEA6pNX8idG O7r0v0fwXnov83ReRmK4752OGSMVRaPaY1moq6UAh7Fo0IO21I207o0ArDKYPezUTf1d Csl++Qnsc+/tZzrwfBrftkTucrvd3NO2iTImNsC/qO+OqEdiAs35qcdEBbFylLhCLrNt IWOdjiHRjB7O5hfikFLax7JAIx+Ee5lTKdA5P7FMy0U2DwD9tZiQjygSXxgHla3M1BK3 YRrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=PGtWqJ7QhSoj6LJgN335rgr+IvYYWjaqigEy7EHIUJ4=; b=jJ1yDQdx+MMewpRqwNfiiaSQYDLriogxxiN/DgE1MO922kh29I5qfqqjSvSWacvKIw c0ImqFWTqpqzJrGflWd3nBAI8e51qY7hDxfQx+RBxIKfwf7m3O+X9/g+1IIK9X2KgAbP ExHDrR7gBFFhqTN6xT2JVzRR8jnlY6vdJOQHcipyVdqzJiUbu6sI6V0J3R8hAvCQHZMn s7Rub4vg0xOqShtgkNuqn3e/lsMtGBSmgf2l2PSFOsAEBMXAsAqZCoDSarIQigPX33Ck lI+cHqH91tOrf58J5AfubqxPgMoi+GGvykYDQGQQEpOymhyXpnd3zkhkj5x4trwfhpBp QtCA== X-Gm-Message-State: AOAM532+0DVgm1AgDutKZoMQQBg5TLjzLwKTPkFJI+yd7ly2Gvf8ehZJ AVQbR+AbCYUlMiVwddqB12CpiQ== X-Google-Smtp-Source: ABdhPJzpE8OFwF9TLRgCeERsPXRZx+9Fq1fPbMqH8yfZqC3iMe+S0Dp6wAViLt5om6OwUWHHWtVdAg== X-Received: by 2002:a65:5b4b:: with SMTP id y11mr4078672pgr.59.1639493872014; Tue, 14 Dec 2021 06:57:52 -0800 (PST) Return-Path: Received: from ?IPv6:2601:681:4300:69e:9e7b:efff:fe2b:884c? ([2601:681:4300:69e:9e7b:efff:fe2b:884c]) by smtp.gmail.com with ESMTPSA id j22sm114967pfj.130.2021.12.14.06.57.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Dec 2021 06:57:51 -0800 (PST) Subject: Re: [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference To: Chris Jones , devel@edk2.groups.io Cc: ray.ni@intel.com, zhichao.gao@intel.com, Sami.Mujawar@arm.com, nd@arm.com References: <20211214123736.10854-1-christopher.jones@arm.com> From: "Rebecca Cran" Message-ID: Date: Tue, 14 Dec 2021 07:57:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211214123736.10854-1-christopher.jones@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Reviewed-by: Rebecca Cran Thanks, I'm now seeing: ERROR: On Arm based systems, all cache properties must be provided in the cache type structure. Missing 'Write Policy Valid' flag. -- Rebecca Cran On 12/14/21 5:37 AM, Chris Jones wrote: > Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770) > > The PPTT parser in AcpiView incorrectly dereferences a pointer to > FlagName when trying to log an error with the PPTT cache flags, which > can lead to random crashes and other errors. > > Also fix some spacing in the error message to ensure the message is > printed cleanly. > > Signed-off-by: Chris Jones > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > index 8d52bb5e4811298ddc45cdaef41150f6ee7819af..53777644580e779adab4e8047ea279e1c0de14a3 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > @@ -40,9 +40,9 @@ LogCacheFlagError ( > IncrementErrorCount (); > Print ( > L"\nERROR: On Arm based systems, all cache properties must be" > - L"provided in the cache type structure." > - L"Missing '%s' flag.", > - *FlagName > + L" provided in the cache type structure." > + L" Missing '%s' flag.", > + FlagName > ); > } >