From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web09.3754.1578058629939693119
 for <devel@edk2.groups.io>;
 Fri, 03 Jan 2020 05:37:10 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mgo2CoxB;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1578058629;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vXK+OZ4oQbzU3i33xGjaC2fs38HhWmAPFiFoJBxK8Fk=;
	b=Mgo2CoxBbrghbkg1wUuFRj/kGgBtLmWfSdXGF9guTw0djB9C8EAucijc2Lz4ejievSyZaC
	DVE9wRSWedozoMw7fX8IAE3x33aWvarmPUxLVjLiyFmInLI/IMgX9EbeXFbKUkrRZTafFH
	6ITTnJ0gcDgEml60uY+fMV1SUYxRwV8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-287-p2jKDt80OyGfl230knmAvg-1; Fri, 03 Jan 2020 08:37:07 -0500
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A9BF800EB8;
	Fri,  3 Jan 2020 13:37:06 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-245.ams2.redhat.com [10.36.116.245])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 9E64460C18;
	Fri,  3 Jan 2020 13:37:02 +0000 (UTC)
Subject: Re: [PATCH v2 57/78] OvmfPkg/Qemu: Fix various typos
To: Philippe Mathieu-Daude <philmd@redhat.com>, devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>, Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20200103090812.10592-1-philmd@redhat.com>
 <20200103090812.10592-58-philmd@redhat.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <b23b845e-349e-cc19-8fa5-09a989937476@redhat.com>
Date: Fri, 3 Jan 2020 14:37:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200103090812.10592-58-philmd@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-MC-Unique: p2jKDt80OyGfl230knmAvg-1
X-Mimecast-Spam-Score: 0
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 01/03/20 10:07, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
> 
> Fix various typos in comments and documentation.
> 
> When "VbeShim.asm" is modified, we have to re-run "VbeShim.sh"
> to update "VbeShim.h".
> The string modified by this patch is only used when the DEBUG
> macro (at the top of the file) is commented out. Since the
> string is not referenced, NASM eliminates it, resulting in
> the same byte array content in "VbeShim.h".
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Antoine Coeur <coeur@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> v2: Comment VbeShim.h is not modified in description (Laszlo)
> ---

Thanks!

Once the full set is sufficiently reviewed, please ping me, I'm glad to
help with a PR.

Thanks
Laszlo