From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.1704.1668482281986713030 for ; Mon, 14 Nov 2022 19:18:02 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=TBy4dpIy; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id B893A20B717A; Mon, 14 Nov 2022 19:18:00 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B893A20B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1668482281; bh=Q1D49nHK6Tr7BeykR5AxVQ9ieIwmebc6/+j4keYRPWw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TBy4dpIyauQCR6YvnuOpq00h5cOo1Aa0PEBNRWtUXkFyptGdszmtWMOSmh3ofhqaZ Bb/IIN98HVcYPZhZjVGewZcsRkbcGOoMwEjIcT76vOmh0745Q2eKMqKH/pHmvNxevt owdlcV1HgwOQAVK5vj6eOFYvJkxpXXT8Xr6M5OJI= Message-ID: Date: Mon, 14 Nov 2022 22:17:59 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtQQVRDSCBlZGsyLXN0YWJsZTIwMjIxMSB2MiAwLzJdIFVwZGF0ZSBQeXRvb2wgUElQIFZlcnNpb25z?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: 'Sean Brogan' , 'Andrew Fish' , 'Leif Lindholm' , "'Kinney, Michael D'" References: <20221115001841.2018-1-mikuback@linux.microsoft.com> <010701d8f89e$6afaeb60$40f0c220$@byosoft.com.cn> From: "Michael Kubacki" In-Reply-To: <010701d8f89e$6afaeb60$40f0c220$@byosoft.com.cn> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable I would like to elaborate on some of the information in this cover=20 letter to better emphasize why this should be included in the=20 edk2-stable202211 stable tag. These releases of edk2-pytool-library and edk2-pytool-extensions must be=20 paired together. The edk2-pytool-library release already being used by=20 edk2 (0.12.0) requires the edk2-pytool-extensions 0.20.0 release. The updates in this series should be considered "required" as opposed to=20 "recommended" to ensure compatibility in the stable tag release. The reasoning for updating edk2-pytool-library from 0.12.0 to 0.12.1 is=20 straightforward, it fixes the bug described in the cover letter. The issue with not taking in the 0.20.0 edk2-pytool-extensions update is=20 that PR Evaluation, which is used in CI to determine what packages to=20 build, will not build the code in some cases causing build failures to=20 potentially creep through. For example, without this update, a PR with a file only changed outside=20 a package, such as pip-requirements.txt or a file in .pytool, will not=20 trigger a full build to test the change as a file is not modified within=20 an edk2 package. Thanks, Michael On 11/14/2022 10:00 PM, gaoliming via groups.io wrote: > Michael: > I have no comments to merge this patch set for the stable tag. >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: mikuback@linux.microsoft.com >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8815=E6=97= =A5 8:19 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> =E6=8A=84=E9=80=81: Sean Brogan ; Michael Kub= acki >> ; Liming Gao ; >> Andrew Fish ; Leif Lindholm >> =E4=B8=BB=E9=A2=98: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP V= ersions >> >> From: Michael Kubacki >> >> 1. Updates edk2-pytool-library to 0.12.1 >> - Picks up a minor bug fix >> >> 2. Updates edk2-pytool-extensions to 0.20.0 >> - Picks up a major release >> >> The changes in each update are in the respective patch commit >> messages. >> >> CI was run against both of these patches in this pull request: >> https://github.com/tianocore/edk2/pull/3632 >> >> These changes are recommended to be included in the edk2-stable202211 >> tag for the following reasons: >> >> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix >> that simply returns file paths from >> Edk2Path.GetContainingModules() with the original case used by >> the operating system. This allow case sensitive callers to match >> paths returned by the function correctly. >> >> This can impact flows such as PR Eval that use this function to >> determine which modules were impacted by a code change. Without >> this change PR eval may not return consistent/expected results >> across operating systems. >> >> 2. The edk2-pytool-library change requires edk2-pytool-extensions >> 0.20.0. For this reason, edk2-pytool-extensions setup.py was >> updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library >> requirement. The logic of determining a package in pytool-library >> (Edk2Path.GetContainingPackage()) needs a corresponding change in >> the edk2-pytool-extensions 0.20.0 release. >> >> Without this change, flows such as PR Eval will not have updated >> logic for calling the function and return incorrect results. >> >> These changes have been tested against edk2 in pytool integration >> testing, the PR linked above, and against similar code in Mu. >> >> V2 changes: >> >> 1. Add stable tag to patch subject >> 2. Explain why changes should be included in stable tag >> 3. Add Reviewed-by tags to patches from v1 >> >> Cc: Sean Brogan >> Cc: Michael Kubacki >> Cc: Liming Gao >> Cc: Andrew Fish >> Cc: Leif Lindholm >> Signed-off-by: Michael Kubacki >> >> Michael Kubacki (2): >> pip-requirements.txt: Update to edk2-pytool-library 0.12.1 >> pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0 >> >> pip-requirements.txt | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> -- >> 2.28.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 >=20