From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web11.5727.1571237352730022795 for ; Wed, 16 Oct 2019 07:49:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B6FF3090FD4; Wed, 16 Oct 2019 14:49:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-232.ams2.redhat.com [10.36.116.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4BCED1001DD7; Wed, 16 Oct 2019 14:49:06 +0000 (UTC) Subject: Re: [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd' To: Philippe Mathieu-Daude , Leif Lindholm , devel@edk2.groups.io Cc: Bob Feng , Liming Gao References: <20191016140940.18844-1-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 16 Oct 2019 16:49:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191016140940.18844-1-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 16 Oct 2019 14:49:12 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Phil, On 10/16/19 16:09, Philippe Mathieu-Daude wrote: > Hi, > > This series contains trivial fixes to the GetMaintainer.py script, > then adds a new script which allow git-send-email to automatically > fills the email addresses relevant to each patch, using the new > Maintainer.txt format (with the GetMaintainer.py script). > > I sent this series adding: > > [sendemail] > ccCmd = /home/phil/source/edk2/BaseTools/Scripts/GitCcCmd.sh > > To my /home/phil/source/edk2/.git/config > > The sendemail.ccCmd entry is documented here: > https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---cc-cmdltcommandgt I'm neutral on this patch set; I defer to Leif and others for reviewing it. I like to rely on explicit Cc: tags in the commit messages, and those tags only. They give me better per-patch control, they work nicely across rebases, and I like to see them in the git commit history too. Furthermore, if someone else takes over a patch from a pending series, for a rework, they get the Cc's too. If a reviewer expresses permanent uninterest in a patch, I can drop them permanently. That said, I don't mind if others use "sendemail.ccCmd"! Thanks, Laszlo