From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.57]) by mx.groups.io with SMTP id smtpd.web12.19865.1602864639539938413 for ; Fri, 16 Oct 2020 09:10:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=kFTGLGbb; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.243.57, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TAvrDPlPJ0Ko4HUlUp+CjuBcdNv9ioNPCP1IlNR79devxA5OHFDVoZaMlY7fi6oPS8X0x1dxc/zJS+FzXeMMMP1gNH8b+rXUohCmqALqV2oDTEBwKbpHrJ+YuL07s+YVLG7o05rBnmKAW6K2HZ2e/VWeyzlUWQdTVAmjISLq6Q2aDLP5kdPJez1jVJCH3REDooDiwZimO16QLLgkeD+3P7AB4YD68hpZ7jOKfuw0WPSxp47GTKRJ0lizsfVx86m0VEoSiFkxdw4VvQQMnHdi7rffb9EH1L5PwO7XxIq5qeT7217TSVLvN5UxJ5FpUJCkTW9nM2I5LO1/ywGk1wCH/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5GsnKvm+rfQaEf8t7738xvVSDnqJ92knwcjJva2/1ro=; b=UPFtQprUBixeaAnl9vYR7PdVKd5kYcGC9q/TfRIsbnqiyL3C02OujFKOMjZyF4sHsYZH1k6tE1Z4kVhQ2tSFy3RYO0TL3TRShszpN3/E1fYLdcpt90G1tpMR2omW6kUhoepBEpTYx0NvzyuAHfy5tSCaWRKMbV+IM/VGRge57wRldGYyv9JCf75denMiCLgMz2XWCTtAR0oYZfolmmxKWQ+wmE1nqeFus1dbKyXAouP2Qrc3Y31Isyr6pXagS5v7WCt20SNDsnwhnmqbCogOuuMXvdPz4bW39AKLRhpWD7qYrMFQ9Z1hO7/SmHZtlimj2WfBgLrdxIyVRUisrAMrkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5GsnKvm+rfQaEf8t7738xvVSDnqJ92knwcjJva2/1ro=; b=kFTGLGbbuWtJwfcyC74cIrqfDLOrlHFQLksT49VWZn/AbpUOLv6+fKPwWogt1uTcOwfYTDGCQIkHz1nPJBc41dUpzOIC1Z1q8CeIbZQAnf6uolRhsZo4Q7DDPLpYHsTklFjXl1sLuo9REINWbv2vASaiyUq0AKowSOdhHU/YJF0= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB3082.namprd12.prod.outlook.com (2603:10b6:5:11b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.27; Fri, 16 Oct 2020 16:10:38 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::4d88:9239:2419:7348]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::4d88:9239:2419:7348%2]) with mapi id 15.20.3455.030; Fri, 16 Oct 2020 16:10:38 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [PATCH v2 09/11] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Fix erase blocks for SEV-ES Date: Fri, 16 Oct 2020 11:09:15 -0500 Message-ID: X-Mailer: git-send-email 2.28.0 In-Reply-To: References: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR12CA0107.namprd12.prod.outlook.com (2603:10b6:802:21::42) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by SN1PR12CA0107.namprd12.prod.outlook.com (2603:10b6:802:21::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22 via Frontend Transport; Fri, 16 Oct 2020 16:10:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c6129233-bdf7-49dd-a0a2-08d871ee056e X-MS-TrafficTypeDiagnostic: DM6PR12MB3082: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j5rAGZLu0tuuvFAN3l6FiAaTHVoAJPMR+MiXTsDiSeZ7cS6aiJekiYq0P3VcM7FPAQMGjCXgKw8UQ5IkZNl93hUr/7An6BiEX9NzC0fQaaLgojDSfuShZcnsV2swj1PaL0VviRW9w42wWKMDgZQIWS54zTcsJ1U8J6Wh+nc705RA2edjQRuF3YV/iBsU7sikszJfD+HD2+8KMXcRDXiy20w6BRGr1PRsMBYqmwtIJBumlfrtHIVGAQ+dCJTnPbv+s2YsckSB5dIH0TcXEnCMa6iVJEUH4j2/Ql+t1RsUM2d22/SIlm0vwFifr1yhzTX5PuKdHNYWy38F9nvDOgcyjBvem0BPAtplJoAUpHf3OEYW/F5K+jyYw5tcuJZ/6MfQpTjpGdHqb8fmZfvxkgTRbNzZJINX1o3BH4rCJiSKi1UkgPQ4/2heCeJsFUopZ1i9KcTUADMDsoL2wuD8qrj6w8F4KURLctKR5U72xMzTyzA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(8936002)(8676002)(26005)(5660300002)(478600001)(6486002)(6666004)(36756003)(83380400001)(52116002)(6916009)(7696005)(2906002)(86362001)(16526019)(316002)(66556008)(66946007)(966005)(2616005)(956004)(4326008)(34490700002)(186003)(54906003)(66476007)(213903007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: HbYuPMh1mZbqcbERGpE2CUw6eXRR2oJmPP/SBOA4CoaaakOP8nO/OP+LAG16/H13eWlkQfXN80wo5dBQLXVy5ksIZXPguBwYDmqXaWxDr7bWq9psXPgRqjB+oJhDTfu6/qajg6W0ouQuQXqGQBi8UbRGCS8RYebPj8H7jNs80gc2h0x/VPHbuI4Lg5tW8UBzbNgPG8rsi4VYdkSqZm5an5BciB7ITvA+ySxJ1FrKmqrkcjf6WvGhT7o4lajK7dRRpcTIBdFXTvlcgO16NkkppT248j5r+3NBMKft/c1AfZaoXn+0tQQXxnCwiJjNnASySjiPzIZLKsnI/r5nPGlHt1gdeCor9RoNwWWHHlspjBic7x47rR2sKXMqB0t63TvN5O1YiYcYMh+l2OcvFxPE8oJ3qh1n6X3m42yZq4RVI9Cw4Ndy0vtrzZaWyR4ukm49qFI9cBcMPCJCFf0l3SdTS0j1fGAYUuYM3ibkyTbdWjJpQhtb4jLppODlzxtSiW7vzA7ho2SlO6xVQ0/84kmy88Gg48Y02JK4wtaES1S1wV/h8CqQ+KN0MDWYYhke0/LvR13r0Qj9YEZs4cKiJ5kg8Xo0ufJ1Metosz311ZNuY7di9kaeHoROrpXNIdtUKENHw6lwwx5+h8Zf7PeRicaqwQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6129233-bdf7-49dd-a0a2-08d871ee056e X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2020 16:10:38.2605 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HUioX4Xe01VUoYMF8sZCdJcnWBqHAz/OGSH1uaZ71VxakH+kaqJmjVG67FbA9Y1PwiYKp5AUOu0Zo0PqlV9Xdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3082 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3008 The original SEV-ES support missed updating the QemuFlashEraseBlock() function to successfully erase blocks. Update QemuFlashEraseBlock() to call the QemuFlashPtrWrite() to be able to successfully perform the commands under SEV-ES. Fixes: 437eb3f7a8db7681afe0e6064d3a8edb12abb766 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlash.c b/OvmfPkg/Q= emuFlashFvbServicesRuntimeDxe/QemuFlash.c index 0d29bf701aca..d19997032ec9 100644 --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlash.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlash.c @@ -232,8 +232,8 @@ QemuFlashEraseBlock ( } =20 Ptr =3D QemuFlashPtr (Lba, 0); - *Ptr =3D BLOCK_ERASE_CMD; - *Ptr =3D BLOCK_ERASE_CONFIRM_CMD; + QemuFlashPtrWrite (Ptr, BLOCK_ERASE_CMD); + QemuFlashPtrWrite (Ptr, BLOCK_ERASE_CONFIRM_CMD); return EFI_SUCCESS; } =20 --=20 2.28.0