public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
	devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	Zhichao Gao <zhichao.gao@intel.com>,
	Maciej Rabeda <maciej.rabeda@linux.intel.com>,
	Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
	Ray Ni <ray.ni@intel.com>, Liming Gao <liming.gao@intel.com>,
	Nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
Date: Thu, 16 Jul 2020 14:19:47 +0200	[thread overview]
Message-ID: <b288887e-35ea-8707-51e0-d861abf0fafa@redhat.com> (raw)
In-Reply-To: <ec5885cf44a35e4af2206e8bf5d8b9cb@mail.gmail.com>

On 07/15/20 19:09, Vladimir Olovyannikov wrote:
> Hi Laszlo,
> 
> Thank you for supporting this.
> I can add required support.

Thanks!

> But shouldn't we wait until the patch is reviewed and approved first?
> I don't know the proper procedure. Please advise.

If a v4 of your patch becomes necessary, based on the ShellPkg
maintainers' review, then my suggestion would be to send v4 as a patch
series, not as a single patch. The v4 1/3 patch would be the current
patch (with updates as requested by the ShellPkg reviewers). The v4 2/3
patch would extend ArmVirtPkg to include the new dynamic command. The v4
3/3 patch would do the same for OvmfPkg.

If a v4 of your patch turns out to be unnecessary (i.e., in case the
ShellPkg maintainers merge your v3 patch as-is), then sending a separate
2-part series (1/2: ArmVirtPkg, 2/2: OvmfPkg) would be straightforward,
in my opinion.

Thank you for considering my request (and for implementing the feature
in the first place, of course)!

Laszlo


  reply	other threads:[~2020-07-16 12:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 18:31 [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand Vladimir Olovyannikov
2020-07-15 12:55 ` [edk2-devel] " Laszlo Ersek
2020-07-15 12:58   ` Laszlo Ersek
2020-07-15 17:09     ` Vladimir Olovyannikov
2020-07-16 12:19       ` Laszlo Ersek [this message]
2020-07-16 15:26         ` Samer El-Haj-Mahmoud
2020-07-16 17:14           ` Vladimir Olovyannikov
2020-07-16 17:07         ` Vladimir Olovyannikov
2020-07-22 19:37 ` Laszlo Ersek
2020-07-22 19:40   ` Laszlo Ersek
2020-07-23 13:30 ` Laszlo Ersek
2020-07-23 17:20   ` Vladimir Olovyannikov
2020-07-23 14:54 ` Laszlo Ersek
2020-07-23 15:02   ` Laszlo Ersek
2020-07-23 17:18     ` Vladimir Olovyannikov
2020-07-24 15:09       ` Laszlo Ersek
2020-07-24 17:50         ` Vladimir Olovyannikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b288887e-35ea-8707-51e0-d861abf0fafa@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox