From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web10.14082.1594901995092771510
 for <devel@edk2.groups.io>;
 Thu, 16 Jul 2020 05:19:55 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Y3QKTfWb;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1594901994;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gngnquBYVY21k/DfffAAAT++hkFENx/X30iH88J7tmw=;
	b=Y3QKTfWbABRA/cRu9ma+taZ4rD99i2eSuRZgCXhMPmGr5n58vBG5E1OzpPLKpphmsybg2o
	4LexgEwI3WcSX6vDBs+Gh4W4I0a0DPaPy982U9MWR2LWJmlXTzWE3B4tCPbYpLFv1Etgbr
	Dm9+/iUm9NG9YpZLO3zggGdV5oH5dYk=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-473-RkGlImYwN6CnGgQaXlaJCw-1; Thu, 16 Jul 2020 08:19:52 -0400
X-MC-Unique: RkGlImYwN6CnGgQaXlaJCw-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90A001800D42;
	Thu, 16 Jul 2020 12:19:50 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-123.ams2.redhat.com [10.36.112.123])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 7B7907B414;
	Thu, 16 Jul 2020 12:19:48 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
 devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
 Zhichao Gao <zhichao.gao@intel.com>,
 Maciej Rabeda <maciej.rabeda@linux.intel.com>,
 Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
 Ray Ni <ray.ni@intel.com>, Liming Gao <liming.gao@intel.com>, Nd <nd@arm.com>
References: <20200713183137.9825-1-vladimir.olovyannikov@broadcom.com>
 <17bab469-76af-0ffc-b99c-962f4eb20010@redhat.com>
 <fae81c05-4e0f-915a-90aa-15631ecb150d@redhat.com>
 <ec5885cf44a35e4af2206e8bf5d8b9cb@mail.gmail.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <b288887e-35ea-8707-51e0-d861abf0fafa@redhat.com>
Date: Thu, 16 Jul 2020 14:19:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <ec5885cf44a35e4af2206e8bf5d8b9cb@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 07/15/20 19:09, Vladimir Olovyannikov wrote:
> Hi Laszlo,
> 
> Thank you for supporting this.
> I can add required support.

Thanks!

> But shouldn't we wait until the patch is reviewed and approved first?
> I don't know the proper procedure. Please advise.

If a v4 of your patch becomes necessary, based on the ShellPkg
maintainers' review, then my suggestion would be to send v4 as a patch
series, not as a single patch. The v4 1/3 patch would be the current
patch (with updates as requested by the ShellPkg reviewers). The v4 2/3
patch would extend ArmVirtPkg to include the new dynamic command. The v4
3/3 patch would do the same for OvmfPkg.

If a v4 of your patch turns out to be unnecessary (i.e., in case the
ShellPkg maintainers merge your v3 patch as-is), then sending a separate
2-part series (1/2: ArmVirtPkg, 2/2: OvmfPkg) would be straightforward,
in my opinion.

Thank you for considering my request (and for implementing the feature
in the first place, of course)!

Laszlo