From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.85]) by mx.groups.io with SMTP id smtpd.web11.2793.1638909854207957909 for ; Tue, 07 Dec 2021 12:44:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Ao0KRDmM; spf=pass (domain: arm.com, ip: 40.107.8.85, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vo6CTk40yCzlvt7kBD2YeNGS8Nnpo+SNkJWETkM32NY=; b=Ao0KRDmMGymRD4nU53nZohpMQqvh32dCBcwb6EzwoeXl1Trer7tdty5RaNM2p9QhkRx4+7GLGEIiqCI3AIe/Kli7ADrOIYmG3iW8HV75Cxn1JJtlxGEVNDphB5p0RmZKPl9laAm/Qms/1+nDOV+tqmGVhg3r+QfIp0wOReoCtf8= Received: from AS9PR04CA0063.eurprd04.prod.outlook.com (2603:10a6:20b:48b::9) by AM9PR08MB6180.eurprd08.prod.outlook.com (2603:10a6:20b:2d4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14; Tue, 7 Dec 2021 20:44:11 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48b:cafe::e6) by AS9PR04CA0063.outlook.office365.com (2603:10a6:20b:48b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend Transport; Tue, 7 Dec 2021 20:44:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 20:44:10 +0000 Received: ("Tessian outbound c61f076cbd30:v110"); Tue, 07 Dec 2021 20:44:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: de8e9baa956ff9ed X-CR-MTA-TID: 64aa7808 Received: from 9c961d468f0b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9495FFAA-B5FF-406F-AA20-7BD5F6BD7AE6.1; Tue, 07 Dec 2021 20:44:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c961d468f0b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Dec 2021 20:44:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LAvmCUQIaIHZAEAQ6zh8NagcwqYWxEOKVd9Tr4NXIpqHutFS2j/C/jdbO608pNKhiE8GFXDu5e4aQ3n1vTpCYyCSMLGl4XVcrKG7+0CL1P4Y0xezRJtkULetSzakCtjBYFe/2c/XaWhbVoNld0nNol3ZdU5izxfbOSQFHwyCC3SkvdbCRvNOB7TlFwgqnLDBMGrJZMT61jsY69Xe3fV2goNncJDaDBkzlIZ5czrxroFK2Ffz8SUCf8hnsDhLxDRHgn10VQl4p8n3U47DMfqoV/AGm14yBue0CGrWTdOrTCfveXT+wzWw29Af5Bou6QFXJ1PN7bC4AHE5beEOBvSYjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vo6CTk40yCzlvt7kBD2YeNGS8Nnpo+SNkJWETkM32NY=; b=dgo8eUxicQbjfOURynJl3Lu8pkwPa9un5MRwa7T+LCNBpoYrbKOK8zdZDU85WL++giuWJ/AOGYrM+YCZVDC9qe03N3t4lu23QAJu6r+7EXRhIj7nLzeALblaqG9H6doktJObSw+HVI0wqIHIIOzwTKbyBC6zNXqAFmqN/3+bIMJxmcfGUrQGfRsFzmkp3+Mg7E9RN28X2+uXqaMjNgvY+Y1mY+2IvyRaAlyFY16xIMJWQuv9eJQtg77Bpp0Bw1WI0okPh8aBaL58C7SyZdaJEK7EriDD/WP/2WMiXrquDaSveqajN2VHd55b+gzY/49NkbAiDSkK6absvYepBcbLkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vo6CTk40yCzlvt7kBD2YeNGS8Nnpo+SNkJWETkM32NY=; b=Ao0KRDmMGymRD4nU53nZohpMQqvh32dCBcwb6EzwoeXl1Trer7tdty5RaNM2p9QhkRx4+7GLGEIiqCI3AIe/Kli7ADrOIYmG3iW8HV75Cxn1JJtlxGEVNDphB5p0RmZKPl9laAm/Qms/1+nDOV+tqmGVhg3r+QfIp0wOReoCtf8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB1779.eurprd08.prod.outlook.com (2603:10a6:203:2f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Tue, 7 Dec 2021 20:44:01 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Tue, 7 Dec 2021 20:44:01 +0000 Subject: Re: [edk2-platforms][PATCH V1 01/11] Platform/ARM/Morello: Rename PlatformLib.inf file To: Chandni Cherukuri , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , nd References: <20211204123042.32140-1-chandni.cherukuri@arm.com> <20211204123042.32140-2-chandni.cherukuri@arm.com> From: "Sami Mujawar" Message-ID: Date: Tue, 7 Dec 2021 20:44:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211204123042.32140-2-chandni.cherukuri@arm.com> X-ClientProxiedBy: LO2P265CA0258.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::30) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P265CA0258.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend Transport; Tue, 7 Dec 2021 20:44:00 +0000 X-MS-Office365-Filtering-Correlation-Id: 54aa04fb-9007-49c6-4572-08d9b9c2523f X-MS-TrafficTypeDiagnostic: AM5PR0801MB1779:EE_|VE1EUR03FT006:EE_|AM9PR08MB6180:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KNQMbZV5J1sjjJ92MiGxt624V0RjZIhZ9Jwd2zNZrz9RgXUsouNPviRAQR8vqqv7t4MHypGzriNv0xl2o9OuJ6M8aEyn4F7aQYq2gNR0TNZKEQkpHsTpML55IuV3jOcGOE0rrsg3W69fZr8xOoiUdFszeKlgN2e7tfFh2Ygx5Zg/qolTM1XHRCvdl8f/RQUbXNt5fhJh6TdnsBW7j9ElFzpk0RxFnxB/hMfkxpgzgTqfSfWRqwiFXWZLGqgHxhSaXLezwXkombFSoYYZWrjNlJ6VcVrklYbuvQvJEwcyfA9FcCIzyAiQfzQbznvRILOUtV7oBB0IgUVu9mrYl0j5fxSYQkv8l0mnkSxhxOsF/EU/Lo0kWdNMhs3O2r6Mlq4CFNeblAFNMr3NpltShGElXqruQT3UwgRtnisnaWpQ1nEqwtfAWeLhaa8IMd0VCS6CVpBqayf6pnulzx96ANlQzSjPmegHmSm9DmUDC1IrHZSVVMNkm7kMTSH7Kfo0So/sOxP8dYbHG00Z9bZzFQ/5NFNVzYvxgqnNssEnhwgior63FKLdv7+jT6o9G6fng0oevJuTPUbLHGCq8TZ3OtNuEeZ2VBklUuAZi4fVwDMh6bFnAmwLDuvMH9kbcKuc4orsPgKx7Bgu7clagB05BixwjRBhh3K+qvlN0/tXJ46oACaUWpZ8DL0hn3HupIe9ckhjTb+q9sj7NcQdHCdTDu2ONP0WLkjh/jgyArlMtLQs1OOO6QJLSSPWIRbNmnSTqneULeFaZILxlsiPkQooiJD1vA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(54906003)(66556008)(66946007)(66476007)(36756003)(31696002)(38350700002)(508600001)(5660300002)(4326008)(8936002)(31686004)(83380400001)(8676002)(6486002)(44832011)(186003)(86362001)(316002)(16576012)(2906002)(52116002)(53546011)(956004)(2616005)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1779 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 98712d7c-f2c5-4764-00cc-08d9b9c24c5a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yy37UAjucVagik2peQYlv5ySsZKgpzCfujwlk59zTQrGrzQwUzrhaqi69S1Y/ao/M5cw+D76SQEjNx7g5i2R55hlWhH26jCXDI3frjS77Se2RymyS3npqQfN9TPl0BYasFhkfo0ibhSl3uZQUO5ojJ3GsMPC/4mBxERYq/lzXCtxtJLeTXfsm5LkRdV9XF0Ub6a2tEhp/fTfq08TFfpopTB0ckoWeWiBGLAuUggtBLKRGQBZR91wRz3MEZYv9jLaKo02L0ElEVirRRENXqpOzIkgSewfTnpagFghCsyS6sG8zT3FFISPQsfNSki7M+Rtl5LTE8YDfKPxgBxNy2lzn2fhzCe7md2xwIQczJRmrAAYaCrGGmKMmgzA429hcxibDII94RomWVc4HZt+2h3KzTelQ1e4Opymg3yZbma3sYbtg1A7I0ukq0dLtAm1r4/oN2fzeFQR2M9sV8aQNdMqlHRuGEq3PDSdWSdbpRNH7ZPaL0mt3kgXC8XlpoS/rc6BLYk1kIC+nMHKhxnr0/FegqnD5Wz4Oz+jBDkNURG1DhcHjN/0GzRA5X3MTtKAb5BMglIsfiGJ4vyaa9RfseoF2fQTIAhnrU6kPZY8b3RDeAz3nqHUDHIEUIB2e5YTiFc7VZO+ZoWdDccjjWnNNHkwUESsA+YKgPNUnVJq+MTwbVQSrzlLRew4mzpsxIr2t+dHkQur6lmb+RNXNyUNKRLHAjV3BkThBYL033lK+hNJcsg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(31696002)(16576012)(2906002)(8676002)(8936002)(316002)(6486002)(36860700001)(82310400004)(81166007)(356005)(54906003)(4326008)(47076005)(2616005)(956004)(508600001)(186003)(70206006)(44832011)(70586007)(36756003)(336012)(53546011)(31686004)(83380400001)(86362001)(26005)(5660300002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 20:44:10.3215 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54aa04fb-9007-49c6-4572-08d9b9c2523f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6180 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Chandni, Thank you for this patch. I think the following change from "[edk2-platforms][PATCH V1 05/11] Platform/ARM/Morello: Add initial support for Morello SoC" should be part of this patch. diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc index dccd22248318..862d5f2da1b0 100644 --- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc +++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc @@ -9,13 +9,13 @@ [LibraryClasses.common] ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf - ArmPlatformLib|Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf BasePathLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf ++ b/Platform/ARM/Morello/MorelloPlatformFvp.dsc @@ -39,14 +39,18 @@ !include MdePkg/MdeLibs.dsc.inc [LibraryClasses.common] + # Platform Library + ArmPlatformLib|Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf Can you update this accordingly, please? With that changed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 04/12/2021 12:30 PM, Chandni Cherukuri wrote: > PlatformLibMem.c file is going to be different for Morello > FVP and Morello SoC platforms since the virtual memory mapping > is different so the file PlatformLibMem.c is renamed as > PlatformLibMemFvp.c and PlatformLib.inf is renamed as > PlatformLibFvp.inf. > > Signed-off-by: Chandni Cherukuri > --- > Platform/ARM/Morello/Library/PlatformLib/{PlatformLib.inf => PlatformLibFvp.inf} | 4 ++-- > Platform/ARM/Morello/Library/PlatformLib/{PlatformLibMem.c => PlatformLibMemFvp.c} | 0 > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf b/Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf > similarity index 91% > rename from Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf > rename to Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf > index c2d7da3701d2..d4c8744c0954 100644 > --- a/Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf > +++ b/Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf > @@ -1,5 +1,5 @@ > ## @file > -# Platform Library for Morello platform. > +# Platform Library for Morello FVP platform. > # > # Copyright (c) 2021, ARM Limited. All rights reserved.
> # > @@ -24,7 +24,7 @@ > > [Sources.common] > PlatformLib.c > - PlatformLibMem.c > + PlatformLibMemFvp.c > > [Sources.AARCH64] > AArch64/Helper.S | GCC > diff --git a/Platform/ARM/Morello/Library/PlatformLib/PlatformLibMem.c b/Platform/ARM/Morello/Library/PlatformLib/PlatformLibMemFvp.c > similarity index 100% > rename from Platform/ARM/Morello/Library/PlatformLib/PlatformLibMem.c > rename to Platform/ARM/Morello/Library/PlatformLib/PlatformLibMemFvp.c