Re: [edk2-devel] [Patch 1/4] BaseTools/Scripts/PatchCheck: Update Author checks

["Rebecca Cran" <rebecca@bsdio.com>]

For the series:

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>

-- 
Rebecca Cran


On 2/18/2024 1:59 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
>
> * Reject patches that match Author email "devel@edk2.groups.io"
> * Update the current check for " via Groups.Io" to perform a
>    case insensitive match. It appears that groups.io has changed the
>    format of this string to use all lower case.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   BaseTools/Scripts/PatchCheck.py | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index 1675dcbd7321..e600e0be440f 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -85,7 +85,11 @@ class EmailAddressCheck:
>               self.error("The email address cannot contain a space: " +
>                          mo.group(3))
>   
> -        if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'):
> +        if mo.group(3) == 'devel@edk2.groups.io':
> +            self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
> +                       email)
> +
> +        if ' via groups.io' in name.lower() and mo.group(3).endswith('@groups.io'):
>               self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
>                          email)
>   




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116057): https://edk2.groups.io/g/devel/message/116057
Mute This Topic: https://groups.io/mt/104434582/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-