From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.9299.1650638484615047925
 for <devel@edk2.groups.io>;
 Fri, 22 Apr 2022 07:41:25 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 998B51595;
	Fri, 22 Apr 2022 07:41:23 -0700 (PDT)
Received: from [192.168.122.164] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D7753F5A1;
	Fri, 22 Apr 2022 07:41:23 -0700 (PDT)
Message-ID: <b2f86f2e-8230-d9f5-a505-f4e5aa0d86f1@arm.com>
Date: Fri, 22 Apr 2022 09:41:13 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Leif Lindholm <quic_llindhol@quicinc.com>
References: <20220420204420.1132-1-mikuback@linux.microsoft.com>
 <20220420204420.1132-7-mikuback@linux.microsoft.com>
From: "Jeremy Linton" <jeremy.linton@arm.com>
In-Reply-To: <20220420204420.1132-7-mikuback@linux.microsoft.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 4/20/22 15:44, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> 
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 6dc48dc23302..0eed03c097f8 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>   !endif
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index a9c0c36bb12b..eabddd7382cf 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>   !endif
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf

I applied both this and the other required set, built and booted them, 
and the variable store appears to continue behaving as before (both 
with/without my SPI flash patches).

And this looks fairly trivial, I'm not sure why its not just picked up 
as part of one of the other variable store related .inf's but <shrug>

So for this patch:

Tested-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>