From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 12682740062 for ; Wed, 25 Oct 2023 08:00:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ut3rQa6DELZUFXQVboOzqbMDuWLQHoUqfQGCghiuc8c=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698220833; v=1; b=nK1Eirwa5kVErv1XMnDPKxdCpAWvCFcfp0+K/Nf25wvFqpYOMlKGv8S1hAV4xyUPMoMFD20X 51NR2zg0Q2ILTl6woGRWoJHkBd8kfcvo3GOuhOG7Dqk8+pRCoOEmhlWsDJL25IUlGlSlJDaRzzs YNjPTbtpmqoAUPAoSegA6B8o= X-Received: by 127.0.0.2 with SMTP id xl5QYY7687511xr4RM2EM2SS; Wed, 25 Oct 2023 01:00:33 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.38849.1698220833093678503 for ; Wed, 25 Oct 2023 01:00:33 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-nDtcwsrnN9aFK6xaMJ9QpA-1; Wed, 25 Oct 2023 04:00:24 -0400 X-MC-Unique: nDtcwsrnN9aFK6xaMJ9QpA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 52E3E2808FE4; Wed, 25 Oct 2023 08:00:24 +0000 (UTC) X-Received: from [10.39.192.250] (unknown [10.39.192.250]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCA041121319; Wed, 25 Oct 2023 08:00:21 +0000 (UTC) Message-ID: Date: Wed, 25 Oct 2023 10:00:20 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB To: devel@edk2.groups.io, yuanhao.xie@intel.com Cc: Chasel Chiu , Nate DeSimone , Isaac Oram , Liming Gao , Eric Dong References: <20231019032010.154-1-yuanhao.xie@intel.com> From: "Laszlo Ersek" In-Reply-To: <20231019032010.154-1-yuanhao.xie@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AX5mHfNUnlTHPYloZrv8uQNqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nK1Eirwa; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Yuanhao, On 10/19/23 05:20, Yuanhao Xie wrote: > With the fact that CSM is not supported, > the request is to remove the cache setting for memory under 1MB. > This can be treated as the missing part of legacy CSM deprecation. >=20 > This patch only set the 00000 to 9FFFF and C0000 to FFFFF as Write Back. > A0000-BFFFF range is still uncacheable for VGA. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Yuanhao Xie > --- > Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c = | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCac= heMtrrLib.c b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCach= eMtrrLib.c > index 05728275a5..38a8db6b3f 100644 > --- a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrL= ib.c > +++ b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrL= ib.c > @@ -245,7 +245,7 @@ SetCacheMtrrAfterEndOfPei ( > &MtrrSetting, > 0xC0000, > 0x40000, > - CacheWriteProtected > + CacheWriteBack > ); > ASSERT_EFI_ERROR ( Status); > =20 I find that this patch has been pushed as commit 474b81190261. Previously, I commented that the subject line of the patch was incorrect, because it didn't name MinPlatformPkg: https://edk2.groups.io/g/devel/message/109747 What was your reason for ignoring my comment? Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110020): https://edk2.groups.io/g/devel/message/110020 Mute This Topic: https://groups.io/mt/102037244/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-