From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.67]) by mx.groups.io with SMTP id smtpd.web11.2418.1635467128345798359 for ; Thu, 28 Oct 2021 17:25:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=hp2wVjmq; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.93.67, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W+pjAiSt9rA2kaH03LMv39fU8NRdKNL1xYUL7fzYFJCgpJGvn43aPtXW4rk+YD+bVXM1I8nwQoy9PdPL0/FvtoiOhJ8O5T58xTmldmDRBu5CiLO/70DjjldWqB0FUMs0L0tkOVkhDp/WDX+7VaZ+SK4va8aZR4Rmd5sIwbXisiVzk/ELhh9uYHLNlL8iksuDaHXDdPSghSKaJGDAIZz3ZVUBe8AZgL/NFCAMIipIYzsSDY8WrFst7XZOoZt8gWPUBjJVhxgW//iTnYtp6OvAe5814x5Jne2jLmWMxKPIPQE1wPvUGvCywzBwpq/f1eymlLPCHXRQ+QC2FaTrUj00ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xIG44MrPDT+6PLvcPtaqt8n8jkiPWbM+VIK3Xzjj1wI=; b=B6aEHol47C8Ng6PocwNvCH3etfexLm5nvc2v7gHY8PNX7fpoQ4/2EicQckGAPyhXd99+KXHTZJSDDSHIWEFFw6IAKpYcDbrKTk1O6bHKMWA8dh2JzLuG4MQdm1LG0VCSP1pj6Ai31dSyuMieqJ0VfDLJZ/tRJX8rdDfjVqE8ZTvljr4SacYCxAO5K3+rwo64HOdIjot08k0geye2pNdztZTKTqL0820bRPBattVkOJWbUngfrGnK+68afy0n3mRrj2cfgsmdljA6tqYCUw8GvVA/aqZcjH1stkXsqd7ZXqf0pjZamQQD9Grozo876r7IGQ/16QQjddLlSke1W5HVtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xIG44MrPDT+6PLvcPtaqt8n8jkiPWbM+VIK3Xzjj1wI=; b=hp2wVjmq5jtfxO1clxtA2Mo2ZqDs8mTf3l8hlKmFvEZG33Hrxx8ZE1APJmX4eykaQNEhu6ArVLWjU29BYvutZJXSuYBtEqSZICKjRLTfz3DBV1nr/p729fXY95314JItnAa6xLB5BKaajp6IRnlMct/MfW0qgWVc0gDR346AfxI= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4559.namprd12.prod.outlook.com (2603:10b6:806:9e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 00:25:26 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::e4da:b3ea:a3ec:761c]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::e4da:b3ea:a3ec:761c%7]) with mapi id 15.20.4628.020; Fri, 29 Oct 2021 00:25:26 +0000 Message-ID: Date: Thu, 28 Oct 2021 19:25:23 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Cc: brijesh.singh@amd.com, Erdem Aktas , James Bottomley , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception To: "Yao, Jiewen" , "devel@edk2.groups.io" , Tom Lendacky , "kraxel@redhat.com" , "Xu, Min M" , "sami.mujawar@arm.com" References: <24d3a351f21bff1a4b20490313d039e403b1453c.1633401643.git.min.m.xu@intel.com> <20211012102716.wr6bao42f5hviz5z@sirius.home.kraxel.org> <20211026061148.omqerrswnpgs3jin@sirius.home.kraxel.org> <20211026102458.pvzp5nxyegq7ftuu@sirius.home.kraxel.org> <20211027071935.a4l3aiiu6uaaqdvl@sirius.home.kraxel.org> <16B2583BF2C9DB9C.5572@groups.io> From: "Brijesh Singh" In-Reply-To: X-ClientProxiedBy: SN6PR04CA0088.namprd04.prod.outlook.com (2603:10b6:805:f2::29) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from [10.0.0.5] (70.112.153.56) by SN6PR04CA0088.namprd04.prod.outlook.com (2603:10b6:805:f2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Fri, 29 Oct 2021 00:25:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a60dd05d-656a-48bb-af5c-08d99a729a7e X-MS-TrafficTypeDiagnostic: SA0PR12MB4559: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mjM/1tVp5H/HVktIGGBLkNyVa99f8I4RaxTl/W8/8cGcpfJnGa0Be5Vz6ZDVVmy+yDKmiKu1r1pNHpi4TsJDP7mF4v9EVY5fIfPLPtYQM3RL2L6ojHj6kayj+exnIFAMZfHh/OvOpNwjXIOdrdqHkV0OvwINyuSTqsv75MmLFnBgozcUSVfhTKFlv8F2GgCbvutOVU0kUIjI3X7C1X7REA44ougIgU8Tg3R7txWQz70fp+45RulwmSqR0lB5w9ZKwP9gCjfxn5vrYChFUAu1xjAOXHJXH0neW3nR5JEVlqyinJcZYEzYip6gCpGfH7wZJB+YAPBJJr894BW3ZB1+NhejU+B3H8dUoz0Ylu5Nl0xySAktdFWfBFK0x1W5fZRQ4UBcYnbucNy9xOKHoxmyKgYAlSaTD9rTPWLPPA6ZgMBR4YxzcXQmY4ulIs3IupwlwprKxqfeyKogeebSB7hsHdfjMD2WOOWAKidWr3FUEQGJel6RCpivtvftltVqVq1Vyq2+CmTGgZ1un3/gFqc+oqDCNLvxeao+R7oYgTADDVWXR5+vHXtkb4K1fhjXCdg1NSExhZVSqoyejStONde5F5sb8DxQHdTv9ic4bQykcrajNoyivISHJ/NRUgzdF0rgaS5tgFVPb6lv19AUwz7Kk3AMx/5uag78Y9+9d+nXfnaMOjjcmKpXIVYHhzXbyrq1bTPF9Os6hErvE/ipND5pSrmgnEALpUfaYLG7O6xBxsnlwe35/os/MSfxMx1J3vJLdF8+RLG9R7/Zz3WFN9U/6xyGAJYAbsUeQ7AntbMNyrYWrnI6PevJvEwxKqZGrgBIgH0SH5Uq6C5ytGbpu6yCnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(966005)(316002)(45080400002)(7416002)(16576012)(508600001)(53546011)(26005)(44832011)(2616005)(36756003)(186003)(956004)(8676002)(8936002)(5660300002)(31696002)(4326008)(66946007)(83380400001)(86362001)(31686004)(2906002)(66476007)(66556008)(54906003)(6486002)(110136005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3RxU1BySmR5Q1hPNHRlbVhQUmhrbGxpNXJsY0NOSWRJZXovRWVwK05QM005?= =?utf-8?B?MnBTMUdUcjgxaEpRU2wyZ1VBQWx4Q3AyaTZmU2ZzaHhGRzBRby9sbEsxNDZC?= =?utf-8?B?Mlk3TlpFTHhIQVJLcDNvc0ZJZEplYnVwNnF4TnJzTW1FMjlvdi8rNnV6SGNY?= =?utf-8?B?Wkk4UnVFM0hCTHR1cUxxODQ4ODBFdmthdnMwc3gxWWlaaGpWT0dkMVFqdDBo?= =?utf-8?B?Ynd1dm44RE9lZGdhckFkM0hUS1RGM21mWXhSZVBmajdEVm13TWJHeWIzTkha?= =?utf-8?B?TWxSVGdsMmpHZVN4SlpSTisvQnFpekhFdEd1VUxnQ2Z6M0s0M1liallYY2ZN?= =?utf-8?B?MWZ2UFQ1ZWNjVVRhR1hXL09lbGVtOUJWNFUxMW9oZGVkZTZLRlZCcXlGTWR1?= =?utf-8?B?RUJwVUFLUUZMUkcwUjEyVmZpTGpQTnVwOHFvQUwxakJaTENMQ0xNR284TDZ4?= =?utf-8?B?Qlh3dmREcmtqMkxRODBDcU1mNlhsWjZLc3pySUk0YVBpejYyLzdVSng3QnAw?= =?utf-8?B?dUxVeHE3VFViYlJJeXpGY1JkT05IVkNUUGhmR0krUWJzdzdkeDFZbjFXNDlp?= =?utf-8?B?bFA3WUhDK25PS2tzcWRpTGpDcEVrVGVua2xCSWxTOXQ2N3VNUW9wSjRPOTlM?= =?utf-8?B?RSt2UDB5RHl0ZkZjZUxqR2IzV1pFSGNsTW90RjV2SUVqR1c5L0VpVGRYcFlk?= =?utf-8?B?czk2WTNnUStWTTRYaWVWZE9ad0RObld3bHh2RFJkZ08yVEwyVmJ1MTRhcUlH?= =?utf-8?B?TFNObGpSUWs3OW9VR29aTDZDVUNQVWtTNHJ5K1RSTFJNdkU1ZCtXZ3QvT08y?= =?utf-8?B?cCt1NGtnT0t2MTVGUVRYSnQ3OHBucElLakFmM09LZkFudnVHQkdqVm1ZeXdp?= =?utf-8?B?ZkxPWm9nc3BjVElQT2hBQTVUb3UyZVcrb2JXck1uN2kwQzNNbEg3TjZpMm9L?= =?utf-8?B?UzFUdFI4Vk5KYWMraGVVVUJFeTNTVXFmMUhYNU1EcWc1YUlza244b05vZEFG?= =?utf-8?B?UXZkRjZCUWRBbEx0dHRmVnNDeWtoS0YybmdDaGJscVBUSnBSZ3g4d3ZpMmYv?= =?utf-8?B?YmpDeW1vcUs2Y0s5VW1peno3SGFOS1JuWm1JaE9XN2VVU0NEUmt0TUJBTVBh?= =?utf-8?B?NVo3ZEd0RUxkSzVYeS9VOU5PeHlraVM2M2hqdXBRY05vQ0FBLy95cDYyQ1Ju?= =?utf-8?B?MytVd0QvUVNiMUkwWFdUbE9IM2did2Z5TkRrUlZCcThxY0lWaUVmS2R2cmZw?= =?utf-8?B?aVhFNnQ2eVN5UWwyVisrcTVKZXJqNnFkdUE4ck82dlNCMGN6S3hHZW9sNjlF?= =?utf-8?B?ZElndzBGK3FlKzdzYldsd0pyeXAzVGJPSUd5L0Myakp2Q1BmL3h3WFgzSDIy?= =?utf-8?B?aUlhYmRNQ2Y1bEpWU1BwVVBYaTdrRkpxcEpUdmdRQkRiR3l5VWVWcFYvS2gy?= =?utf-8?B?YU1NVjVoNjgzVVhjb0QrUlJ3STRTNDFDYlRmNlRaNmsyUStFT2s4VFlTWjVR?= =?utf-8?B?NW1rMU1YVndTM2VpZFpLTkZLQnlaN2dacjJsdmJmeDNlYWQ5OHFsLzN2MEdT?= =?utf-8?B?NXBkY2NkTVB0amlSM1BJRFM4aG1RN3FkbFp1eG1vNUl4eW5kdlpwYUlIaDNx?= =?utf-8?B?V1ZMNlJLeEt1U3lvQVV0QkJ1NWN0bTdVU2RxUjhzNXJDKzc1aTRSY1gxSk93?= =?utf-8?B?aVJSejdPS3BNSlAwVFZiRExST0NUYk1reW9FeDI3VTNhbGFyZWF6a3gzWmpZ?= =?utf-8?B?UzJtWkJJWHZmUDM5RXNFdmdMQkptL21QaStxRVZqcVZ5WGRrT1R3Z0pseTRE?= =?utf-8?B?VWtITnNERElXMmJJc3JvQVo4OTVXWWh0aWZybGg3a0hNV0R4aTRubDJuNDhR?= =?utf-8?B?SzB2b0ZYN1lyckRydEZqM3V4bEVxRlA0ZjlOZ25GQjk3Y3RrWmRsNmZ4MldW?= =?utf-8?B?bWJucHVhM0dPMEpGWHNJZS9ES0Fsc2xIZWRjNkUwbzh1YXUvaUQyQkJjajlD?= =?utf-8?B?Ym4vVEIweXdRR2RMMU5FdGpSSlVjSFVKNkR2bGUzSFlqMDg2VlJISUZzNks4?= =?utf-8?B?OVNVVEg3b2xYNUw1M0tPdExGeVd4TVltcUFZZUlLemI4K2czRFRjWDR0R3Vk?= =?utf-8?B?czJQSTkyTHFoNktCdmhqdWJWajlCMjF6aDRFRHBSQ1JGa2UwaGR6Qld0aXlP?= =?utf-8?Q?HqMjJ7N5Xf0cbYl7T7HxBOk=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a60dd05d-656a-48bb-af5c-08d99a729a7e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 00:25:26.0247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yOrPhFaB9v+MKIuRzI3A5buYn22op6S+5P0gEByY0hfSXO0KSAxObbuci6r9dUK1tx3Au+6aTx6tQiJQWdzOGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4559 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/28/21 7:20 PM, Yao, Jiewen wrote: > Just to clarify the proposal: We will use EFI_CC_MEASUREMENT_PROTOCOL, CcMemoryEncryptionLib, and CcExceptionLib, right? Ack. > > Thank you > Yao Jiewen > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen >> Sent: Friday, October 29, 2021 8:17 AM >> To: Tom Lendacky ; Brijesh Singh >> ; kraxel@redhat.com; Xu, Min M >> ; sami.mujawar@arm.com >> Cc: devel@edk2.groups.io; Erdem Aktas ; James >> Bottomley ; Dong, Eric ; Ni, Ray >> ; Kumar, Rahul1 >> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: >> Add base support for the #VE exception >> >> I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace >> EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO) >> >> Samy >> What do you think? >> >> >> >>> -----Original Message----- >>> From: Tom Lendacky >>> Sent: Friday, October 29, 2021 2:29 AM >>> To: Yao, Jiewen ; Brijesh Singh >>> ; kraxel@redhat.com; Xu, Min M >>> >>> Cc: devel@edk2.groups.io; Erdem Aktas ; James >>> Bottomley ; Dong, Eric ; Ni, Ray >>> ; Kumar, Rahul1 >>> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: >>> Add base support for the #VE exception >>> >>> On 10/28/21 10:52 AM, Yao, Jiewen wrote: >>>> Thanks Brijesh. >>>> >>>> We can merge SNP patches at first, then decide next step. Not a problem. >>>> >>>> TEE is just my initial thought. And I am open to change if we have a better >>> name. >>>> We already have EFI_TEE_MEASUREMENT_PROTOCOL. I did not see your >>> feedback on that. So I assume you agree with that. >>>> If you have different idea, please feedback to this patch. I hope we have one >>> name. >>>> COCO seems weird to me, btw. :( >>> Like Brijesh, I worry about confusion with the ARM TEE feature. Maybe just >>> CC then? >>> >>> Thanks, >>> Tom >>> >>>> Thank you >>>> Yao Jiewen >>>> >>>>> -----Original Message----- >>>>> From: Brijesh Singh >>>>> Sent: Thursday, October 28, 2021 11:35 PM >>>>> To: Yao, Jiewen ; kraxel@redhat.com; Xu, Min M >>>>> >>>>> Cc: brijesh.singh@amd.com; devel@edk2.groups.io; Erdem Aktas >>>>> ; James Bottomley ; Tom >>>>> Lendacky ; Dong, Eric >> ; >>> Ni, >>>>> Ray ; Kumar, Rahul1 >>>>> Subject: Re: [edk2-devel] [PATCH V2 12/28] >>> UefiCpuPkg/CpuExceptionHandler: >>>>> Add base support for the #VE exception >>>>> >>>>> >>>>> >>>>> On 10/27/21 8:59 PM, Yao, Jiewen wrote: >>>>>> Hi Gerd >>>>>> I tend to agree with you on the direction to use one TEE specific Exception >>> lib. >>>>>> However, I have naming concern. >>>>>> The VMG is very SEV specific term. I don't believe it is a right name to >> cover >>>>> the TEE exception lib. >>>>>> If Brijesh agree to merge, I think we should rename it to a neutral name, >>> such >>>>> as TeeExitLib. >>>>>> What do you think, Brijesh? >>>>> I am good with merging both the TDX and SEV feature into one library but >>>>> I am not sure about the "TEE" name in it. TEE generally is used on the >>>>> ARM. In Linux kernel and everywhere else we have been using the COCO >>>>> (Confidential Computing), so something along that line makes much more >>>>> sense. >>>>> >>>>> We can rename the library after the SNP patches are merged. I would >>>>> prefer to avoid renaming because all of the SNP patches are Ack-ed. >>>>> >>>>> -Brijesh >>>>>> Thank you >>>>>> Yao Jiewen >>>>>> >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: kraxel@redhat.com >>>>>>> Sent: Wednesday, October 27, 2021 3:20 PM >>>>>>> To: Xu, Min M >>>>>>> Cc: Brijesh Singh ; Yao, Jiewen >>>>>>> ; devel@edk2.groups.io; Erdem Aktas >>>>>>> ; James Bottomley ; >>> Tom >>>>>>> Lendacky ; Dong, Eric >>> ; >>>>> Ni, >>>>>>> Ray ; Kumar, Rahul1 >>>>>>> Subject: Re: [edk2-devel] [PATCH V2 12/28] >>>>> UefiCpuPkg/CpuExceptionHandler: >>>>>>> Add base support for the #VE exception >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>>>> How about adding the tdx exception handler to the existing library, so >>> we >>>>>>> don't >>>>>>>>> have the churn of adding a new library everywhere *again*? >>>>>>>> Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in >>>>>>> CpuExceptionHandlerLib, then include the corresponding source file in >>> each >>>>>>> *CpuExceptionHandlerLib.inf? >>>>>>> >>>>>>> No, I mean extend the existing VmgExitLib instead of adding a new >>>>>>> VmTdExitLib, i.e. place the tdx handler in >>>>>>> OvmfPkg/Library/VmgExitLib/TdxExitHandler.c >>>>>>> >>>>>>> take care, >>>>>>> Gerd >> >> >>