From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.2617.1675474005503699717 for ; Fri, 03 Feb 2023 17:26:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=kl3rJuco; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id AE5E620C7DD4; Fri, 3 Feb 2023 17:26:43 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AE5E620C7DD4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1675474004; bh=ZmjtDXkGTNA2JU2wIugM9rpyKyNtKwOVI07Dm6GNSIg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kl3rJucokoMcf+OaEyYxPWg8rT3XGvqNiBmIoOt/KTU8GIfjqJGCYYX4luEcaUC6J 3BAAhf7pPaQFnjVGq/9J/25yBmTspUui6XPvUMtLTp3rehVN2iYtZKLUZiAYBVMhh9 monuFmgYaVcvKXNo+74q2/nVdG2zZgXJo39j/1q0= Message-ID: Date: Fri, 3 Feb 2023 20:26:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize To: devel@edk2.groups.io, ardb@kernel.org, Sunil V L , Sean Brogan , Michael Kinney , "Liming Gao (Byosoft address)" , Michael Kubacki Cc: Leif Lindholm , Abner Chang , Daniel Schaefer References: <20230203110843.2349736-1-ardb@kernel.org> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ard, I'm not an admin on the tianocore Azure DevOps organization so I cannot view or do much more than you can. It appears to me to be a transient issue during provisioning on the particular agent. Normally, I'd use a "rerun failed jobs" button to see if it continues to repro as a next step. A push to the PR branch will do the same thing. If you haven't already, can you try doing another push to kick off the builds again and see if it reoccurs? Thanks, Michael On 2/3/2023 6:48 AM, Ard Biesheuvel wrote: > I pushed this here > > https://github.com/tianocore/edk2/pull/3994 > > but I am getting weird errors from the CI > > An error occurred while provisioning resources (Error Type: Failure). > Build_VS2019 TARGET_FMP_FAT_TEST > The remote provider was unable to process the request. > Build_VS2019 TARGET_FMP_FAT_TEST > > without any explanation on how I am expected to mitigate this. > > Sean, Michael: can we fix this please? > > > On Fri, 3 Feb 2023 at 12:16, Sunil V L wrote: >> >> Thanks a lot!, Ard. >> >> Reviewed-by: Sunil V L >> >> >> On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote: >>> The code never references the PCD so the INF should not reference it >>> either. The last reference was moved to PrePiHobLib in commit >>> 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in >>> commit 97106391955337155e7. >>> >>> Cc: Leif Lindholm >>> Cc: Abner Chang >>> Cc: Daniel Schaefer >>> Reported-by: Sunil V L >>> Signed-off-by: Ard Biesheuvel >>> --- >>> EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf >>> index 3c749ca22943..090bfe888f52 100644 >>> --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf >>> +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf >>> @@ -58,8 +58,6 @@ [Protocols] >>> >>> >>> [FixedPcd.common] >>> - gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize >>> - >>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory >>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS >>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType >>> -- >>> 2.39.1 >>> > > > >