public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Dong, Eric" <eric.dong@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant parameter.
Date: Fri, 29 Jun 2018 09:19:49 +0200	[thread overview]
Message-ID: <b347b518-0550-aabf-c961-cacc5924b13b@redhat.com> (raw)
In-Reply-To: <ED077930C258884BBCB450DB737E66224AC1CF9E@shsmsx102.ccr.corp.intel.com>

On 06/29/18 03:48, Dong, Eric wrote:
> Hi Laszlo,
>
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]

>> I'm currently missing a good understanding of how these counters are
>> modified. They are all qualified "volatile", which suggests they are
>> accessed from multiple processors. Is that correct?
>
> No, actually only FinishedCount is changed by BSP and Aps, other two
> are only changed by BSP. StartCount stands for the AP count which will
> do the task. It is calculated by BSP before Aps start the task.
> RunningCount stands for the AP count which have finished the task. It
> also detected and changed by BSP.

> I will update the patch to remove the volatile for RunningCount.

Highly appreciated!
Laszlo


      reply	other threads:[~2018-06-29  7:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 11:29 [Patch 1/2] UefiCpuPkg/MpInitLib: Not use disabled AP Eric Dong
2018-06-28 11:29 ` [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant parameter Eric Dong
2018-06-28 15:37   ` Laszlo Ersek
2018-06-29  1:48     ` Dong, Eric
2018-06-29  7:19       ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b347b518-0550-aabf-c961-cacc5924b13b@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox