From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.2868.1598298195454719827 for ; Mon, 24 Aug 2020 12:43:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pos4OKfq; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598298194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HT0TGH2n0zTAVDNU71uR4WiwHSwmDrR2rvFXzR7apIE=; b=Pos4OKfq9r66eUN5kn7Lum6pwsP2xNBoiJpHiduT9a6UdZ4F+uNm3wmRze5i4i70RCKU8U YXL7yOFh4BpG9FtLJyCekw34eSy7wSL6vCb+iXccvAFukORaPCGyrd+W+b4Z6CzG5PDF5z LIpmjpH0s8dW3fvI95wz/zc3HRiJFt0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-cYBJg4pZNl-bRBBojYdKXw-1; Mon, 24 Aug 2020 15:43:00 -0400 X-MC-Unique: cYBJg4pZNl-bRBBojYdKXw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CED218A2246; Mon, 24 Aug 2020 19:42:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-186.ams2.redhat.com [10.36.112.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8BADA600E4; Mon, 24 Aug 2020 19:42:55 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: devel@edk2.groups.io, vladimir.olovyannikov@broadcom.com Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd References: <20200821160555.21436-1-vladimir.olovyannikov@broadcom.com> <20200821160555.21436-2-vladimir.olovyannikov@broadcom.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 24 Aug 2020 21:42:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200821160555.21436-2-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Vladimir, On 08/21/20 18:05, Vladimir Olovyannikov via groups.io wrote: > Introduce an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command, and > uses the same UEFI Shell command line parameters. This makes it easy > integrating http into existing UEFI Shell scripts. > Note that to enable HTTP download, feature Pcd > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must > be set to TRUE. > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > Signed-off-by: Vladimir Olovyannikov > Cc: Samer El-Haj-Mahmoud > Cc: Laszlo Ersek > Cc: Zhichao Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ray Ni > Cc: Liming Gao > Cc: Nd > --- > ShellPkg/ShellPkg.dec | 1 + > ShellPkg/ShellPkg.dsc | 5 + > .../HttpDynamicCommand/HttpApp.inf | 58 + > .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + > .../DynamicCommand/HttpDynamicCommand/Http.h | 88 + > ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + > .../DynamicCommand/HttpDynamicCommand/Http.c | 1693 +++++++++++++++++ > .../HttpDynamicCommand/HttpApp.c | 61 + > .../HttpDynamicCommand/HttpDynamicCommand.c | 137 ++ > CryptoPkg/Library/OpensslLib/openssl | 2 +- > .../HttpDynamicCommand/Http.uni | 116 ++ > 11 files changed, 2228 insertions(+), 1 deletion(-) > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.c > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni [...] > diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl > index e2e09d9fba11..c3656cc594da 160000 > --- a/CryptoPkg/Library/OpensslLib/openssl > +++ b/CryptoPkg/Library/OpensslLib/openssl > @@ -1 +1 @@ > -Subproject commit e2e09d9fba1187f8d6aafaa34d4172f56f1ffb72 > +Subproject commit c3656cc594daac8167721dde7220f0e59ae146fc your patch includes a hunk that moves our openssl submodule from 1.1.1g back to ~1.1.1d. I think that must be unintentional; can you please drop this hunk and post v7? Thanks Laszlo