From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, zhangdongdong@eswincomputing.com
Cc: zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com,
jinyanjiang@eswincomputing.com
Subject: Re: [edk2-devel] [PATCH 0/3] Fix some typos
Date: Tue, 13 Dec 2022 22:13:27 -0500 [thread overview]
Message-ID: <b3867943-39c2-f90d-9d81-1cc34a311c25@linux.microsoft.com> (raw)
In-Reply-To: <3942492e.d1b5.185091cf243.Coremail.zhangdongdong@eswincomputing.com>
Hi Dongdong,
I rebased my series and placed your three commits on top. Any changes
that were already addressed in my series were resolved and removed from
yours.
I added maintainer CC's to your patches so the maintainers will be
notified of the patches if they have email rules set up for that.
Here's the branch:
https://github.com/makubacki/edk2/commits/fix_new_spelling_errors
The PR is updated as well:
https://github.com/tianocore/edk2/pull/2903
The main purpose of my changes were originally to allow edk2 to upgrade
the spell checker used in the build process to a newer version. The
changes fix issues only reported in the new version.
I investigated automating corrections for all spelling issues (not just
those for new spell checker version to work) and the changes became
very, very large.
So I'm beginning to think I will just try to get this series in for now
since it's already taken some time to get it reviewed and then we can
deal with those later (our CI ignores those issues at the moment).
Can you please review my branch above and confirm that you are okay for
me to send a new patch series with your commits included?
Thanks,
Michael
On 12/12/2022 8:32 PM, Dongdong Zhang wrote:
> Hi,Michael
>
> Sorry, I didn't notice your similar commit.
> I am using codespell to check.
> In order to avoid similar commits,
> I feel it is necessary to merge your previous patch.
>
>
> Thanks,
> Dongdong
>
>> -----原始邮件-----发件人:"Michael Kubacki" <mikuback@linux.microsoft.com>发送时间:2022-12-12 22:58:37 (星期一)收件人:devel@edk2.groups.io, zhangdongdong@eswincomputing.com抄送:zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com主题:Re: [edk2-devel] [PATCH 0/3] Fix some typos
>>
>> Hello,
>>
>> I sent a similar series a few months ago:
>> https://github.com/tianocore/edk2/pull/2903
>>
>> At the time, there was not much interest in fixing these in edk2. But I
>> would still like to get the changes in.
>>
>> Are you running the spell check CI plugin?
>>
>> In order to reduce the number of spelling related fixes, do you think we
>> could merge our changes?
>>
>> Thanks,
>> Michael
>>
>> On 12/2/2022 4:25 AM, Dongdong Zhang wrote:
>>> Hi all,
>>>
>>> My focus was fixing typos in comments. Most of them
>>> were found by spellchecker.
>>>
>>> There are many similar spelling mistakes, so to avoid involving
>>> too many modules at once, only the files in the 'ArmPkg',
>>> 'ArmPlatformPkg' and 'ArmVirtPkg' directories were modified this time.
>>>
>>> Dongdong Zhang (3):
>>> ArmPkg: Fix typos
>>> ArmPlatformPkg: Fix typos
>>> ArmVirtPkg: Fix typos
>>>
>>> ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +-
>>> ArmPkg/Include/Library/OemMiscLib.h | 2 +-
>>> ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++---
>>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +-
>>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +-
>>> ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 2 +-
>>> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +++---
>>> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
>>> .../Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 2 +-
>>> ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
>>> ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +-
>>> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 2 +-
>>> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 ++--
>>> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
>>> .../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +-
>>> ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +-
>>> 16 files changed, 21 insertions(+), 21 deletions(-)
>>>
>
>
>
>
>
next prev parent reply other threads:[~2022-12-14 3:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 9:25 [PATCH 0/3] Fix some typos Dongdong Zhang
2022-12-02 9:25 ` [PATCH 1/3] ArmPkg: Fix typos Dongdong Zhang
2022-12-02 9:25 ` [PATCH 2/3] ArmPlatformPkg: " Dongdong Zhang
2022-12-02 9:25 ` [PATCH 3/3] ArmVirtPkg: " Dongdong Zhang
2022-12-12 14:58 ` [edk2-devel] [PATCH 0/3] Fix some typos Michael Kubacki
2022-12-13 1:32 ` Dongdong Zhang
2022-12-14 3:13 ` Michael Kubacki [this message]
2022-12-14 8:18 ` Dongdong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3867943-39c2-f90d-9d81-1cc34a311c25@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox