From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.93922.1670987610145748065 for ; Tue, 13 Dec 2022 19:13:30 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Hs9WrF+Q; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id D78B820B83FB; Tue, 13 Dec 2022 19:13:28 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D78B820B83FB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1670987609; bh=JAs6R2rizEHuF+FmHIDPXS6/mWgq59rUCrIEFfXp/fg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Hs9WrF+QXitntsk3FcWCCSOml++ttngyX54y7ugbDG3GM1zX/azJn7aZ/h7FwCqfY eNbDwiqgPPMJxNIXslefgc/xRyKT2V74HTW65C/b7EzdnsMI5rdJvqjs0m4mbI9AEz uBK96ZusaMK/L6CKhE3+Dti5ZID9hUMLA7MgfDMI= Message-ID: Date: Tue, 13 Dec 2022 22:13:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH 0/3] Fix some typos To: devel@edk2.groups.io, zhangdongdong@eswincomputing.com Cc: zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com References: <20221202092509.12072-1-zhangdongdong@eswincomputing.com> <1c29e450-d861-73d0-c205-45a92c00a260@linux.microsoft.com> <3942492e.d1b5.185091cf243.Coremail.zhangdongdong@eswincomputing.com> From: "Michael Kubacki" In-Reply-To: <3942492e.d1b5.185091cf243.Coremail.zhangdongdong@eswincomputing.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Dongdong, I rebased my series and placed your three commits on top. Any changes=20 that were already addressed in my series were resolved and removed from=20 yours. I added maintainer CC's to your patches so the maintainers will be=20 notified of the patches if they have email rules set up for that. Here's the branch: https://github.com/makubacki/edk2/commits/fix_new_spelling_errors The PR is updated as well: https://github.com/tianocore/edk2/pull/2903 The main purpose of my changes were originally to allow edk2 to upgrade=20 the spell checker used in the build process to a newer version. The=20 changes fix issues only reported in the new version. I investigated automating corrections for all spelling issues (not just=20 those for new spell checker version to work) and the changes became=20 very, very large. So I'm beginning to think I will just try to get this series in for now=20 since it's already taken some time to get it reviewed and then we can=20 deal with those later (our CI ignores those issues at the moment). Can you please review my branch above and confirm that you are okay for=20 me to send a new patch series with your commits included? Thanks, Michael On 12/12/2022 8:32 PM, Dongdong Zhang wrote: > Hi,Michael >=20 > Sorry, I didn't notice your similar commit. > I am using codespell to check. > In order to avoid similar commits, > I feel it is necessary to merge your previous patch. >=20 >=20 > Thanks, > Dongdong >=20 >> -----=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6-----=E5=8F=91=E4=BB=B6=E4=BA= =BA:"Michael Kubacki" =E5=8F=91=E9=80=81=E6= =97=B6=E9=97=B4:2022-12-12 22:58:37 (=E6=98=9F=E6=9C=9F=E4=B8=80)=E6=94=B6= =E4=BB=B6=E4=BA=BA:devel@edk2.groups.io, zhangdongdong@eswincomputing.com= =E6=8A=84=E9=80=81:zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com= , jinyanjiang@eswincomputing.com=E4=B8=BB=E9=A2=98:Re: [edk2-devel] [PATCH = 0/3] Fix some typos >> >> Hello, >> >> I sent a similar series a few months ago: >> https://github.com/tianocore/edk2/pull/2903 >> >> At the time, there was not much interest in fixing these in edk2. But I >> would still like to get the changes in. >> >> Are you running the spell check CI plugin? >> >> In order to reduce the number of spelling related fixes, do you think we >> could merge our changes? >> >> Thanks, >> Michael >> >> On 12/2/2022 4:25 AM, Dongdong Zhang wrote: >>> Hi all, >>> >>> My focus was fixing typos in comments. Most of them >>> were found by spellchecker. >>> >>> There are many similar spelling mistakes, so to avoid involving >>> too many modules at once, only the files in the 'ArmPkg', >>> 'ArmPlatformPkg' and 'ArmVirtPkg' directories were modified this time. >>> >>> Dongdong Zhang (3): >>> ArmPkg: Fix typos >>> ArmPlatformPkg: Fix typos >>> ArmVirtPkg: Fix typos >>> >>> ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +- >>> ArmPkg/Include/Library/OemMiscLib.h | 2 +- >>> ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++-= -- >>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +- >>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- >>> ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 2 +- >>> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +++-= -- >>> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +- >>> .../Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 2 +- >>> ArmPlatformPkg/ArmPlatformPkg.dec | 2 +- >>> ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +- >>> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 2 +- >>> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 ++-- >>> ArmVirtPkg/ArmVirt.dsc.inc | 2 +- >>> .../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +- >>> ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +- >>> 16 files changed, 21 insertions(+), 21 deletions(-) >>> >=20 >=20 >=20 >=20 >=20