From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.2096.1575406861775015433 for ; Tue, 03 Dec 2019 13:01:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OfMMEsPw; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575406860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xf4ehJ7tj+mG7OHGkZSPZ+SzXVEeqCBgezXjLPl++Oc=; b=OfMMEsPwBlkjSsSxY71eUyTGezn3PAq/pMXt4MlxbBAR8AHYAYZvAH+YjIkfwBEwcYCYEH OZZMMt6omPxIc9ZNbtZPZCKCdmnjPJEgCaKLeau0BuPtD8Ln7dbPJSVNqYzvmZ5ujsrQba JSLR41vQ4a5+1933hQC4l8uXvuIb9Gg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113-wc1vi_26P9GrhR5157eU_w-1; Tue, 03 Dec 2019 16:00:59 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 488D98017CC; Tue, 3 Dec 2019 21:00:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-183.ams2.redhat.com [10.36.117.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 991AC19C68; Tue, 3 Dec 2019 21:00:54 +0000 (UTC) Subject: Re: [PATCH 59/79] OvmfPkg/Virtio: Fix few typos To: Philippe Mathieu-Daude , devel@edk2.groups.io Cc: Antoine Coeur , Jordan Justen , Ard Biesheuvel References: <20191203161602.15969-1-philmd@redhat.com> <20191203161602.15969-60-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 3 Dec 2019 22:00:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191203161602.15969-60-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: wc1vi_26P9GrhR5157eU_w-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix few typos in comments and documentation. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/Include/Library/VirtioLib.h | 2 +- > OvmfPkg/Library/VirtioLib/VirtioLib.c | 2 +- > OvmfPkg/VirtioNetDxe/DriverBinding.c | 2 +- > OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2 +- > OvmfPkg/VirtioRngDxe/VirtioRng.c | 2 +- > OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/OvmfPkg/Include/Library/VirtioLib.h b/OvmfPkg/Include/Library/VirtioLib.h > index e817a4206f62..e714ec7aee50 100644 > --- a/OvmfPkg/Include/Library/VirtioLib.h > +++ b/OvmfPkg/Include/Library/VirtioLib.h > @@ -292,7 +292,7 @@ Virtio10WriteFeatures ( > VIRTIO_UNMAP_SHARED. > > > - @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped. > + @retval EFI_SUCCESS The NumberOfBytes is successfully mapped. > @retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a > common buffer. > @retval EFI_INVALID_PARAMETER One or more parameters are invalid. > diff --git a/OvmfPkg/Library/VirtioLib/VirtioLib.c b/OvmfPkg/Library/VirtioLib/VirtioLib.c > index 555d2a5ce7c9..e09324813c2d 100644 > --- a/OvmfPkg/Library/VirtioLib/VirtioLib.c > +++ b/OvmfPkg/Library/VirtioLib/VirtioLib.c > @@ -452,7 +452,7 @@ Virtio10WriteFeatures ( > VIRTIO_UNMAP_SHARED. > > > - @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped. > + @retval EFI_SUCCESS The NumberOfBytes is successfully mapped. > @retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a > common buffer. > @retval EFI_INVALID_PARAMETER One or more parameters are invalid. > diff --git a/OvmfPkg/VirtioNetDxe/DriverBinding.c b/OvmfPkg/VirtioNetDxe/DriverBinding.c > index eb0e873657a4..3c400a604650 100644 > --- a/OvmfPkg/VirtioNetDxe/DriverBinding.c > +++ b/OvmfPkg/VirtioNetDxe/DriverBinding.c > @@ -419,7 +419,7 @@ VirtioNetDriverBindingSupported ( > device error.Currently not implemented. > @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a > lack of resources. > - @retval Others The driver failded to start the device. > + @retval Others The driver failed to start the device. > > **/ > > diff --git a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c > index dc684650d665..d1e3ecfa5a0f 100644 > --- a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c > +++ b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c > @@ -118,7 +118,7 @@ VirtioNetUninitRing ( > a lack of resources. > @return Status codes from > VirtioMapAllBytesInSharedBuffer() > - @retval EFI_SUCCESS Caller-supplied buffer is succesfully mapped. > + @retval EFI_SUCCESS Caller-supplied buffer is successfully mapped. > */ > EFI_STATUS > EFIAPI > diff --git a/OvmfPkg/VirtioRngDxe/VirtioRng.c b/OvmfPkg/VirtioRngDxe/VirtioRng.c > index d0e2468c2373..4e2b710f9e49 100644 > --- a/OvmfPkg/VirtioRngDxe/VirtioRng.c > +++ b/OvmfPkg/VirtioRngDxe/VirtioRng.c > @@ -156,7 +156,7 @@ VirtioRngGetRNG ( > > Dev = VIRTIO_ENTROPY_SOURCE_FROM_RNG (This); > // > - // Map Buffer's system phyiscal address to device address > + // Map Buffer's system physical address to device address > // > Status = VirtioMapAllBytesInSharedBuffer ( > Dev->VirtIo, > diff --git a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c > index e50a697daa15..935d15439579 100644 > --- a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c > +++ b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c > @@ -497,7 +497,7 @@ VirtioScsiPassThru ( > // * we perform the request fine > // * but we fail to unmap the "InDataMapping" > // > - // In that case simply returing the EFI_DEVICE_ERROR is not sufficient. In > + // In that case simply returning the EFI_DEVICE_ERROR is not sufficient. In > // addition to the error code we also need to update Packet fields > // accordingly so that we report the full loss of the incoming transfer. > // > Reviewed-by: Laszlo Ersek