From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.17871.1601654078746908833 for ; Fri, 02 Oct 2020 08:54:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ikFmsQYX; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601654078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gf44D5q+FJc9e8ubj2Aa6Pf2njU7c09HlVVxKz5lXrI=; b=ikFmsQYX6ubSdQMezTWIYxS/PpxA8hE8U0p5s22Q3OWcRQlpLi5n12TiTOEZ97+jGDIfNE 0wVXO1qkgaoq+IeN4Hu21tNPc3l6LdWvjJAmYVRe2kCrMmd8fWBTJpqbF2CukgczNmOaMz H2ma+/PVqGmIgE3Sadsxo1UEuxyhITo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-dlbEieBUNkWHQU8LdhCD8A-1; Fri, 02 Oct 2020 11:54:33 -0400 X-MC-Unique: dlbEieBUNkWHQU8LdhCD8A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75E2A89CCC0; Fri, 2 Oct 2020 15:54:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-46.ams2.redhat.com [10.36.113.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id D26CC5C1D7; Fri, 2 Oct 2020 15:54:30 +0000 (UTC) Subject: Re: [edk2-devel] [RedfishPkg PATCH v3 1/4] RedfishPkg: Initial commit of RedfishPkg. To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" Cc: "Wang, Nickle (HPS SW)" , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20201002134820.22205-1-abner.chang@hpe.com> <20201002134820.22205-2-abner.chang@hpe.com> <1eb827cb-a97d-cbf9-4fd3-1a9b25f7b06d@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 2 Oct 2020 17:54:29 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10/02/20 17:24, Chang, Abner (HPS SW/FW Technologist) wrote: > > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Friday, October 2, 2020 11:13 PM >> To: Chang, Abner (HPS SW/FW Technologist) ; >> devel@edk2.groups.io >> Cc: Wang, Nickle (HPS SW) ; Andrew Fish >> ; Leif Lindholm ; Michael D Kinney >> >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v3 1/4] RedfishPkg: Initial >> commit of RedfishPkg. >> >> On 10/02/20 15:48, Abner Chang wrote: >>> Initial version of RedfishPkg. >>> >>> Signed-off-by: Wu Jiaxin >>> Signed-off-by: Fu Siyuan >>> Signed-off-by: Wang Fan >>> Signed-off-by: Chang Abner >>> Cc: Nickle Wang >>> Cc: Andrew Fish >>> Cc: Laszlo Ersek >>> Cc: Leif Lindholm >>> Cc: Michael D Kinney >>> --- >>> RedfishPkg/RedfishPkg.ci.yaml | 67 >> +++++++++++++++++++++++++++++++++++ >>> RedfishPkg/RedfishPkg.dec | 18 ++++++++++ >>> RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++ >>> 3 files changed, 125 insertions(+) >>> create mode 100644 RedfishPkg/RedfishPkg.ci.yaml create mode 100644 >>> RedfishPkg/RedfishPkg.dec create mode 100644 >>> RedfishPkg/RedfishPkg.dsc >>> >>> diff --git a/RedfishPkg/RedfishPkg.ci.yaml >>> b/RedfishPkg/RedfishPkg.ci.yaml new file mode 100644 index >>> 0000000000..75c3b6a8ad >>> --- /dev/null >>> +++ b/RedfishPkg/RedfishPkg.ci.yaml >>> @@ -0,0 +1,67 @@ >>> +## @file >>> +# CI configuration for NetworkPkg >>> +# >>> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
# >>> +SPDX-License-Identifier: BSD-2-Clause-Patent ## { >>> + "LicenseCheck": { >>> + "IgnoreFiles": [] >>> + }, >>> + "EccCheck": { >>> + ## Exception sample looks like below: >>> + ## "ExceptionList": [ >>> + ## "", "" >>> + ## ] >>> + "ExceptionList": [ >>> + ], >>> + ## Both file path and directory path are accepted. >>> + "IgnoreFiles": [ >>> + ] >>> + }, >>> + "CompilerPlugin": { >>> + "DscPath": "RedfishPkg.dsc" >>> + }, >>> + "CharEncodingCheck": { >>> + "IgnoreFiles": [] >>> + }, >>> + "DependencyCheck": { >>> + "AcceptableDependencies": [ >>> + "MdePkg/MdePkg.dec", >>> + "MdeModulePkg/MdeModulePkg.dec", >>> + "NetworkPkg/NetworkPkg.dec" >>> + ], >>> + # For host based unit tests >>> + "AcceptableDependencies-HOST_APPLICATION":[], >>> + # For UEFI shell based apps >>> + "AcceptableDependencies-UEFI_APPLICATION":[ >>> + "ShellPkg/ShellPkg.dec" >>> + ], >>> + "IgnoreInf": [] >>> + }, >>> + "DscCompleteCheck": { >>> + "DscPath": "RedfishPkg.dsc", >>> + "IgnoreInf": [] >>> + }, >>> + "GuidCheck": { >>> + "IgnoreGuidName": [], >>> + "IgnoreGuidValue": [], >>> + "IgnoreFoldersAndFiles": [] >>> + }, >>> + "LibraryClassCheck": { >>> + "IgnoreHeaderFile": [] >>> + }, >>> + >>> + ## options defined ci/Plugin/SpellCheck >>> + "SpellCheck": { >>> + "AuditOnly": True, # Fails test but run in AuditOnly mode to >> collect log >>> + "IgnoreFiles": [], # use gitignore syntax to ignore errors in >> matching files >>> + "ExtendWords": [], # words to extend to the dictionary for this >> package >>> + "IgnoreStandardPaths": [], # Standard Plugin defined paths that >> should be ignore >>> + "AdditionalIncludePaths": [] # Additional paths to spell check >> (wildcards supported) >>> + }, >>> + >>> + "Defines": { >>> + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE" >>> + } >>> +} >>> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec new >>> file mode 100644 index 0000000000..e95ec5fe10 >>> --- /dev/null >>> +++ b/RedfishPkg/RedfishPkg.dec >>> @@ -0,0 +1,18 @@ >>> +## @file >>> +# Redfish Package >>> +# >>> +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# >>> +(C) Copyright 2020 Hewlett Packard Enterprise Development LP
# # >>> +SPDX-License-Identifier: BSD-2-Clause-Patent ## >>> + >>> +[Defines] >>> + DEC_SPECIFICATION = 0x0001001b >>> + PACKAGE_NAME = RedfishPkg >>> + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008 >>> + PACKAGE_VERSION = 1.0 >>> + >>> +[Guids] >>> + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, >> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} >>> + >>> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new >>> file mode 100644 index 0000000000..8acadddefc >>> --- /dev/null >>> +++ b/RedfishPkg/RedfishPkg.dsc >>> @@ -0,0 +1,40 @@ >>> +## @file >>> +# Redfish Package >>> +# >>> +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# >>> +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP. >>> +# >>> +# SPDX-License-Identifier: BSD-2-Clause-Patent >>> +# >>> +## >>> + >>> +[Defines] >>> + PLATFORM_NAME = RedfishPkg >>> + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008 >>> + PLATFORM_VERSION = 1.0 >>> + DSC_SPECIFICATION = 0x0001001c >>> + OUTPUT_DIRECTORY = Build/RedfishPkg >>> + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64 >>> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT >>> + SKUID_IDENTIFIER = DEFAULT >>> + >>> +[LibraryClasses] >>> + >>> +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEn >>> +tryPoint.inf >>> + >>> >> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi >>> +BootServicesTableLib.inf >>> + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf >>> + >>> >> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi >>> +b/UefiRuntimeServicesTableLib.inf >>> + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf >>> + >>> >> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem >> ory >>> +AllocationLib.inf >>> + >>> +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >>> + >>> >> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron >>> +izationLib.inf >>> + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf >>> + >>> >> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba >>> +seDebugPrintErrorLevelLib.inf >>> + >>> >> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo >> rt8 >>> +0.inf >>> + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> + >>> >> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas >> e >>> +PeCoffGetEntryPointLib.inf >>> + >>> >> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab >>> +leLib.inf >>> + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf >>> + >>> >> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D >> xeRe >>> +portStatusCodeLib.inf >>> >> >> Acked-by: Laszlo Ersek >> >> One observation: the two GUIDs in this patch look quite close to each other: >> >> c4352870-5232-11e7-9522-005056c00008 (PLATFORM_GUID) >> c432b76e-5232-11e7-9010-005056c00008 (PACKAGE_GUID) >> ^^^ ^^^^ ^^^^ ^ ^^^^^^^^^^^^ >> >> It's quite rare to see time/MAC-based GUIDs nowadays :) > Yes. It's rare... I don’t remember how those GUID came from. But I didn’t play trick on that:) > Do you think it's better to generate a new GUID for that? No, I don't think so. I was originally alarmed (thought you modified GUIDs manually), but then ran "uuidgen --time" a few times, and got very similarly structured GUIDs (I didn't bother to look up the actual fields though). As long as "uuidgen" is invoked for every new GUID, I think we're fine. Thanks! Laszlo