public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel][edk2-platforms][PATCH V1 0/2] Fix build issues
@ 2022-09-08  3:48 Isaac Oram
  2022-09-08  3:48 ` [edk2-devel][edk2-platforms][PATCH V1 1/2] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
  2022-09-08  3:48 ` [edk2-devel][edk2-platforms][PATCH V1 2/2] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram
  0 siblings, 2 replies; 3+ messages in thread
From: Isaac Oram @ 2022-09-08  3:48 UTC (permalink / raw)
  To: devel; +Cc: Isaac Oram, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong

These commits fix some small build issues from various changes.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>

Isaac Oram (2):
  MinPlatformPkg/Include: Add PEI DevicePathLib instance
  PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include

 .../PlatformPayloadFeaturePkg.dsc                   | 13 +++++--------
 .../Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc |  1 +
 2 files changed, 6 insertions(+), 8 deletions(-)

--
2.36.1.windows.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [edk2-devel][edk2-platforms][PATCH V1 1/2] MinPlatformPkg/Include: Add PEI DevicePathLib instance
  2022-09-08  3:48 [edk2-devel][edk2-platforms][PATCH V1 0/2] Fix build issues Isaac Oram
@ 2022-09-08  3:48 ` Isaac Oram
  2022-09-08  3:48 ` [edk2-devel][edk2-platforms][PATCH V1 2/2] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram
  1 sibling, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2022-09-08  3:48 UTC (permalink / raw)
  To: devel; +Cc: Isaac Oram, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong

PEI DevicePathLib instance required by NvmExpressPei.inf
due to recent change.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
index 9bac751eaf..4424ebaecc 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
@@ -27,6 +27,7 @@
   MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
+  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
   CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
 
-- 
2.36.1.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [edk2-devel][edk2-platforms][PATCH V1 2/2] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include
  2022-09-08  3:48 [edk2-devel][edk2-platforms][PATCH V1 0/2] Fix build issues Isaac Oram
  2022-09-08  3:48 ` [edk2-devel][edk2-platforms][PATCH V1 1/2] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
@ 2022-09-08  3:48 ` Isaac Oram
  1 sibling, 0 replies; 3+ messages in thread
From: Isaac Oram @ 2022-09-08  3:48 UTC (permalink / raw)
  To: devel; +Cc: Isaac Oram, Sai Chaganty, Nate DeSimone

Fix build issue from removed PCD and use MinPlatformFeaturesPcd.dsc.inc.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 .../PlatformPayloadFeaturePkg.dsc                   | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index 1b79e0039b..e36e5d6e1e 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
@@ -48,16 +48,13 @@
 #
 ################################################################################
 
-#
-# Since there are no 32b libraries or components in this package, these PCD are specified for 64b only
-#
-[PcdsFeatureFlag]
   #
-  # PCD needed for MinPlatform build includes
+  # MinPlatform common include for required feature PCD
+  # These PCD must be set before the core include files, CoreCommonLib,
+  # CorePeiLib, and CoreDxeLib.
+  # Optional MinPlatformPkg features should be enabled after this
   #
-  gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable                |FALSE
-  gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable                   |FALSE
-  gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable                      |FALSE
+  !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc
 
 [PcdsPatchableInModule]
   gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7
-- 
2.36.1.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-08  3:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08  3:48 [edk2-devel][edk2-platforms][PATCH V1 0/2] Fix build issues Isaac Oram
2022-09-08  3:48 ` [edk2-devel][edk2-platforms][PATCH V1 1/2] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
2022-09-08  3:48 ` [edk2-devel][edk2-platforms][PATCH V1 2/2] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox