From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B1F26D80A13 for ; Wed, 18 Oct 2023 13:42:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1V6tRM4Nsjs2Q46rEf6oPiEw+OjYcKJk2HI6BcojmDk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697636534; v=1; b=sz7vM35iZASAHviqdug/n9x4m0oylc5NlRg9tNlTM6vpUZnyFEXM4k76ufUrKRCQM7s32v/d 4Pv8eOvEiayZ2FOc0hnFMFGAVY+dbWcUT8c56AG5KxZ0vi4vDtRGMP2jw6M/lcQCGLV9I2ir4XR x+vY9xvHTTfEKIgxrR795T+U= X-Received: by 127.0.0.2 with SMTP id xWCvYY7687511xMOmQGujXyv; Wed, 18 Oct 2023 06:42:14 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.281917.1697636533831470380 for ; Wed, 18 Oct 2023 06:42:13 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-412-bqL0K9rePi6fk-tQq-ys1w-1; Wed, 18 Oct 2023 09:42:10 -0400 X-MC-Unique: bqL0K9rePi6fk-tQq-ys1w-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC50B29AB40B; Wed, 18 Oct 2023 13:42:09 +0000 (UTC) X-Received: from [10.39.192.202] (unknown [10.39.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F26C71C060AE; Wed, 18 Oct 2023 13:42:08 +0000 (UTC) Message-ID: Date: Wed, 18 Oct 2023 15:42:07 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: Ray Ni , nd References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> <20231012091057.108728-2-lersek@redhat.com> <2912F689-CF79-45EB-8911-92B99B41238A@arm.com> From: "Laszlo Ersek" In-Reply-To: <2912F689-CF79-45EB-8911-92B99B41238A@arm.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6s4P4Um81zIW0zOpUPZIPSDJx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sz7vM35i; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) Hi Sami, On 10/12/23 14:33, Sami Mujawar wrote: > Hi Laszlo, > > Thank you for this patch. > These changes look good to me. > > Reviewed-by: Sami Mujawar > > Tested by booting a Linux guest using Kvmtool guest firmware (ArmVirtPkg/ArmVirtKvmTool.dsc) for AArch64. > Tested-by: Sami Mujawar your response is under a PcAtChipsetPkg patch -- that's not used in "ArmVirtPkg/ArmVirtKvmTool.dsc". Which patches did you mean your Tested-by for? Thanks! Laszlo > > Regards, > > Sami Mujawar > > On 12/10/2023, 10:25, "devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io" on behalf of lersek=redhat.com@groups.io > wrote: > > > PcatRealTimeClockRuntimeDxe seems to have copied the interface name > LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class. > That's not right, for two reasons: > > > - PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the > first place, > > > - in EmbeddedPkg, the RealTimeClockLib class API > LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API). > > > Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(), > and make it static. > > > Tested with booting OVMF. > > > Cc: Ray Ni > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > Signed-off-by: Laszlo Ersek > > --- > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > > diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > index b600df487952..ca0cad9b0198 100644 > --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > @@ -122,9 +122,10 @@ PcRtcEfiSetWakeupTime ( > @param[in] Event The Event that is being processed > @param[in] Context Event Context > **/ > +STATIC > VOID > EFIAPI > -LibRtcVirtualNotifyEvent ( > +VirtualNotifyEvent ( > IN EFI_EVENT Event, > IN VOID *Context > ) > @@ -220,7 +221,7 @@ InitializePcRtc ( > Status = gBS->CreateEventEx ( > EVT_NOTIFY_SIGNAL, > TPL_NOTIFY, > - LibRtcVirtualNotifyEvent, > + VirtualNotifyEvent, > NULL, > &gEfiEventVirtualAddressChangeGuid, > &mVirtualAddrChangeEvent > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109750): https://edk2.groups.io/g/devel/message/109750 Mute This Topic: https://groups.io/mt/101914676/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-