From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.79]) by mx.groups.io with SMTP id smtpd.web10.72.1620160097223685093 for ; Tue, 04 May 2021 13:28:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=hMcI+NNs; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.79, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jt22aSuIqtAeyVxCuxAWpce8kqK6GAuaSyp89fJCKpuHOibpFsDDqW+0zcWhAwX+6Eodm++jvAJj6SmWPbDaUo0g/Qz9k2nbfRsOJhIsoRN8EeuBVIydR0Pn80iE+1AmhmGNghs/2X3WeMgT2HhvyChjhViG9+9Ot1/XKCPMcmZEiWyWtZY5C+ull1p7bY/VclQgWjdWIqqxl79ZQhRW31rBc2qCXx5AZs5CryVjEvLLpu3BWVbX/D4zhEUsoDp3fKSS3IRxDh8eT3feDJQpJcbRhTpominZuJ6ctxXu1Y/IZ+MvTS+yYHhoC6qs8HaDCjcoSjl+LpjHD3fqbu/sjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4YEspmJbjqADJ869v/BLvL1INb7mdbR7ypAAJsif7I=; b=LDfriG27K8g6l/cY8/0PB7oBTctTSfiORW+sVmfnEduLxuuY4Avo/6TC6PdUsPSrMW5Z0BxMLE+x1txOTkom25m7B8INMHNMhQYT2vvlDMCkrdNhT8G7GbSmPJyS87Gs22Z+KK0ja0e/XdiEPKeryP8snPD/ln/Tmb6B1FlZg2yfCOsGNg3CDDseuNw5lsjfMezy31rC/OWJ+0nME1y96W6v/jfsQKEk5ed8bu05qYUb1h8Xpo70YjQml7j35MPYXvKCcfdiR8MF4fDEGxy4K/t+NCTk/58a2UJxKg1lvfc812a7Sg2QZSN3ipLytsAhOdhYgPhMqOlG8Z4uqK6c6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4YEspmJbjqADJ869v/BLvL1INb7mdbR7ypAAJsif7I=; b=hMcI+NNsOpdbhCfeG4p1KKBgW5HX2P/pzxTSpbb3VqspHmnMF1CoEGFfmVZvXo+qUYuw0mJyI/61cL0e2WN5tMRN1wyWQhsbPfP8rac/h/dd/stt7uRra6XGyzTzM4NPAeBQ/jMIMtCKxrCZQ97KTZj4oD9sry3jiKC77ZlhymE= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2640.namprd12.prod.outlook.com (2603:10b6:805:6c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.40; Tue, 4 May 2021 20:28:15 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4108.025; Tue, 4 May 2021 20:28:15 +0000 Cc: brijesh.singh@amd.com, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas Subject: Re: [edk2-devel] [PATCH RFC v2 05/28] MdePkg: Add AsmPvalidate() support To: devel@edk2.groups.io, Laszlo Ersek References: <20210430115148.22267-1-brijesh.singh@amd.com> <20210430115148.22267-6-brijesh.singh@amd.com> <167BF2A01FA60569.6407@groups.io> <167BF53DA09B327E.22277@groups.io> From: "Brijesh Singh" Message-ID: Date: Tue, 4 May 2021 15:28:13 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: <167BF53DA09B327E.22277@groups.io> X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: SN7PR04CA0091.namprd04.prod.outlook.com (2603:10b6:806:122::6) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SN7PR04CA0091.namprd04.prod.outlook.com (2603:10b6:806:122::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Tue, 4 May 2021 20:28:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b3d5bcd-19a8-4bf5-ea5c-08d90f3b2501 X-MS-TrafficTypeDiagnostic: SN6PR12MB2640: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dQJfAhaoj/4Je6da50Jfv3OF0cczR3sVZhCzjsnVmlgZO1VCqTWP0G7gLnmmZenMiOx44kHZcTwnudQ0vUy1r964Fkoo2Dm1LnC+wp4S3y3vMPuwq+1hKs4WZi2l1tagB865VdWh2o5xHI/o7y1uBylBgK3Jw+BoQjglQZsZOStsXsiG3U47P1YEqkzVYNUB7YxdmCDMVC8kLRo5a+1oVAJzVc9ivkgl4YzSLD6XsGBMSz9kkDf3kZ3kEacH8Xbdj7qGGpUSLlKPlpx/qaDkDfCXhgN3Mfq/80nbFwUmx749x8OnhWGhnbgVa2+isLHElebJXtMt1HfKkcVtE0gbkxVkEHmGUNG73wXO+G7FK+IXZQdJbPHOjiboNTXat+FMbMMZkJtHbtZU1ghLqgVXFRZ6mo74LUU/RTNtzcXT4APqmsc4joS1nFz24UFf5hndwmlo77kCI1wa26umPLQmrud87VgGn+1K6YIohmC07bLjfkTzSnASQ4S+sPy2xRVEodDurbevFFYCQEBpBd1mQMRu2fHOmpSINNMR8suLGup3x3u+Av+udJ1F/fJoXPt9OGLYuOPAJIHrK6U7X0BKU3KaXd3kBmoyWiCy3tr9ODm7zcF0autHAQ6McW07K0BbyfgDtEMZ7GfOCyJxmDpHyk1WjiIAb8PkWlHPtBIPRpKLhIcAycq9ykrfmCqMcPMabl3I/nh+CTNMQCkHi/ZPjC/gC93po29XJWnb/4teWsM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(26005)(478600001)(186003)(956004)(38350700002)(38100700002)(6486002)(44832011)(8936002)(86362001)(4326008)(6916009)(5660300002)(6512007)(54906003)(316002)(8676002)(31696002)(2616005)(66476007)(53546011)(6506007)(52116002)(66556008)(2906002)(16526019)(36756003)(31686004)(66946007)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cEtwclV3enFsOTc0NlE0ZDFSM0UweWVOanhFQVZqR3g3QXRiUkpoYzc5VlBk?= =?utf-8?B?K1B1TUVOZTJiTm4rR1lQelRCY0llMEsvUHNYclVOK2lSMC9IYzlmQnFuc1pY?= =?utf-8?B?ZUQxUTFZVEZZNmNDUXcwTDAzcHo4clBheUpMMi8xeFhnZ2E2MlhRK0Y1TE9x?= =?utf-8?B?SGZ0eTNocGFNc3FDUjJpbXlBVlhoeDNKcE9KR0ttakczdnlYTUNiMmpwMm9x?= =?utf-8?B?UjRQWi8xSXZhTldKaWVHZ2cwc3ZtTTNFajY0VTdmL211SEpSU0pCTWhJUUtE?= =?utf-8?B?UHhtWDhYOVl4RjVsT0p4ekpPN0tFTTlVdzJENHNTa0krVkdBOXVxU1JYSTM3?= =?utf-8?B?a01walBTMVU4OWF0M2hUN1NlOWZuRFhZMFNxTWhxa3cyVlUwd1hNd1Zydi9p?= =?utf-8?B?Nkl0VTUyNm5rb0hmZU1oNUVmN0xPakIyQjgyWVlWOFE5ME5RYUlvdThrMFpV?= =?utf-8?B?d1ljVzdZemMrMlFRcjlBYTE3aHBYUUkxOUkwa1JsTUhNdEVIQW5SUldhcGVQ?= =?utf-8?B?SnlkMHRFbk0wbUowN1o0Y29tKy8xV2h2cG5RSlBDalhGa0NyUm5FNzdvYnMw?= =?utf-8?B?dDBIem1sdmpOVE80dlJYMUtUZzE1bmtKWnJEOXRmYVJFaXM0ZUlJRHRZN0lx?= =?utf-8?B?YjcwQjcyQ0ZLenZQQTVvM3BMVUNadzVpU0Y2TWQ2disyTG1DaDB4cHZlRmdD?= =?utf-8?B?WkkxdlNaODJoL2U5VHFhTjVYNHYzSUdtenk5MzZ1dmlxbHFiQkcvTWNTL2xS?= =?utf-8?B?Wk5YY25IOEVoUXN3R2pWZE1Zb1lvUXNyUjJpN29ha1JwQ1JzTWVZbmNIQ1d2?= =?utf-8?B?TXNOeUdXTnMzdGdRczFpdUd3ZXdhWFkzeCt3OWtZTTVJdUZlY1JSelFQWWZR?= =?utf-8?B?SkgwU3RVUVc3NlMrcFVRaGxYNEhLRlVpbThNRjZFQmk0TVRVLzUvRktJS2RK?= =?utf-8?B?VnF0cFNSbkRXajE4V0UrVkJURzQrdkc5NUF1cVNlVk82SEs4SnF6WG96cVU4?= =?utf-8?B?Uml2SEV5SXBDM3BheEsyUEIxZFFUeFNyRFFmT2hiRVFxQ0NubW14WFEzVFNK?= =?utf-8?B?QUZkS2QrTEw2QXJ3SXJGaENMS09EeXB1QTFibzBiSFUrODUxNS80WlRWUUNo?= =?utf-8?B?N2tiMllOMWRORUhqa3dSMlQydVFrdjRRakt5VlEvSzl4ZGVZY3UydHlja0V6?= =?utf-8?B?bkhjTUY0cWphWERHYURrL0hFSHppQzJSUSt4MFZGSUl0RWgwZ0FHTzlNLzdR?= =?utf-8?B?bkRvZURqRVJydWNSSlZiRW5qUmgxbUF2b2dhUVduc21uOEc1ZExJYkdhcEE1?= =?utf-8?B?aVdwdkJBc0REQXpHNC80Uk9ITENRYTRoVkREYkN0dXZBeVNTbXVXcjhkdWJn?= =?utf-8?B?akRBSXJXT3JJdVd3VkUyUTdWN1l1TlNOZmc2VTBJamEwL0dMSmVvQ01aWXRv?= =?utf-8?B?TmduWndTL1BWR1VCT3daZ3UzS2pwZkk5MVRxdGJ2QlUwYXVtNGN4bkFLQ0pm?= =?utf-8?B?aEVRMHlFWWtlRjhybmtycDZ1WlZua05XUTN2VkF5elVDU1BEdU5Wd1lxaTFj?= =?utf-8?B?LysrM0RtL0V3Ymp4SU1BVVpkckpaTUtzeS9maXhnTEFNMkFyeUhMSWkySkVG?= =?utf-8?B?M3g3Q2U3dDdaYmppMHhUOHZoamZrVzJRUCtZUWd0OE5HbnJ6TEtvZU9ZNUN4?= =?utf-8?B?Qit4d3paNHYydGphTkZhQmF5V0haNVN4M2YrU1pRamk5Mm8wNjZnZEtBNCt6?= =?utf-8?Q?gpg3yuRd+DTvQk2A6mk9gx82d0x21xt/dcgiDYV?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b3d5bcd-19a8-4bf5-ea5c-08d90f3b2501 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2021 20:28:14.9454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mohXpdJwkOKdWgJOcX6HjH4tSqe1uav2GdChPX6jRqgVmgToXT/9M9sWKXyV4iOZyx/AJ8Kp4j8D70DdFZ0+dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2640 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 5/4/21 2:55 PM, Brijesh Singh via groups.io wrote: > On 5/4/21 2:07 PM, Brijesh Singh via groups.io wrote: >>> Return EFI_UNSUPPORTED (0x8000_0003), or even EFI_NO_MAPPING >>> (0x8000_0017), for value 6 (FAIL_SIZEMISMATCH). >> I am not sure if we really want to do this. You will see later in the >> patches that in some cases the PVALIDATE will return a failure and we >> will need to know the failure code to determine the next steps. >> Especially this particular error code is used later. This error happens >> when the page size of the backing pages does not match with the >> pvalidated size. In those cases we need to retry the PVALIDATE with >> lower page size so that a validation succeed. One such a example is: >> >> - Guest ask hypervisor to add the page as 2M in RMP table. >> >> - Hypervisor added the page as 512 4K pages - because it was not able to >> find a large backing pages. >> >> - Guest attempts to pvalidate the page as a 2M. The pvalidate will >> return a failure saying its a size mismatch between the requested >> pvalidated and RMP table. The recommendation is that guest should try >> with a smaller page size. >> >> I would prefer to pass the pvalidate error as-is to caller so that it >> can make the correct decision. >> > I am perfectly fine if the function return UINTN and then use #define > instead of the enum to define the PVALIDATE return code. So that caller > can check the error code. Let me know your thought on #define instead of > the enum. Apologies, I missed the fact that you said document the mapping between the PVALIDATE return value and EFI_STATUS. So a caller is responsible to look at the EFI document to know what the error code means. The unsupported here does not mean that PVALIDATE is not support on platform. I am good with it. I will go ahead with it. -Brijesh