From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C73B4D81113 for ; Wed, 3 Jan 2024 14:54:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LH3G0R9SA9vlUKsp68iOPc+MSWWVmrbexSkGbNUlplw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704293659; v=1; b=C+DeOhMpVPB5y//VIKfRtW/4t6eGcSzKxSwNIF3j1bpcqI6qhXijBgEi2pVnTMyPlxBpnlLk QlzNIASqGcXSCVW12TlOxAwQlFmMfhkluVcpczeHleniJsdGU9XbD+tV1rZHfS0B/jPaiDjzhXh /dO2802dnp2+dHtDPqlgKNx0= X-Received: by 127.0.0.2 with SMTP id WepaYY7687511xiwTPEMUvUX; Wed, 03 Jan 2024 06:54:19 -0800 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.83]) by mx.groups.io with SMTP id smtpd.web11.19053.1704293658143525298 for ; Wed, 03 Jan 2024 06:54:18 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SaygnLlFhRAioLaFBg+sLR9ZSUJcQrwweFeTHQr1FOSKvjteQ5MdVcAdBsUv0eQnVXlu8cd05KVlgPG3rnTsXg77B+LazmeyU3hSw1QgFbd0IVEDHEJ/eumRiddx2wiyQDlWgck3C62XYZOsPiyjv7u0e54DcreLOK+K20moVgBth7HjJudyZfQS3YXFecQZdk94djonBcfMeizMMM1L3gv76HFjw1K159Zt6d4mwU2ptTN9+KXxbRN5HUmrsqmt/VYon1zMBsRNMNQV6Su2qpSBXqYjP+kD8U8MrIfDBWLLr4wU6TT+Md30sV1/fE/cSRH/8xIrJcQAMlfG90mh9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNsRpyb2l7bL2Ib+Zf7ACkm1/WNTh3aN51yN1hQ2H+M=; b=hnmIU695f4RjI2BZtYzfeTdwTiuQHzFp6ZjevekwQUzYMezs6PWGXpgl8PQUK24NJlSXXCQXs9y9J0H6P2WCudemryOzgJwRe5yI7eljWbBV2zqfSlnpgXuwaeHenqW3IJQhFKptbwL+UdulqzIspGLNINWchxwd5ActTfPW6puxtCFajXEXGo6Yqz8C0q0NvaLtvhR8VVX2W88aB7ZibG+5hP5pBfT9RdsZ+1zculzRmErKPIyIXp91Muwgvx/NF+q4JiB3/7RJKyIOLk5qJTgzd1VxXlhMe2aGqOz/wdZDwR41Xs6FJBlfwsq6WkXDUsGR54SMpRGjF6U37vEHLg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DU6P191CA0036.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::23) by PR3PR08MB5676.eurprd08.prod.outlook.com (2603:10a6:102:82::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 14:54:12 +0000 X-Received: from DU6PEPF00009528.eurprd02.prod.outlook.com (2603:10a6:10:53f:cafe::d4) by DU6P191CA0036.outlook.office365.com (2603:10a6:10:53f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13 via Frontend Transport; Wed, 3 Jan 2024 14:54:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF00009528.mail.protection.outlook.com (10.167.8.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 14:54:12 +0000 X-Received: ("Tessian outbound 968ce956f8b7:v239"); Wed, 03 Jan 2024 14:54:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6caf7ff5e96198fd X-CR-MTA-TID: 64aa7808 X-Received: from 71f9d535ac91.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8767D8C6-E124-4121-B115-442AB036D3EF.1; Wed, 03 Jan 2024 14:54:05 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 71f9d535ac91.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Jan 2024 14:54:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JPxu2+PzlnKlQzaDjsyPMuYpMCPtYGqOrAfFp4bRjQ5/FDhseriFygnxfRFQin+NIKFckKygsdB+FA0nFrFd9lgYjAlKDLSiEHWmOJVltPbG8ehi1y/zYx3dV7FAvh1LvwmYZi7xQCh43952RVJGgpmwhEvb4pUFin28HMkyGCoRSgMiBjoXA6387rnASLtxeHH5QsuJhaBkEGc7kqInuGDFVIwsk/OZJcWBfqDgl67lh30wOwOg2UGxnTquyjF/yM9HOcTV3/EGnbbw17JXZ27RM8JuunLnvhFUaiH4HU/S4Nyq93EQe2A736TAAOgWPOQAdMBH5cuqFYXOklUquA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNsRpyb2l7bL2Ib+Zf7ACkm1/WNTh3aN51yN1hQ2H+M=; b=cfefqPIFKafkihtKKNwopBCRy+eevoKrLteH/6iBcd7Os+ZAdOEFs6M2Cm07fQWCSowJr8eqxhrzB1xxY3YGK9p7XuU/QAVDkEpXrGR8MDYPQpCDo5tvlInyhm2R1/QmSnAD1KqWfll/l1GIc35E312Z8YYSGUSV1JeBYusnkilyGVJTjUjtM6jtn9DkMfNLh5u7eCIKPkEnVsQrFegYjtdrGFHMHGKQSeslj+1WLO1dUdJDGk2JzxuaQh5J0A2Ny65yafKUMTUtG2SN3q8Vx8acw3vlEuZViYjo9jV6VYL+Tx9G7xruGKMtw/AraOVUOgHimEgqWddIqKoqADkYlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GV2PR08MB8392.eurprd08.prod.outlook.com (2603:10a6:150:b4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.24; Wed, 3 Jan 2024 14:54:02 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7159.013; Wed, 3 Jan 2024 14:54:02 +0000 Message-ID: Date: Wed, 3 Jan 2024 14:54:00 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors To: devel@edk2.groups.io, AbdulLateef.Attar@amd.com, "nd@arm.com" , Pierre Gondois References: From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P302CA0021.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::12) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GV2PR08MB8392:EE_|DU6PEPF00009528:EE_|PR3PR08MB5676:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ac59c39-b33b-4a42-84b2-08dc0c6bd8fe x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: u1eopSzwegdb/OYcz3Lf+sx5T5vUtaYJnpFEMim+B1mGm/XP9VHcgQYB7269kwSvKkuOQ+umV+PP9dfSx+oRP9sQYl/dCGKqr0VVPeM0O3O9qVliZqQm+RgRh1syVLXisj2ML3jKn3RTq0HW3DSufadQ7R10/XY1K6BNkCqzS+ZIUGkwE4ou6mSE25pQU10aDjb2M2aQuVOyuhEkpdBRszwcRnefBUOZKs1gLo5gwK3HXl9UXlB2/8TG/tcxFU1Dzqzdoc3HQghRkeGJ9w7/Ibvl3W6hQPOzLgnFO4FlRwCLEKlGmQ2R/xfIXrRfq9JYq/su1eToNgfBYH19HGgSuq8mu5DaZQCvbFtgFwTtA/ZHP/ZnZsU3ZomJGCbcWYYFfaMkVlKRuNxn+NeRPcJJtA+0ltH6tGKk+kJ3B82zujQHJXwXv4B2wrwi4JORsrQ0XFz5Vd5nL6eK720emmARe0AVHEIclJgLSFSJTQkr0BHJpAU9vPRYyBfdh3L848CbJ5VGsW3xnWKog9ojlSTsAFdupx45PAMen4PRwPdt3S381lgjSnybmdei+l2pGrGGWdhb46fErcxanl2Wc+CTyg6vSQZq76m0OcfAKJpnCfztGwWHcniJ+359EnRmf3NShhGcIPBmSgfN87gyog1UcABxN+dwLnBQHwNZFnaYveE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(346002)(39860400002)(396003)(376002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(6506007)(53546011)(478600001)(6512007)(6486002)(966005)(31696002)(2616005)(44832011)(26005)(2906002)(6636002)(41300700001)(5660300002)(8676002)(316002)(66556008)(110136005)(8936002)(66946007)(66476007)(38100700002)(83380400001)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8392 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF00009528.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8c3f229f-9f24-4415-1768-08dc0c6bd309 X-Microsoft-Antispam-Message-Info: dL+MC/zAzuKKcmgHsuiGWdIpVBeXqxXE/0BroEKnMo+AaIxn3ZQercM8Ikt8NyPyeOpp4sty2vSHE5UnbSDNlLWksEvRqws93Iu8LO1TrvaTuPP1MpsNFK00L4j2INxJN3AiVmmMpte/x/aLBv729MiOIgoCspH9/Tbza+3MrmO6LqmYv/aPy6JfSn1+W2E78FaF6JoyoHS0JCOkoP1FBzM2cfFb9S9HOfd03kDkZuTa+rxHFryE/P8kYfiuIBbp+AWN11usmnT/rnBlYIR8+n7bH5N/Xfm7hTdM9VWz/BNyexN9DxzovdJMq+VAARISt3zhUf5TY/RwucVjwHsufHthsTHccdaNvVKYEYdUYO10ahDPErUJqxrIGNllSCiOq6oEojylqg9LUh+TMhATXapAPIFBMN4nNkN8Z4sjRGuGSyV25OWZl2u5Bjj2Q+DUVWpDK+mCaDoCxZC6i6XvrMVp1Pg0Ep0TctUq7r3mST801HvoToX7yKFRhFbfuydISCpidzoUP9YglAwtNuNtBfKxE8B9Qv/aROmUY8+Qh9tDTTZos7ymc7wZ/pJyKPVyyNJAQGblWyzERklDa4I2z1b8LGeZVFXqKo7Dxb/44k35jo4MGenujQgH/9Vq905bVbmAWvkHEKQznwMeTbUqrfF+GUFC8T0Hut2mC5IBoPIPQkY1W6y2MaPLvu3Hh+egUadN0XrvY/meBjGspOqYxcFhR/i0xD5gUnK8XWdpYPKM2pXJ15xjW4T9D0feViKYSsCixFy5xTVcVATfFpwGz96VXUU+iMkvwZjXdm/t07s= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 14:54:12.1360 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac59c39-b33b-4a42-84b2-08dc0c6bd8fe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009528.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5676 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zKY8rMyR02fP4Y3tbZiOGAJux7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=C+DeOhMp; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Abdul, I have merged this series as d7d4f09ff815..2576cbafec98. Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it would be good to enable that in the edk2 CI. That way we do not accidently break the builds. To enable edk2 CI for AARCH64 using GCC, I had made the change at https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-= gate-build-job.yml#L50 I am not sure what is required to support X64 and IA32 builds using VS2019. Can you provide a patch for that, please? Also, by any chance have you tried building DynamicTablesPkg with GCC for X64 and IA32? Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote: > From: Abdul Lateef Attar > > PR: https://github.com/tianocore/edk2/pull/5209 > v2: Fix the IA32 compilation errors. > v1: Fix the X64 compilation errors. > > Cc: Pierre Gondois pierre.gondois@arm.com > Cc: Sami Mujawar sami.mujawar@arm.com > Cc: Abdul Lateef Attar > > Abdul Lateef Attar (2): > DynamicTablesPkg: Fix X64 compilation errors > DynamicTablesPkg: Fix IA32 compilation errors > > DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++----- > DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- > .../Library/Common/AmlLib/AmlLib.inf | 2 ++ > .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- > .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- > .../ConfigurationManagerObjectParser.c | 2 +- > .../Library/Common/TableHelperLib/TableHelper.c | 6 ++++-- > .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ > 8 files changed, 32 insertions(+), 15 deletions(-) > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113098): https://edk2.groups.io/g/devel/message/113098 Mute This Topic: https://groups.io/mt/103499168/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-