From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.8760.1595930201786975994 for ; Tue, 28 Jul 2020 02:56:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Sugnfzyp; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595930201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kIMCmQML2laUNgdvyi+z20cVYv3N77rLde+t0GRROzo=; b=Sugnfzyp86mqZfYicQgciFSiktC7PpJJ7XDKk57m7+T7afP3dkFY3Zxrmazz0Ti1HhziRc JQ/MxW4OQIGSCdN3qsMPdxEIbXwL8bX9YzgVv1qIVvULLieZYcG6F9gydXJ78Pl4z2VI5M 4nrAExw7oMTjTGHIpYimlEMXeNHPDIc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-h4Sjv1AyOA2mTPkCS70EPg-1; Tue, 28 Jul 2020 05:56:31 -0400 X-MC-Unique: h4Sjv1AyOA2mTPkCS70EPg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 732F910059A2; Tue, 28 Jul 2020 09:56:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-229.ams2.redhat.com [10.36.113.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41DB95DA6B; Tue, 28 Jul 2020 09:56:29 +0000 (UTC) Subject: Re: [PATCH 10/15] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for LicenseCheck To: "Zhang, Shenglei" , Rebecca Cran Cc: "devel@edk2.groups.io" , "Justen, Jordan L" , Ard Biesheuvel References: <20200720083709.17264-1-shenglei.zhang@intel.com> <20200720083709.17264-11-shenglei.zhang@intel.com> <6961878a-716a-e4d3-2b7e-34ca5c28ce9b@redhat.com> <014b464b-0621-2ff9-a714-3ae8948510bf@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 28 Jul 2020 11:56:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/28/20 03:11, Zhang, Shenglei wrote: > Hi Laszlo, > >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Monday, July 27, 2020 5:51 PM >> To: Zhang, Shenglei ; Rebecca Cran >> >> Cc: devel@edk2.groups.io; Justen, Jordan L ; >> Ard Biesheuvel >> Subject: Re: [PATCH 10/15] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for >> LicenseCheck >> >> On 07/27/20 08:21, Zhang, Shenglei wrote: >>> Hi Laszlo, >>> >>> VbeShim.h is existing in edk2 now. This plugin only checks the patches to >> be checked in. >>> So there's no need to add existing files to this section. >> >> OK, thanks, we can always extend this stanza later, if needed. >> >> Rebecca: once this patch is upstream, please post a separate patch for listing >> "OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h" in "IgnoreFiles". Otherwise I >> won't be able to merge your patch at >> . >> >> >> Shenglei: I have a question regarding IgnoreFiles syntax. In >> "MdeModulePkg/MdeModulePkg.ci.yaml", there are two syntaxes: >> >> - The IgnoreFiles stanza for "CharEncodingCheck" uses pathnames that are >> relative to the *project* root: >> >>> ## options defined ci/Plugin/CharEncodingCheck >>> "CharEncodingCheck": { >>> "IgnoreFiles": [ >>> >> "MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c", >>> >> "MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/tes >> tc.c" >>> ] >>> }, >> >> - The IgnoreFiles stanza for "SpellCheck" uses pathnames that are relative to >> the *package* (not project) root: >> >>> "SpellCheck": { >>> ... >>> "IgnoreFiles": [ # use gitignore syntax to ignore errors in matching >> files >>> "Library/LzmaCustomDecompressLib/Sdk/DOC/*" >>> ], >> >> How do we know whether a particular check's IgnoreFiles stanza requires >> project-root-relative or package-root-relative pathnames? > > It depends on the designing of the plugins, likes the check scope. > But looks like all checks' IgnoreFiles stanza only requires package-root-relative pathnames, currently. > It's recommended to use package-root-relative pathnames because a plugin must support this format. Thanks! So we should ignore "Bhyve/BhyveRfbDxe/VbeShim.h". Thanks Laszlo