From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web10.51379.1683209774365089886 for ; Thu, 04 May 2023 07:16:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=g4fEwneD; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 344ECOZ2014899; Thu, 4 May 2023 14:16:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=E+9MPdlcpPXwFMcwAZhGRNPjIN2tWUHKlPxQYglfz08=; b=g4fEwneDvixMXMInObjvFl04rvM/8cetM2d1RjVVJBkF26p+6+Nao6iiVd4Q7yphCAMD IWXCxBHH7Ip/VQnOVG+7dZ5chxZJWl2TfLsp9WduYb8cnTTcMMAhK/nv1PTENqDpHJEf sPMEAyD0C0fR7nbTXFizT18GryiSeiABkYFVs2CitL8rYXtlFh1VanRqloQdrekKMrvD 1a1Tir+gTauTXaU9jLIjuXQLlafryHeM0MOprixas7Rflz4AXSlV4nId/sXbU4TqBMQk B/li+434g/89tTBwZBtlIxwb4d7YuiI/5TuPBNV45iZbGR7GklxoMxlNHxbQ+sRKczH0 oA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qce8wr4fv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 May 2023 14:16:11 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 344ECb9f016010; Thu, 4 May 2023 14:16:11 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qce8wr4f2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 May 2023 14:16:11 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 344BrSp6005177; Thu, 4 May 2023 14:16:10 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([9.208.129.119]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3q8tv8g9sj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 May 2023 14:16:10 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 344EG8t030081724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 May 2023 14:16:08 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F72558058; Thu, 4 May 2023 14:16:08 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6337658057; Thu, 4 May 2023 14:16:06 +0000 (GMT) Received: from [IPv6:2601:5c4:4302:c21::a774] (unknown [9.211.131.5]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 4 May 2023 14:16:06 +0000 (GMT) Message-ID: Subject: Re: [PATCH 2/3] OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: Gerd Hoffmann , devel@edk2.groups.io Cc: Jiewen Yao , Erdem Aktas , Min Xu , Tom Lendacky , Jordan Justen , Stefan Berger , Julien Grall , Anthony Perard , =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau , Ard Biesheuvel , Oliver Steffen , Pawel Polawski , Michael Roth Date: Thu, 04 May 2023 10:16:05 -0400 In-Reply-To: <20230504133251.1031341-3-kraxel@redhat.com> References: <20230504133251.1031341-1-kraxel@redhat.com> <20230504133251.1031341-3-kraxel@redhat.com> User-Agent: Evolution 3.42.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: uret-orxU4U-0l1bYE7ikFsFPaVaic5l X-Proofpoint-GUID: ucMJzA-aJvEA0yzRvRfGK6LTziwFe7W4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-04_10,2023-05-04_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 clxscore=1011 impostorscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305040115 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id 344ECOZ2014899 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2023-05-04 at 15:32 +0200, Gerd Hoffmann wrote: > Use PlatformBootManagerLib with PcdBootRestrictToFirmware > set to TRUE instead. >=20 > Signed-off-by: Gerd Hoffmann > --- > =C2=A0OvmfPkg/AmdSev/AmdSevX64.dsc | 10 ++++++++-- > =C2=A01 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc > b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 943c4eed9831..b32049194d39 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -153,6 +153,7 @@ [LibraryClasses] > =C2=A0=C2=A0 > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEn > tryPoint.inf > =C2=A0=C2=A0 > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/Ue > fiApplicationEntryPoint.inf > =C2=A0=C2=A0 > DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/Uefi > DevicePathLibDevicePathProtocol.inf > +=C2=A0 NvVarsFileLib|OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.inf All additions apart from this look fine, but this one is a security risk: EFI variables represent an unmeasured configuration for SEV boot and, as such, can be used to influence the boot and potentially reveal boot secrets, so the AmdSevPkg was designed to have read only EFI variables that couldn't be subject to outside influence. James