From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Rebecca Cran <rebecca@bluestop.org>,
devel@edk2.groups.io, Laszlo Ersek <lersek@redhat.com>,
Liming Gao <liming.gao@intel.com>,
Yonghong Zhu <yonghong.zhu@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64
Date: Thu, 11 Apr 2019 22:11:31 +0200 [thread overview]
Message-ID: <b49506da-35c6-faac-8072-e7a7483e8af1@redhat.com> (raw)
In-Reply-To: <ed784ded-4fce-8e7b-8864-a5fa6ad9f8dc@bluestop.org>
On 4/11/19 9:58 PM, Rebecca Cran wrote:
> On 2019-04-11 13:55, Philippe Mathieu-Daudé wrote:
>>
>> With the work around link added:
>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
>
>
> But it's _not_ working around that bug. That was about "uname -p", but
> the patch is about "uname -m".
Ah you are right, the script simply parse the 'machine hardware name' to
extract the host architecture. We shouldn't rely on the 'processor type
name' which is non-portable. Simply checking for 'arm64' is enough.
So do not add the link, and keep my tag:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Regards,
Phil.
next prev parent reply other threads:[~2019-04-11 20:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 3:16 [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64 Rebecca Cran
2019-04-11 13:44 ` [edk2-devel] " Liming Gao
2019-04-11 14:23 ` Philippe Mathieu-Daudé
2019-04-11 17:52 ` Laszlo Ersek
2019-04-11 19:38 ` Rebecca Cran
2019-04-11 19:55 ` Philippe Mathieu-Daudé
2019-04-11 19:58 ` rebecca
2019-04-11 20:11 ` Philippe Mathieu-Daudé [this message]
2019-04-12 7:54 ` Laszlo Ersek
2019-05-02 21:15 ` rebecca
2019-05-03 9:17 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b49506da-35c6-faac-8072-e7a7483e8af1@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox