From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.67, mailfrom: philmd@redhat.com)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by groups.io with SMTP; Thu, 11 Apr 2019 13:11:34 -0700
Received: by mail-wr1-f67.google.com with SMTP id y7so8954445wrn.11
        for <devel@edk2.groups.io>; Thu, 11 Apr 2019 13:11:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=AXMnc8GWXll+ot4mexXkwUn03FiuMYiWPAY3ffBevI0=;
        b=ZMVCfd4KyUGHCKiA5Gzakf9r14UKAFCrjX3gExVNVTOU4oi7pkzSqhvL7xv1HpWyzG
         k/XQQmRHCr8gKB7k8GJZNTVWGZgI3TTh+E2Na683R8lhmmgthJBkCa7IBbRSBG3a9I9y
         2gJrtEIC6tdzIPXa913R26PDt0kLbZPDxp14suBY2MkgRgp7x6PJIoMdEU0dHjvci9B6
         AwMS96zcZ0PjLkeg7qIlRihvdUaM+oREBE1l+vQPfyMoeKuI2eWrzZPDCPtgBX1Y+MS3
         +tlC6Wy34DnYiR1hYo2V75QW4AI5LQX2qQrmHa4ArM79PKZVeuIgejAobZ9lpoGZFnd0
         HJng==
X-Gm-Message-State: APjAAAVwvQoI7Ouo0QxpZTSaRhj8WZ8qAkkoDfZbPSjjuVQIQnBTAQhg
	Maq5e1X7EOXkjcxIGy8t0/xAFA==
X-Google-Smtp-Source: APXvYqyheQj7jYlIBeUc1pJRHAfl8r5ggN0sjeubT7zVWZDtI6SJCU4IiPHwyI4jR4YWM8ca7AqWcA==
X-Received: by 2002:adf:f30a:: with SMTP id i10mr32057935wro.111.1555013492349;
        Thu, 11 Apr 2019 13:11:32 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193])
        by smtp.gmail.com with ESMTPSA id v16sm74358841wro.48.2019.04.11.13.11.31
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Thu, 11 Apr 2019 13:11:31 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64
To: Rebecca Cran <rebecca@bluestop.org>, devel@edk2.groups.io,
 Laszlo Ersek <lersek@redhat.com>, Liming Gao <liming.gao@intel.com>,
 Yonghong Zhu <yonghong.zhu@intel.com>
References: <20190411031653.38092-1-rebecca@bluestop.org>
 <d262c662-0044-ec1a-42fc-5527cc8de0dd@redhat.com>
 <19000479-83f6-49fb-7a68-e09b31cd0a0e@redhat.com>
 <aa59ae96-c93e-689b-de90-4e328a827e0c@redhat.com>
 <ed784ded-4fce-8e7b-8864-a5fa6ad9f8dc@bluestop.org>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <b49506da-35c6-faac-8072-e7a7483e8af1@redhat.com>
Date: Thu, 11 Apr 2019 22:11:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <ed784ded-4fce-8e7b-8864-a5fa6ad9f8dc@bluestop.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 4/11/19 9:58 PM, Rebecca Cran wrote:
> On 2019-04-11 13:55, Philippe Mathieu-Daudé wrote:
>>
>> With the work around link added:
>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> 
> 
> 
> But it's _not_ working around that bug. That was about "uname -p", but
> the patch is about "uname -m".

Ah you are right, the script simply parse the 'machine hardware name' to
extract the host architecture. We shouldn't rely on the 'processor type
name' which is non-portable. Simply checking for 'arm64' is enough.

So do not add the link, and keep my tag:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Regards,

Phil.