From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.18615.1597249661201414040 for ; Wed, 12 Aug 2020 09:27:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=BOEkvLT2; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.67, mailfrom: pete@akeo.ie) Received: by mail-wm1-f67.google.com with SMTP id x5so2313683wmi.2 for ; Wed, 12 Aug 2020 09:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5fEFA/f3qXn2DbzelnPf9oFZ78Jh3Pj8NibVFVvqJR0=; b=BOEkvLT20im5cQFqpTNWoyJDQBYoA34wWiw+jo5in2y3lSxJLe0FyWc7osPOQhX+6r QKtxFWHWT0ooMFi0QXIn0n61XIvlj1Y8Vl3yrSHWnvUOnc9Cnrv+Jj4HYxop/fj3uMKW /5CzYpAz/Jk8B3UBi4f46X4YQT2LOYBHy4AERnyXfJIf+abfv803ARNySoGkz2axV0Kc olQ0AepOlZf+2+paNu2EtIKlqVkXgukcMtMzwETcXLANc2Ri+CcDpOrOJxVco7L58clk v3nXFTQXuNCmDssHBi7IZOx9jXWQUo/f1A6bCYlvgrHQCHKmEwJ+yaGpWvPfLWS6/J9m Yidw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5fEFA/f3qXn2DbzelnPf9oFZ78Jh3Pj8NibVFVvqJR0=; b=TzjxaJTdCkd0GjwhEA3c8cFRweAsjLTR23CBKQhmgqk2J2uqEL2i4aXV5BxpGfDPVq JLAD8xxUoPyW0y7shPv5f3XI1k+237k80maC4kVYO+lJ2h5XkJFaiND9sgAvMJiKtcoe 2STMvdGWfwvK4cheBr7Ybpp7rWrYml8nNqxWyzCO3poKct6RyXXuNiK+dybVOe00RxWi tfogAcDgCEzhDTmdf9O0Z7iyiECuaE7TEAkvTRMHE8QnLb1eW6kGTysLDfm8Bp8B3Pav yDcO33qnunPXnFNsQI+NhdLZIokRboRuUUyTy6J36yYyuKOIK+jnRBxA6ySENHOOnLWY 8KFA== X-Gm-Message-State: AOAM530AK8iiAAZUNddLWyx6ZofFlQZqc6UneaCe+21j0XEFRTxBSBbj WFAqnq78HCAo8qrdC6EQAxR80A== X-Google-Smtp-Source: ABdhPJx965D2rklAZYpg/FEV+Df3JdlwQVOUfOlNrE8JYZhRpW5VKzfiIZtdZ/0Uk78aH5UHARiugw== X-Received: by 2002:a7b:c084:: with SMTP id r4mr503437wmh.20.1597249659772; Wed, 12 Aug 2020 09:27:39 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.48.42]) by smtp.googlemail.com with ESMTPSA id f16sm5222274wro.34.2020.08.12.09.27.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2020 09:27:38 -0700 (PDT) Subject: Re: [edk2-platform][PATCH v1 7/7] Platforms/RaspberryPi: SMBIOS minor cleanup To: Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Andrei Warkentin , Ard Biesheuvel References: <20200720181646.2891-1-Samer.El-Haj-Mahmoud@arm.com> <20200720181646.2891-8-Samer.El-Haj-Mahmoud@arm.com> From: "Pete Batard" Message-ID: Date: Wed, 12 Aug 2020 17:27:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200720181646.2891-8-Samer.El-Haj-Mahmoud@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit From what I could see, Andrei already sent a R-b for 1-6, thus: On 2020.07.20 19:16, Samer El-Haj-Mahmoud wrote: > Minor code cleanup: > - Update file header to list SBBR required/recommended tables > - Rename DataSmbiosHande to DataSmbiosHandle > - Remove SMBIOS_HANDLE_PI_RESERVED from Type 11 template for > consistency. This is already done in LogSmbiosData(). > > Cc: Leif Lindholm > Cc: Pete Batard > Cc: Andrei Warkentin > Cc: Ard Biesheuvel > Signed-off-by: Samer El-Haj-Mahmoud > --- > Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 43 ++++++++++++-------- > 1 file changed, 25 insertions(+), 18 deletions(-) > > diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c > index d382797602ce..d955291c5bb7 100644 > --- a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c > +++ b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c > @@ -1,20 +1,27 @@ > /** @file > * > - * Static SMBIOS Table for ARM platform > + * Static SMBIOS Table for the RaspberryPi platform > * Derived from EmulatorPkg package > * > - * Note SMBIOS 2.7.1 Required structures: > - * BIOS Information (Type 0) > - * System Information (Type 1) > - * Board Information (Type 2) > - * System Enclosure (Type 3) > - * Processor Information (Type 4) - CPU Driver > - * Cache Information (Type 7) - For cache that is external to processor > - * System Slots (Type 9) - If system has slots > - * Physical Memory Array (Type 16) > - * Memory Device (Type 17) - For each socketed system-memory Device > - * Memory Array Mapped Address (Type 19) - One per contiguous block per Physical Memroy Array > - * System Boot Information (Type 32) > + * Note - Arm SBBR ver 1.2 required and recommended SMBIOS structures: > + * BIOS Information (Type 0) > + * System Information (Type 1) > + * Board Information (Type 2) - Recommended > + * System Enclosure (Type 3) > + * Processor Information (Type 4) - CPU Driver > + * Cache Information (Type 7) - For cache that is external to processor > + * Port Information (Type 8) - Recommended for platforms with physical ports > + * System Slots (Type 9) - If system has slots > + * OEM Strings (Type 11) - Recommended > + * BIOS Language Information (Type 13) - Recommended > + * System Event Log (Type 15) - Recommended (does not exit on RPi) > + * Physical Memory Array (Type 16) > + * Memory Device (Type 17) - For each socketed system-memory Device > + * Memory Array Mapped Address (Type 19) - One per contiguous block per Physical Memroy Array > + * System Boot Information (Type 32) > + * IPMI Device Information (Type 38) - Required for platforms with IPMIv1.0 BMC Host Interface (not applicable to RPi) > + * Onboard Devices Extended Information (Type 41) - Recommended > + * Redfish Host Interface (Type 42) - Required for platforms supporting Redfish Host Interface (not applicable to RPi) > * > * Copyright (c) 2017-2018, Andrey Warkentin > * Copyright (c) 2013, Linaro.org > @@ -480,7 +487,7 @@ CHAR8 *mSysSlotInfoType9Strings[] = { > ************************************************************************/ > > SMBIOS_TABLE_TYPE11 mOemStringsType11 = { > - { EFI_SMBIOS_TYPE_OEM_STRINGS, sizeof (SMBIOS_TABLE_TYPE11), SMBIOS_HANDLE_PI_RESERVED }, > + { EFI_SMBIOS_TYPE_OEM_STRINGS, sizeof (SMBIOS_TABLE_TYPE11), 0 }, > 1 // StringCount > }; > CHAR8 *mOemStringsType11Strings[] = { > @@ -641,7 +648,7 @@ CHAR8 *mBootInfoType32Strings[] = { > @param Template Fixed SMBIOS structure, required. > @param StringPack Array of strings to convert to an SMBIOS string pack. > NULL is OK. > - @param DataSmbiosHande The new SMBIOS record handle . > + @param DataSmbiosHandle The new SMBIOS record handle. > NULL is OK. > **/ > > @@ -650,7 +657,7 @@ EFIAPI > LogSmbiosData ( > IN EFI_SMBIOS_TABLE_HEADER *Template, > IN CHAR8 **StringPack, > - OUT EFI_SMBIOS_HANDLE *DataSmbiosHande > + OUT EFI_SMBIOS_HANDLE *DataSmbiosHandle > ) > { > EFI_STATUS Status; > @@ -716,8 +723,8 @@ LogSmbiosData ( > Record > ); > > - if ((Status == EFI_SUCCESS) && (DataSmbiosHande != NULL)) { > - *DataSmbiosHande = SmbiosHandle; > + if ((Status == EFI_SUCCESS) && (DataSmbiosHandle != NULL)) { > + *DataSmbiosHandle = SmbiosHandle; > } > > ASSERT_EFI_ERROR (Status); > Reviewed-by: Pete Batard