From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, Chasel Chiu <chasel.chiu@intel.com>,
Heng Luo <heng.luo@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Sai Chaganty <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() macros
Date: Mon, 17 Oct 2022 21:10:14 -0400 [thread overview]
Message-ID: <b4addcc1-66c1-aca2-0ada-4914fa5f835c@linux.microsoft.com> (raw)
In-Reply-To: <171D57FF5DF1A0DF.17458@groups.io>
Following up on this series. I addressed Nate's v1 feedback.
Thanks,
Michael
On 10/12/2022 10:16 AM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095
>
> Fixes several debug macros in Silicon/Intel that have a mismatched
> number of print specifiers to arguments.
>
> The original author's intention is not always 100% obvious. Though,
> this series is relatively straightforward.
>
> v2 changes:
> - Applied debug macro suggestions in Nate's feedback
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (3):
> CoffeelakeSiliconPkg: Fix invalid debug macros
> KabylakeSiliconPkg: Fix invalid debug macros
> TigerlakeSiliconPkg: Fix invalid debug macros
>
> Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolicy.c | 2 +-
> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/GbeMdiLib.c | 2 +-
> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c | 4 ++--
> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpressHelpersLib/PchPciExpressHelpersLibrary.c | 2 +-
> Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolicy.c | 19 +++++++++++--------
> Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c | 4 ++--
> Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c | 2 +-
> Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c | 2 +-
> 8 files changed, 20 insertions(+), 17 deletions(-)
>
parent reply other threads:[~2022-10-18 1:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <171D57FF5DF1A0DF.17458@groups.io>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4addcc1-66c1-aca2-0ada-4914fa5f835c@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox