From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.1728.1666055416323903628
 for <devel@edk2.groups.io>;
 Mon, 17 Oct 2022 18:10:16 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=T9CBb6eq;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 32E9820FDC2C;
	Mon, 17 Oct 2022 18:10:15 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 32E9820FDC2C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1666055415;
	bh=dAvkkQeikmHG4wM+e5XsxLlgDR+R1uvQyLg30uEhFr8=;
	h=Date:Subject:From:To:Reply-To:References:In-Reply-To:From;
	b=T9CBb6eqhAILjKdjA/t+1hyQr8RxdvxEiUYNJZQJHkGYKn1B3YtC1Rdg3z8uiixl2
	 g1U41OC9zsJzQ6E0mAUdv1WtpWvuLY4F1OoaS3oAnHGSLCZHRuVOVVrs8QQxWBbhdt
	 f5ld3oJj6JXkwBLaihKArpBnk/xFYlG4egxJ4ooY=
Message-ID: <b4addcc1-66c1-aca2-0ada-4914fa5f835c@linux.microsoft.com>
Date: Mon, 17 Oct 2022 21:10:14 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() macros
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, Chasel Chiu <chasel.chiu@intel.com>,
 Heng Luo <heng.luo@intel.com>, Nate DeSimone
 <nathaniel.l.desimone@intel.com>,
 Sai Chaganty <rangasai.v.chaganty@intel.com>
Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com
References: <171D57FF5DF1A0DF.17458@groups.io>
In-Reply-To: <171D57FF5DF1A0DF.17458@groups.io>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Following up on this series. I addressed Nate's v1 feedback.

Thanks,
Michael

On 10/12/2022 10:16 AM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095
> 
> Fixes several debug macros in Silicon/Intel that have a mismatched
> number of print specifiers to arguments.
> 
> The original author's intention is not always 100% obvious. Though,
> this series is relatively straightforward.
> 
> v2 changes:
>    - Applied debug macro suggestions in Nate's feedback
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>    CoffeelakeSiliconPkg: Fix invalid debug macros
>    KabylakeSiliconPkg: Fix invalid debug macros
>    TigerlakeSiliconPkg: Fix invalid debug macros
> 
>   Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolicy.c                                       |  2 +-
>   Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/GbeMdiLib.c                                         |  2 +-
>   Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c                                              |  4 ++--
>   Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpressHelpersLib/PchPciExpressHelpersLibrary.c |  2 +-
>   Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolicy.c                                         | 19 +++++++++++--------
>   Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c                                                |  4 ++--
>   Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c                           |  2 +-
>   Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c   |  2 +-
>   8 files changed, 20 insertions(+), 17 deletions(-)
>