From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 2188922436937
 for <edk2-devel@lists.01.org>; Fri, 23 Feb 2018 07:20:39 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 54F7840201A0;
 Fri, 23 Feb 2018 15:26:40 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-112.rdu2.redhat.com
 [10.10.120.112])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 1F43810AF9E6;
 Fri, 23 Feb 2018 15:26:38 +0000 (UTC)
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Heyi Guo <heyi.guo@linaro.org>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Ruiyu Ni <ruiyu.ni@intel.com>, Eric Dong <eric.dong@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Star Zeng <star.zeng@intel.com>
References: <1519376008-110662-1-git-send-email-heyi.guo@linaro.org>
 <1519376008-110662-2-git-send-email-heyi.guo@linaro.org>
 <bc322c54-a03d-ea4d-e76d-a35712eba6a1@redhat.com>
 <CAKv+Gu8a7YtRVpteq8pZcU6_d8V1865K0GQ6LynujkMO-PjqZw@mail.gmail.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <b4b426ae-31a3-21fc-6ace-5002535faf9d@redhat.com>
Date: Fri, 23 Feb 2018 16:26:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu8a7YtRVpteq8pZcU6_d8V1865K0GQ6LynujkMO-PjqZw@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.6]); Fri, 23 Feb 2018 15:26:40 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]);
 Fri, 23 Feb 2018 15:26:40 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Feb 2018 15:20:39 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/23/18 16:17, Ard Biesheuvel wrote:
> On 23 February 2018 at 15:05, Laszlo Ersek <lersek@redhat.com> wrote:

>> (3) In general, the comment style requires comments like this:
>>
>>   //
>>   // Add empty comment lines both before and after.
>>   //
>>
> 
> Quite the opposite, in fact. Search for 'horror vacui' in the coding
> style document.

Right, I remember that. But, I don't recall a single comment block
(using "//"), recent or old, that does not violate that rule. Arguably,
the rule is wrong (it certainly doesn't match on-going practice).

Technically I was wrong however; thanks for the correction.

> That does not mean I agree with that document, and I am perfectly fine
> with both styles.

OK.

So, please ignore my comments on the comments.

Thanks
Laszlo