Re: [Patch v3 0/5] Change CpuS3Data memory type and address limitation

[Laszlo Ersek <lersek@redhat.com>]

Eric,

On 08/10/18 06:19, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadToLock point by PiSmmCpuDxeSmm driver, 
> the memory type no need to be ACPI NVS type, also the address not limit to below 4G.
> 
> This change remove the limit of ACPI NVS memory type and below 4G.
> 
> Cc: Marvin H user <Marvin.Haeuser@outlook.com>
> Cc: Fan Jeff <vanjeff_919@hotmail.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> 
> Eric Dong (5):
>   UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram.
>   UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and Below 4G limitation.
>   UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.
>   UefiCpuPkg/CpuS3DataDxe: Remove below 4G limitation.
>   UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation.
> 
>  UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                |  60 +++++++---
>  UefiCpuPkg/Include/AcpiCpuData.h                   |  34 ++----
>  .../DxeRegisterCpuFeaturesLib.c                    |  67 -----------
>  .../PeiRegisterCpuFeaturesLib.c                    | 131 ---------------------
>  .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h   |  20 ----
>  .../RegisterCpuFeaturesLib.c                       |  92 +++++++++++++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c                  |  11 +-
>  7 files changed, 153 insertions(+), 262 deletions(-)
> 

Because patches #1 and #3 could still be updated, I'm not going to test
the series at this time. If you decide to replace the global variables
from patch #1 with local variables, using an incremental change, *and*
for patch #3, AllocateZeroPages() does not prove useful, then I'll test
this version. Otherwise I'd like to test the next version (v4).

Thanks!
Laszlo