From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 62640210C7ACE for ; Fri, 10 Aug 2018 09:39:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F05340676C0; Fri, 10 Aug 2018 16:39:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-207.rdu2.redhat.com [10.10.120.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45FE421568A1; Fri, 10 Aug 2018 16:39:39 +0000 (UTC) To: Eric Dong , edk2-devel@lists.01.org Cc: Marvin H user , Fan Jeff , Ruiyu Ni References: <20180810041909.12776-1-eric.dong@intel.com> From: Laszlo Ersek Message-ID: Date: Fri, 10 Aug 2018 18:39:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180810041909.12776-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 10 Aug 2018 16:39:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 10 Aug 2018 16:39:40 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch v3 0/5] Change CpuS3Data memory type and address limitation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 16:39:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Eric, On 08/10/18 06:19, Eric Dong wrote: > Because CpuS3Data memory will be copy to smram at SmmReadToLock point by PiSmmCpuDxeSmm driver, > the memory type no need to be ACPI NVS type, also the address not limit to below 4G. > > This change remove the limit of ACPI NVS memory type and below 4G. > > Cc: Marvin H user > Cc: Fan Jeff > Cc: Laszlo Ersek > Cc: Ruiyu Ni > > > Eric Dong (5): > UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram. > UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and Below 4G limitation. > UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation. > UefiCpuPkg/CpuS3DataDxe: Remove below 4G limitation. > UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation. > > UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 60 +++++++--- > UefiCpuPkg/Include/AcpiCpuData.h | 34 ++---- > .../DxeRegisterCpuFeaturesLib.c | 67 ----------- > .../PeiRegisterCpuFeaturesLib.c | 131 --------------------- > .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 20 ---- > .../RegisterCpuFeaturesLib.c | 92 +++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 11 +- > 7 files changed, 153 insertions(+), 262 deletions(-) > Because patches #1 and #3 could still be updated, I'm not going to test the series at this time. If you decide to replace the global variables from patch #1 with local variables, using an incremental change, *and* for patch #3, AllocateZeroPages() does not prove useful, then I'll test this version. Otherwise I'd like to test the next version (v4). Thanks! Laszlo