From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mx.groups.io with SMTP id smtpd.web12.3413.1606387376951485841 for ; Thu, 26 Nov 2020 02:42:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.191, mailfrom: xiewenyi2@huawei.com) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4ChZ8H0T97zLv1y; Thu, 26 Nov 2020 18:42:23 +0800 (CST) Received: from [10.174.152.217] (10.174.152.217) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Thu, 26 Nov 2020 18:42:42 +0800 Subject: Re: [EXTERNAL] [PATCH edk2-Platform v3 0/1] Hisilicon/Smbios: Replace DEPRECATED code with S-suffixed one To: Leif Lindholm CC: , , , , , References: <1599641549-25821-1-git-send-email-xiewenyi2@huawei.com> <20201125142652.GT1664@vanye> From: "wenyi,xie" Message-ID: Date: Thu, 26 Nov 2020 18:42:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: <20201125142652.GT1664@vanye> X-Originating-IP: [10.174.152.217] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit OK, I'm working on it. Thanks Wenyi On 2020/11/25 22:26, Leif Lindholm wrote: > I am sorry, I managed to misfile this set. > > On Wed, Sep 09, 2020 at 16:52:28 +0800, Wenyi Xie wrote: >> Main Changes since v2: >> Adding ASSERT_EFI_ERROR() to check the return code from >> UnicodeStrToAsciiStrS. > > Reviewed-by: Leif Lindholm > Pushed as f37e98bfc00d. > > However, the build still fails (for all of d03, d05, d06) due to > missing symbols in binary modules in edk2-non-osi. > > Can you fix and post updated binaries required? > Please generate patches with --no-binary and include a link to a > repository which I can pick the commits directly from. > > / > Leif > >> Wenyi Xie (1): >> Hisilicon/Smbios: Replace DEPRECATED code with S-suffixed one >> >> Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 3 ++- >> Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.c | 18 +++++++++++------ >> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 21 +++++++++++++------- >> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 9 ++++++--- >> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 18 +++++++++++------ >> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 18 +++++++++++------ >> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 15 +++++++++----- >> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c | 3 ++- >> 8 files changed, 70 insertions(+), 35 deletions(-) >> >> -- >> 2.20.1.windows.1 >> > . >