Re: [edk2-devel] [PATCH v1 0/6] Enhance DynamicTablesPkg modules

["Kun Qin" <kuqin12@gmail.com>]

Thank you for the review, Pierre! We will update the patches per your 
feedback and send v2 after validation.

Regards,
Kun

On 7/20/2022 6:38 AM, PierreGondois wrote:
> Except for:
> [PATCH v1 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check 
> for installed tables
> [PATCH v1 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to 
> reserve ECAM space
> where I had some remarks,
>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>
> Thanks!
>
> On 7/19/22 02:22, Kun Qin via groups.io wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
>>
>> Current DynamicTablesPkg provide great support for creating dynamic ACPI
>> tables during boot time.
>>
>> However, there are some modules needs minor tweaks to expand support and
>> compatibility for OS requirements and platform needs.
>>
>> This patch series proposes a few fixes to resolve minor issues 
>> discovered
>> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
>>
>> Patch v1 branch: https://github.com/kuqin12/edk2/tree/dynamic_update
>>
>> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>>
>> Kun Qin (6):
>>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to 
>> inf
>>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>>      tables
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>>      space
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>>      config
>>
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c 
>> | 200 ++++++++++++++++----
>> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c 
>> | 135 +++++++++++++
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c 
>> |  80 +++++++-
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf 
>> |   1 +
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf 
>> |   1 +
>>   5 files changed, 379 insertions(+), 38 deletions(-)
>>
>
>
> 
>
>