From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mx.groups.io with SMTP id smtpd.web11.1202.1658367903106955805 for ; Wed, 20 Jul 2022 18:45:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RxCwF+X1; spf=pass (domain: gmail.com, ip: 209.85.215.178, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f178.google.com with SMTP id 72so337752pge.0 for ; Wed, 20 Jul 2022 18:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=M39jsBu3UWWPebdq/5Gd9KcDnwFMojMkea3RqyFj4ss=; b=RxCwF+X1ZKTeGD7Z4WBpcBR3sEQ0TepIYlFWgbwFIFl7kXcq/rFNzQCn/AGPMvXbZ3 6EUOQ/CX0VhLGcmmPnSkeDHpCgwvzKnE6EF7+TQRwSuaRCqCbBSMXad18SBEJJ1eRRGt s+FyDpprAI7v+lPdXiw6Vwj7k4pNudX+1qUHHdFSlLt5NypLc3YeqgxGzSkN4IvAUC4I T3Jg1FS0YFiMoVyZekQW2n9KuvR1LUlZYIrghLsM/4rNgT2FRTPloAsgqS9t+Onl66Ee oX6RK/0KxNl4DuRFQwLfqj/kOPOy1vlS/U+BFy4Sqr+5NjVvXvobQjkyFf3sZDexdm7e KPCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=M39jsBu3UWWPebdq/5Gd9KcDnwFMojMkea3RqyFj4ss=; b=QPD/lrIMPsKS3EGcUONK2xiyZtjEXQ7nRA01ORaijShnvmBO+OHPZ033kWKeSGyllN yNYqGL9tSlJicMBJxcWwW6wbP3np92Gsve0F4NurkDEbHoP19iEUZXhkD4d0SuW1ljwE +VKxrrkuH6Bg9o6I5+549F2zWno0h26bFIogBgzBauC20R51xtFoZnZ34liUIVqsYrRq 0hm69E4ww1rWHRh5dVGJQ9OH8nFyRlVQsQLTnwFd8t2HjH2cool38iooD0wv2UeSWSXQ kHdD9lG8LGXVLy7wt6VFWR0I/yHbDSSEZG21kED6BJRQpC0GsS/o/GHmsLAKohkzbgE/ nhUA== X-Gm-Message-State: AJIora999/UE4bKb/8S9pjrcmXcZL7YDhGc5f7xO/q+eUHfniaN5usTP t6CjigkEzpTTMhAS3YtRfvwqiKgYzg4= X-Google-Smtp-Source: AGRyM1uiSXMfM6u1GHsibacDbniIciBJuc7/X2aRKdi8Dusl2ZK8ujOAux0zTALDQ6wqP+0cWAkWgg== X-Received: by 2002:a05:6a00:450d:b0:52b:84ca:9509 with SMTP id cw13-20020a056a00450d00b0052b84ca9509mr14002827pfb.74.1658367901362; Wed, 20 Jul 2022 18:45:01 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:875:145e:4dd2:e6e6? ([2001:4898:80e8:9:888e:145e:4dd2:e6e6]) by smtp.gmail.com with ESMTPSA id o9-20020a1709026b0900b00161ccdc172dsm200521plk.300.2022.07.20.18.45.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 18:45:01 -0700 (PDT) Message-ID: Date: Wed, 20 Jul 2022 18:45:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [PATCH v1 0/6] Enhance DynamicTablesPkg modules To: devel@edk2.groups.io, pierre.gondois@arm.com Cc: Sami Mujawar , Alexei Fedorov References: <20220719002254.1891-1-kuqin12@gmail.com> <0a79fe66-1bdc-fb7b-54d6-39aa14283882@arm.com> From: "Kun Qin" In-Reply-To: <0a79fe66-1bdc-fb7b-54d6-39aa14283882@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Thank you for the review, Pierre! We will update the patches per your feedback and send v2 after validation. Regards, Kun On 7/20/2022 6:38 AM, PierreGondois wrote: > Except for: > [PATCH v1 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check > for installed tables > [PATCH v1 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to > reserve ECAM space > where I had some remarks, > > Reviewed-by: Pierre Gondois > > Thanks! > > On 7/19/22 02:22, Kun Qin via groups.io wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997 >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 >> >> Current DynamicTablesPkg provide great support for creating dynamic ACPI >> tables during boot time. >> >> However, there are some modules needs minor tweaks to expand support and >> compatibility for OS requirements and platform needs. >> >> This patch series proposes a few fixes to resolve minor issues >> discovered >> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe. >> >> Patch v1 branch: https://github.com/kuqin12/edk2/tree/dynamic_update >> >> Cc: Sami Mujawar >> Cc: Alexei Fedorov >> >> Kun Qin (6): >>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to >> inf >>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing >>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers >>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed >>      tables >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM >>      space >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI >>      config >> >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c >> | 200 ++++++++++++++++---- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c >> | 135 +++++++++++++ >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c >> |  80 +++++++- >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf >> |   1 + >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf >> |   1 + >>   5 files changed, 379 insertions(+), 38 deletions(-) >> > > > > >