From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.1056.1571767548632624589 for ; Tue, 22 Oct 2019 11:05:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V+P+t/AR; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571767547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=efVG9k06yFAqzGS49QzLXuKYkXaQ6lrlE3qdlxnyUNg=; b=V+P+t/ARZq1Jp2WYKw8reTPU0p4+wh8k8X96jI/biRXZIJJw1rD235DXL278j6rcyYeiAA XyZWikEAdv8/Zn2ORmY+eULEDXvt2lf1GhvKaWqcaovDIr82XYcyoWcuOFCqEz17q5GjX3 WgFTBZXTVAAuv7HcSKc36BdE9O+MW4k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-Ew4zZ8VcM4CtTuqHCLjeIQ-1; Tue, 22 Oct 2019 14:05:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6D301005500; Tue, 22 Oct 2019 18:05:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D1905D6B2; Tue, 22 Oct 2019 18:05:43 +0000 (UTC) Subject: Re: [edk2-devel] [Patch v2 1/2] SecurityPkg: Replace EFI_D_* with DEBUG_* To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Jiewen Yao , Jian J Wang , Chao Zhang References: <20191022173716.27700-1-michael.d.kinney@intel.com> <20191022173716.27700-2-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 22 Oct 2019 20:05:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191022173716.27700-2-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: Ew4zZ8VcM4CtTuqHCLjeIQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Mike, On 10/22/19 19:37, Michael D Kinney wrote: > Update all DEBUG() macros in the SecurityPkg to use > DEBUG_ instead of EFI_D_. This is required to pass > PatchCheck.py checks. [...] > 45 files changed, 410 insertions(+), 410 deletions(-) ( If the SecurityPkg maintainers are happy with this patch, then it's not my place to complain. I'd just like to point out that I'd object to such a patch for OvmfPkg. Such sweeping conversions are difficult to review (they are also difficult to implement -- I think mass search&replace is not too safe without human review). New code should not add EFI_D_* usage, of course. I'd expect PatchCheck.py to complain about EFI_D_* only on lines that are added by a patch, not on lines being removed, or present in the context. Is that not the case? ... Hm, looking at patch#2, it seems that some spelling errors affect debug messages. Therefore, some of the typo fixes do turn EFI_D_* macros into new lines. Given that there is a huge number of typo fixes (205 lines, apparently), I guess it makes sense to separate out the EFI_D_* conversion. It's up to the package owners whether they prefer reviewing - 410 lines of EFI_D_* massaging, plus 205 lines of typo fixes, - or 205 lines of { EFI_D_* conversion, plus typo fix }. For OvmfPkg, my choice would likely be (assuming such a large diffstat): - fix EFI_D_*, one patch per module, and only on lines affected by typos, - fix typos, one patch per module. I could suspend and resume a review like that more easily. ) Thanks Laszlo