From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 30 Apr 2019 09:05:26 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C9DB0307D978; Tue, 30 Apr 2019 16:05:25 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-42.rdu2.redhat.com [10.10.121.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B1E410013D9; Tue, 30 Apr 2019 16:05:23 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 1/2] BaseTools: split long line into multiple short lines. To: devel@edk2.groups.io, bob.c.feng@intel.com Cc: Liming Gao References: <20190430110629.12748-1-bob.c.feng@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 30 Apr 2019 18:05:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190430110629.12748-1-bob.c.feng@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 30 Apr 2019 16:05:25 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Bob, On 04/30/19 13:06, Bob Feng wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764 > > To be easy to review in future, split the long line into > multiple shorter lines. > > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > BaseTools/Source/C/Makefiles/header.makefile | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile > index 90fb3453ad..c2397b796c 100644 > --- a/BaseTools/Source/C/Makefiles/header.makefile > +++ b/BaseTools/Source/C/Makefiles/header.makefile > @@ -66,13 +66,16 @@ BUILD_CPPFLAGS = $(INCLUDE) > # keep EXTRA_OPTFLAGS last > BUILD_OPTFLAGS = -O2 $(EXTRA_OPTFLAGS) > > ifeq ($(DARWIN),Darwin) > # assume clang or clang compatible flags on OS X > -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g > +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \ > +-Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g > else > -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g > +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \ > +-Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict \ > +-Wno-unused-result -nostdlib -g > endif > BUILD_LFLAGS = > BUILD_CXXFLAGS = -Wno-unused-result > > ifeq ($(HOST_ARCH), IA32) > can you please configure your git setup to post the patches in a patch series with "shallow threading"? (That is, there should be one cover letter email, and all the patches should be direct "responses" to the cover letter email.) For this patch: Reviewed-by: Laszlo Ersek Thanks Laszlo