From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web12.5584.1586423862731539674
 for <devel@edk2.groups.io>;
 Thu, 09 Apr 2020 02:17:42 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jFE/scAP;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1586423861;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FwY9OB5wArgckGY+I35WJjgY/mm+EOl3Dlwe+FcTKAQ=;
	b=jFE/scAPAZZv3r1DdDWUGIF1bCNra14rAlNpJgRd167mgCfrFYHpyfB4ETjWqHYrmEuNGV
	aMArBwLKKKU+a+PeY3h0BGaT+3Q6Hf7XJD8x0vTayxv4l3jmaNvZ/5xqBdDcags0SNIp6K
	qG9mkXJUsHO5UtMoPUoPGrDV6djEAvo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-127-5571FdLXNFSLMRoEDegw6w-1; Thu, 09 Apr 2020 05:17:35 -0400
X-MC-Unique: 5571FdLXNFSLMRoEDegw6w-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F105E1005513;
	Thu,  9 Apr 2020 09:17:33 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-213.ams2.redhat.com [10.36.112.213])
	by smtp.corp.redhat.com (Postfix) with ESMTP id DF3965D9CA;
	Thu,  9 Apr 2020 09:17:32 +0000 (UTC)
Subject: Re: [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI
To: michael.kubacki@outlook.com, devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>, Leif Lindholm <leif@nuviainc.com>
References: <20200408181327.4324-1-michael.kubacki@outlook.com>
 <MWHPR07MB3440D43BC375867FF8C85CBBE9C00@MWHPR07MB3440.namprd07.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <b5426798-3dec-cb1b-87cc-dbb939764f3d@redhat.com>
Date: Thu, 9 Apr 2020 11:17:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <MWHPR07MB3440D43BC375867FF8C85CBBE9C00@MWHPR07MB3440.namprd07.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi Michael,

On 04/08/20 20:13, michael.kubacki@outlook.com wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
> 
> Add new Azure Pipeline definitions to build and run ArmVirtPkg with:
>   * Ubuntu GCC5
> Add PyTool based build of ArmVirtPkg
> Add extdep for managing the iasl dependency
> Add ArmVirtPkg.ci.yaml for Core CI
> Add README-pytools for details and instructions
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>

The commit message is missing your Signed-off-by. You can & should keep
Sean's of course, but since you are submitting it, I think yours (too)
is required, per "Developer Certificate of Origin" in "Readme.md".

Thanks
Laszlo