From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
by mx.groups.io with SMTP id smtpd.web11.11745.1594108752739683969
for <devel@edk2.groups.io>;
Tue, 07 Jul 2020 00:59:13 -0700
Authentication-Results: mx.groups.io;
dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dAjuE34T;
spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1594108751;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=BuyO6I8/QQ+9drETWquNVm3eTvIgN8LUUdVvj7yXjkY=;
b=dAjuE34TfeckImJMeGfXvABAxDFBuHLpGqMJDbxupcHVF3zkiU4BoN09llYkbWeXaCNM2J
ccAzty0BeVdXqc584FxwKXtVX3ejL9oPHF1EMuQw5RLBj/b3mLg+GWC/FnlS0ZM8K76LlO
g57/jSzJo7s0PpJE2Nj/CsP9PVFvLD4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-226-ntkQa3RRMw2Ht0I-B1FxiQ-1; Tue, 07 Jul 2020 03:59:08 -0400
X-MC-Unique: ntkQa3RRMw2Ht0I-B1FxiQ-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7D3A1005510;
Tue, 7 Jul 2020 07:59:06 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-90.ams2.redhat.com [10.36.114.90])
by smtp.corp.redhat.com (Postfix) with ESMTP id 8743719D7C;
Tue, 7 Jul 2020 07:59:05 +0000 (UTC)
Subject: Re: [PATCH 01/11] OvmfPkg/LsiScsiDxe: Create the empty driver
To: Gary Lin <glin@suse.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <20200701040448.14871-1-glin@suse.com>
<20200701040448.14871-2-glin@suse.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <b589caad-50a0-fd8f-c435-6a74f6779536@redhat.com>
Date: Tue, 7 Jul 2020 09:59:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200701040448.14871-2-glin@suse.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
On 07/01/20 06:04, Gary Lin wrote:
> Create the driver with only a dummy LsiScsiEntryPoint() for the further
> implementation of the driver for LSI 53C895A SCSI controller.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> OvmfPkg/LsiScsiDxe/LsiScsi.c | 25 +++++++++++++++++++++++++
> OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 26 ++++++++++++++++++++++++++
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++++
> OvmfPkg/OvmfPkgIa32.fdf | 3 +++
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++
> OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++
> OvmfPkg/OvmfPkgX64.dsc | 4 ++++
> OvmfPkg/OvmfPkgX64.fdf | 3 +++
> 8 files changed, 72 insertions(+)
> create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsi.c
> create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
>
> diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c
> new file mode 100644
> index 000000000000..9c90941688ed
> --- /dev/null
> +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.c
> @@ -0,0 +1,25 @@
> +/** @file
> +
> + This driver produces Extended SCSI Pass Thru Protocol instances for
> + LSI 53C895A SCSI devices.
> +
> + Copyright (C) 2020, SUSE LLC.
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Uefi/UefiSpec.h>
> +
> +//
> +// Entry point of this driver
> +//
> +EFI_STATUS
> +EFIAPI
> +LsiScsiEntryPoint (
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE *SystemTable
> + )
> +{
> + return EFI_UNSUPPORTED;
> +}
> diff --git a/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> new file mode 100644
> index 000000000000..55b483c2fa20
> --- /dev/null
> +++ b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> @@ -0,0 +1,26 @@
> +## @file
> +# This driver produces Extended SCSI Pass Thru Protocol instances for
> +# LSI 53C895A SCSI devices.
> +#
> +# Copyright (C) 2020, SUSE LLC.
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> + INF_VERSION = 1.29
> + BASE_NAME = LsiScsiDxe
> + FILE_GUID = EB4EB21f-5A3D-40BE-8BD2-F1B0E38E5744
(1) The GUID should not be written in mixed case. Please pick upper case
or lower case for the whole GUID string.
(I wonder how you created the current (mixed-case) GUID string...
uuidgen outputs lower case, and I wonder how one can translate
everything except the *first* "f" from that to upper case. I hope you
didn't manually update a previously generated GUID!)
with the spelling fixed, or the GUID regenerated:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
> + MODULE_TYPE = UEFI_DRIVER
> + VERSION_STRING = 1.0
> + ENTRY_POINT = LsiScsiEntryPoint
> +
> +[Sources]
> + LsiScsi.c
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> + UefiDriverEntryPoint
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index b4ee7376791b..9178ffeb71cb 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -50,6 +50,7 @@ [Defines]
> #
> DEFINE PVSCSI_ENABLE = TRUE
> DEFINE MPT_SCSI_ENABLE = TRUE
> + DEFINE LSI_SCSI_ENABLE = FALSE
>
> #
> # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly to
> @@ -771,6 +772,9 @@ [Components]
> !endif
> !if $(MPT_SCSI_ENABLE) == TRUE
> OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> +!endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> !endif
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
> index e2b759aa8d05..2b9a6b58015f 100644
> --- a/OvmfPkg/OvmfPkgIa32.fdf
> +++ b/OvmfPkg/OvmfPkgIa32.fdf
> @@ -236,6 +236,9 @@ [FV.DXEFV]
> !if $(MPT_SCSI_ENABLE) == TRUE
> INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> !endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> +!endif
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index ed68b080f2a2..a665f78f0dc7 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -49,6 +49,7 @@ [Defines]
> #
> DEFINE PVSCSI_ENABLE = TRUE
> DEFINE MPT_SCSI_ENABLE = TRUE
> + DEFINE LSI_SCSI_ENABLE = FALSE
>
> #
> # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly to
> @@ -785,6 +786,9 @@ [Components.X64]
> !endif
> !if $(MPT_SCSI_ENABLE) == TRUE
> OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> +!endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> !endif
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
> index bfca1eff9e83..83ff6aef2e8c 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.fdf
> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
> @@ -237,6 +237,9 @@ [FV.DXEFV]
> !if $(MPT_SCSI_ENABLE) == TRUE
> INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> !endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> +!endif
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index cb7e8068a3d8..17f345acf4ee 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -49,6 +49,7 @@ [Defines]
> #
> DEFINE PVSCSI_ENABLE = TRUE
> DEFINE MPT_SCSI_ENABLE = TRUE
> + DEFINE LSI_SCSI_ENABLE = FALSE
>
> #
> # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly to
> @@ -781,6 +782,9 @@ [Components]
> !endif
> !if $(MPT_SCSI_ENABLE) == TRUE
> OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> +!endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> !endif
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
> index bfca1eff9e83..83ff6aef2e8c 100644
> --- a/OvmfPkg/OvmfPkgX64.fdf
> +++ b/OvmfPkg/OvmfPkgX64.fdf
> @@ -237,6 +237,9 @@ [FV.DXEFV]
> !if $(MPT_SCSI_ENABLE) == TRUE
> INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> !endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> +!endif
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
>