* Duplicate Files for StandaloneMmDriverEntryPoint.h
@ 2021-02-22 22:11 Michael Kubacki
2021-02-23 17:37 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Michael Kubacki @ 2021-02-22 22:11 UTC (permalink / raw)
To: devel, sami.mujawar, supreeth.venkatesh, ardb+tianocore,
Jiewen Yao
Is there a particular reason two copies of
StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
1. MdePkg
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
2. StandaloneMmPkg
https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
The only substantial difference (apart from copyright and comment
differences) is that the StandaloneMmPkg instance contains a function
declaration for EfiMain().
Thanks,
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h
2021-02-22 22:11 Duplicate Files for StandaloneMmDriverEntryPoint.h Michael Kubacki
@ 2021-02-23 17:37 ` Laszlo Ersek
2021-02-24 7:51 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2021-02-23 17:37 UTC (permalink / raw)
To: devel, mikuback, sami.mujawar, supreeth.venkatesh, ardb+tianocore,
Jiewen Yao
Hi Michael,
On 02/22/21 23:11, Michael Kubacki wrote:
> Is there a particular reason two copies of
> StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
>
> 1. MdePkg
> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
>
>
> 2. StandaloneMmPkg
> https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
>
>
> The only substantial difference (apart from copyright and comment
> differences) is that the StandaloneMmPkg instance contains a function
> declaration for EfiMain().
I believe this may have been an omission in commit d6253d2f9a33
("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
driver", 2019-03-11).
At that point, both the library class & instance had been migrated to
MdePkg (commits 7df4764e6a81a and 5866d4992396).
Can you propose a patch (unless I'm wrong, of course)?
Thanks
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h
2021-02-23 17:37 ` [edk2-devel] " Laszlo Ersek
@ 2021-02-24 7:51 ` Ard Biesheuvel
2021-02-25 2:38 ` Michael Kubacki
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2021-02-24 7:51 UTC (permalink / raw)
To: Laszlo Ersek
Cc: devel, Michael Kubacki, Sami Mujawar, Supreeth Venkatesh,
Ard Biesheuvel, Jiewen Yao
On Tue, 23 Feb 2021 at 18:37, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Hi Michael,
>
> On 02/22/21 23:11, Michael Kubacki wrote:
> > Is there a particular reason two copies of
> > StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
> >
> > 1. MdePkg
> > https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> >
> >
> > 2. StandaloneMmPkg
> > https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> >
> >
> > The only substantial difference (apart from copyright and comment
> > differences) is that the StandaloneMmPkg instance contains a function
> > declaration for EfiMain().
>
> I believe this may have been an omission in commit d6253d2f9a33
> ("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
> driver", 2019-03-11).
>
> At that point, both the library class & instance had been migrated to
> MdePkg (commits 7df4764e6a81a and 5866d4992396).
>
> Can you propose a patch (unless I'm wrong, of course)?
>
I think you are correct.
For a patch that deletes
StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
and any stale references to it that may exist:
Acked-by: Ard Biesheuvel <ardb@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h
2021-02-24 7:51 ` Ard Biesheuvel
@ 2021-02-25 2:38 ` Michael Kubacki
0 siblings, 0 replies; 4+ messages in thread
From: Michael Kubacki @ 2021-02-25 2:38 UTC (permalink / raw)
To: devel, ardb, Laszlo Ersek
Cc: Sami Mujawar, Supreeth Venkatesh, Ard Biesheuvel, Jiewen Yao
Thanks for the background. I'll go ahead and send that patch.
On 2/23/2021 11:51 PM, Ard Biesheuvel wrote:
> On Tue, 23 Feb 2021 at 18:37, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> Hi Michael,
>>
>> On 02/22/21 23:11, Michael Kubacki wrote:
>>> Is there a particular reason two copies of
>>> StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
>>>
>>> 1. MdePkg
>>> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
>>>
>>>
>>> 2. StandaloneMmPkg
>>> https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
>>>
>>>
>>> The only substantial difference (apart from copyright and comment
>>> differences) is that the StandaloneMmPkg instance contains a function
>>> declaration for EfiMain().
>>
>> I believe this may have been an omission in commit d6253d2f9a33
>> ("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
>> driver", 2019-03-11).
>>
>> At that point, both the library class & instance had been migrated to
>> MdePkg (commits 7df4764e6a81a and 5866d4992396).
>>
>> Can you propose a patch (unless I'm wrong, of course)?
>>
>
> I think you are correct.
>
> For a patch that deletes
>
> StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
>
> and any stale references to it that may exist:
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-25 2:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-22 22:11 Duplicate Files for StandaloneMmDriverEntryPoint.h Michael Kubacki
2021-02-23 17:37 ` [edk2-devel] " Laszlo Ersek
2021-02-24 7:51 ` Ard Biesheuvel
2021-02-25 2:38 ` Michael Kubacki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox